[kbuild-all] [sashal-linux-stable:pending-5.13 372/570] drivers/power/supply/ab8500_fg.c:3061:32: error: 'np' undeclared; did you mean 'up'?

tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git pending-5.13 head: 0c91fa6be7e9e93e0ff59925e742ebb9d86fb057 commit: 600a61ac017d081e0bbefc88ad24c787a8942c55 [372/570] power: supply: ab8500: Move to componentized binding config: arm-allyesconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c... git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git git fetch --no-tags sashal-linux-stable pending-5.13 git checkout 600a61ac017d081e0bbefc88ad24c787a8942c55 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/power/supply/ab8500_fg.c: In function 'ab8500_fg_probe': 3061 | ret = ab8500_bm_of_probe(dev, np, di->bm); | ^~ | up drivers/power/supply/ab8500_fg.c:3061:32: note: each undeclared identifier is reported only once for each function it appears in vim +3061 drivers/power/supply/ab8500_fg.c 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3046 c8afa6406e60ae drivers/power/ab8500_fg.c Bill Pemberton 2012-11-19 3047 static int ab8500_fg_probe(struct platform_device *pdev) 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3048 { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3049 struct device *dev = &pdev->dev; 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3050 struct power_supply_config psy_cfg = {}; e0f1abeba5c2d8 drivers/power/ab8500_fg.c Rajanikanth H.V 2012-11-18 3051 struct ab8500_fg *di; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3052 int i, irq; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3053 int ret = 0; 2aac3de19b7260 drivers/power/ab8500_fg.c Lee Jones 2012-05-05 3054 ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3055 di = devm_kzalloc(dev, sizeof(*di), GFP_KERNEL); ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3056 if (!di) e0f1abeba5c2d8 drivers/power/ab8500_fg.c Rajanikanth H.V 2012-11-18 3057 return -ENOMEM; 195c1c660c1868 drivers/power/ab8500_fg.c Lee Jones 2012-11-30 3058 417c0fc24dd4db drivers/power/supply/ab8500_fg.c Linus Walleij 2021-03-12 3059 di->bm = &ab8500_bm_data; 195c1c660c1868 drivers/power/ab8500_fg.c Lee Jones 2012-11-30 3060 ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 @3061 ret = ab8500_bm_of_probe(dev, np, di->bm); e0f1abeba5c2d8 drivers/power/ab8500_fg.c Rajanikanth H.V 2012-11-18 3062 if (ret) { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3063 dev_err(dev, "failed to get battery information\n"); e0f1abeba5c2d8 drivers/power/ab8500_fg.c Rajanikanth H.V 2012-11-18 3064 return ret; e0f1abeba5c2d8 drivers/power/ab8500_fg.c Rajanikanth H.V 2012-11-18 3065 } 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3066 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3067 mutex_init(&di->cc_lock); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3068 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3069 /* get parent data */ ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3070 di->dev = dev; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3071 di->parent = dev_get_drvdata(pdev->dev.parent); 1e82623c3ca6f5 drivers/power/supply/ab8500_fg.c Linus Walleij 2019-10-11 3072 ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3073 di->main_bat_v = devm_iio_channel_get(dev, "main_bat_v"); 1e82623c3ca6f5 drivers/power/supply/ab8500_fg.c Linus Walleij 2019-10-11 3074 if (IS_ERR(di->main_bat_v)) { 36f1de0d5c4630 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3075 ret = dev_err_probe(dev, PTR_ERR(di->main_bat_v), 36f1de0d5c4630 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3076 "failed to get main battery ADC channel\n"); 36f1de0d5c4630 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3077 return ret; 1e82623c3ca6f5 drivers/power/supply/ab8500_fg.c Linus Walleij 2019-10-11 3078 } 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3079 2dc9215d7c94f7 drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 3080 psy_cfg.supplied_to = supply_interface; 2dc9215d7c94f7 drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 3081 psy_cfg.num_supplicants = ARRAY_SIZE(supply_interface); 297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 3082 psy_cfg.drv_data = di; 2dc9215d7c94f7 drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 3083 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3084 di->bat_cap.max_mah_design = MILLI_TO_MICRO * b0284de05e07d5 drivers/power/ab8500_fg.c Lee Jones 2012-11-30 3085 di->bm->bat_type[di->bm->batt_id].charge_full_design; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3086 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3087 di->bat_cap.max_mah = di->bat_cap.max_mah_design; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3088 b0284de05e07d5 drivers/power/ab8500_fg.c Lee Jones 2012-11-30 3089 di->vbat_nom = di->bm->bat_type[di->bm->batt_id].nominal_voltage; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3090 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3091 di->init_capacity = true; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3092 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3093 ab8500_fg_charge_state_to(di, AB8500_FG_CHARGE_INIT); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3094 ab8500_fg_discharge_state_to(di, AB8500_FG_DISCHARGE_INIT); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3095 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3096 /* Init work for running the fg algorithm instantly */ 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3097 INIT_WORK(&di->fg_work, ab8500_fg_instant_work); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3098 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3099 /* Init work for getting the battery accumulated current */ 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3100 INIT_WORK(&di->fg_acc_cur_work, ab8500_fg_acc_cur_work); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3101 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3102 /* Init work for reinitialising the fg algorithm */ 203b42f7317494 drivers/power/ab8500_fg.c Tejun Heo 2012-08-21 3103 INIT_DEFERRABLE_WORK(&di->fg_reinit_work, 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3104 ab8500_fg_reinit_work); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3105 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3106 /* Work delayed Queue to run the state machine */ 203b42f7317494 drivers/power/ab8500_fg.c Tejun Heo 2012-08-21 3107 INIT_DEFERRABLE_WORK(&di->fg_periodic_work, 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3108 ab8500_fg_periodic_work); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3109 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3110 /* Work to check low battery condition */ 203b42f7317494 drivers/power/ab8500_fg.c Tejun Heo 2012-08-21 3111 INIT_DEFERRABLE_WORK(&di->fg_low_bat_work, 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3112 ab8500_fg_low_bat_work); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3113 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3114 /* Init work for HW failure check */ 203b42f7317494 drivers/power/ab8500_fg.c Tejun Heo 2012-08-21 3115 INIT_DEFERRABLE_WORK(&di->fg_check_hw_failure_work, 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3116 ab8500_fg_check_hw_failure_work); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3117 75f2a219ff11e6 drivers/power/ab8500_fg.c Hakan Berg 2012-05-10 3118 /* Reset battery low voltage flag */ 75f2a219ff11e6 drivers/power/ab8500_fg.c Hakan Berg 2012-05-10 3119 di->flags.low_bat = false; 75f2a219ff11e6 drivers/power/ab8500_fg.c Hakan Berg 2012-05-10 3120 75f2a219ff11e6 drivers/power/ab8500_fg.c Hakan Berg 2012-05-10 3121 /* Initialize low battery counter */ 75f2a219ff11e6 drivers/power/ab8500_fg.c Hakan Berg 2012-05-10 3122 di->low_bat_cnt = 10; 75f2a219ff11e6 drivers/power/ab8500_fg.c Hakan Berg 2012-05-10 3123 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3124 /* Initialize OVV, and other registers */ 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3125 ret = ab8500_fg_init_hw_registers(di); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3126 if (ret) { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3127 dev_err(dev, "failed to initialize registers\n"); 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3128 return ret; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3129 } 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3130 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3131 /* Consider battery unknown until we're informed otherwise */ 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3132 di->flags.batt_unknown = true; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3133 di->flags.batt_id_received = false; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3134 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3135 /* Register FG power supply class */ 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3136 di->fg_psy = devm_power_supply_register(dev, &ab8500_fg_desc, &psy_cfg); 297d716f6260cc drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-03-12 3137 if (IS_ERR(di->fg_psy)) { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3138 dev_err(dev, "failed to register FG psy\n"); 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3139 return PTR_ERR(di->fg_psy); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3140 } 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3141 b0284de05e07d5 drivers/power/ab8500_fg.c Lee Jones 2012-11-30 3142 di->fg_samples = SEC_TO_SAMPLE(di->bm->fg_params->init_timer); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3143 3988a4df3499e6 drivers/power/ab8500_fg.c Johan Bjornstedt 2013-01-11 3144 /* 3988a4df3499e6 drivers/power/ab8500_fg.c Johan Bjornstedt 2013-01-11 3145 * Initialize completion used to notify completion and start 3988a4df3499e6 drivers/power/ab8500_fg.c Johan Bjornstedt 2013-01-11 3146 * of inst current 3988a4df3499e6 drivers/power/ab8500_fg.c Johan Bjornstedt 2013-01-11 3147 */ 3988a4df3499e6 drivers/power/ab8500_fg.c Johan Bjornstedt 2013-01-11 3148 init_completion(&di->ab8500_fg_started); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3149 init_completion(&di->ab8500_fg_complete); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3150 02232be7a2bf6e drivers/power/ab8500_fg.c Valentin Rothberg 2015-02-16 3151 /* Register primary interrupt handlers */ 807042539d8ed1 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3152 for (i = 0; i < ARRAY_SIZE(ab8500_fg_irq); i++) { 807042539d8ed1 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3153 irq = platform_get_irq_byname(pdev, ab8500_fg_irq[i].name); 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3154 if (irq < 0) 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3155 return irq; b10e97003d28f6 drivers/power/supply/ab8500_fg.c Krzysztof Kozlowski 2019-10-04 3156 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3157 ret = devm_request_threaded_irq(dev, irq, NULL, 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3158 ab8500_fg_irq[i].isr, 02232be7a2bf6e drivers/power/ab8500_fg.c Valentin Rothberg 2015-02-16 3159 IRQF_SHARED | IRQF_NO_SUSPEND | IRQF_ONESHOT, 807042539d8ed1 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3160 ab8500_fg_irq[i].name, di); 02232be7a2bf6e drivers/power/ab8500_fg.c Valentin Rothberg 2015-02-16 3161 02232be7a2bf6e drivers/power/ab8500_fg.c Valentin Rothberg 2015-02-16 3162 if (ret != 0) { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3163 dev_err(dev, "failed to request %s IRQ %d: %d\n", 807042539d8ed1 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3164 ab8500_fg_irq[i].name, irq, ret); 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3165 return ret; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3166 } ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3167 dev_dbg(dev, "Requested %s IRQ %d: %d\n", 807042539d8ed1 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3168 ab8500_fg_irq[i].name, irq, ret); 807042539d8ed1 drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3169 } 02232be7a2bf6e drivers/power/ab8500_fg.c Valentin Rothberg 2015-02-16 3170 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3171 di->irq = platform_get_irq_byname(pdev, "CCEOC"); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3172 disable_irq(di->irq); 3988a4df3499e6 drivers/power/ab8500_fg.c Johan Bjornstedt 2013-01-11 3173 di->nbr_cceoc_irq_cnt = 0; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3174 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3175 platform_set_drvdata(pdev, di); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3176 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3177 ret = ab8500_fg_sysfs_init(di); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3178 if (ret) { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3179 dev_err(dev, "failed to create sysfs entry\n"); 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3180 return ret; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3181 } 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3182 c75cfa9e27818b drivers/power/ab8500_fg.c Krzysztof Kozlowski 2015-01-29 3183 ret = ab8500_fg_sysfs_psy_create_attrs(di); 93ff722e88530b drivers/power/ab8500_fg.c Lee Jones 2012-05-31 3184 if (ret) { ad89cb5f0a1ffa drivers/power/supply/ab8500_fg.c Linus Walleij 2020-12-12 3185 dev_err(dev, "failed to create FG psy\n"); 93ff722e88530b drivers/power/ab8500_fg.c Lee Jones 2012-05-31 3186 ab8500_fg_sysfs_exit(di); 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3187 return ret; 93ff722e88530b drivers/power/ab8500_fg.c Lee Jones 2012-05-31 3188 } 93ff722e88530b drivers/power/ab8500_fg.c Lee Jones 2012-05-31 3189 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3190 /* Calibrate the fg first time */ 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3191 di->flags.calibrate = true; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3192 di->calib_state = AB8500_FG_CALIB_INIT; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3193 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3194 /* Use room temp as default value until we get an update from driver. */ 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3195 di->bat_temp = 210; 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3196 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3197 list_add_tail(&di->node, &ab8500_fg_list); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3198 600a61ac017d08 drivers/power/supply/ab8500_fg.c Linus Walleij 2021-05-23 3199 return component_add(dev, &ab8500_fg_component_ops); 13151631b5bd06 drivers/power/ab8500_fg.c Arun Murthy 2012-02-29 3200 } ccc023a5817556 drivers/power/supply/ab8500_fg.c Krzysztof Kozlowski 2019-10-04 3201 :::::: The code at line 3061 was first introduced by commit :::::: ad89cb5f0a1ffad6ae9ba277f99fea830d135e7c power: supply: ab8500: Use local helper :::::: TO: Linus Walleij <linus.walleij(a)linaro.org&gt; :::::: CC: Sebastian Reichel <sebastian.reichel(a)collabora.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org