[kbuild-all] [sashal-linux-stable:queue-5.4 21/214] drivers/clk/clk-scmi.c:134:9: warning: Identical condition 'ret', second condition is always false

tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-5.4 head: 84bd178b93c5dd8e856f8cd3266e7c1641eab81c commit: 336512c9d93ebc3562119ede6450b6309b8af1e6 [21/214] clk: scmi: Fix min and max rate when registering clocks with discrete rates compiler: aarch64-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; cppcheck warnings: (new ones prefixed by >>) return ret; ^ drivers/clk/clk-scmi.c:117:6: note: first condition if (ret) ^ drivers/clk/clk-scmi.c:134:9: note: second condition return ret; ^ -- return (!afbc) || (afbc && sparse); ^ # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c... git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git git fetch --no-tags sashal-linux-stable queue-5.4 git checkout 336512c9d93ebc3562119ede6450b6309b8af1e6 vim +/ret +134 drivers/clk/clk-scmi.c 6d6a1d82eaef705 Sudeep Holla 2017-06-13 102 6d6a1d82eaef705 Sudeep Holla 2017-06-13 103 static int scmi_clk_ops_init(struct device *dev, struct scmi_clk *sclk) 6d6a1d82eaef705 Sudeep Holla 2017-06-13 104 { 6d6a1d82eaef705 Sudeep Holla 2017-06-13 105 int ret; 336512c9d93ebc3 Sudeep Holla 2020-07-09 106 unsigned long min_rate, max_rate; 336512c9d93ebc3 Sudeep Holla 2020-07-09 107 6d6a1d82eaef705 Sudeep Holla 2017-06-13 108 struct clk_init_data init = { 6d6a1d82eaef705 Sudeep Holla 2017-06-13 109 .flags = CLK_GET_RATE_NOCACHE, 6d6a1d82eaef705 Sudeep Holla 2017-06-13 110 .num_parents = 0, 6d6a1d82eaef705 Sudeep Holla 2017-06-13 111 .ops = &scmi_clk_ops, 6d6a1d82eaef705 Sudeep Holla 2017-06-13 112 .name = sclk->info->name, 6d6a1d82eaef705 Sudeep Holla 2017-06-13 113 }; 6d6a1d82eaef705 Sudeep Holla 2017-06-13 114 6d6a1d82eaef705 Sudeep Holla 2017-06-13 115 sclk->hw.init = &init; 6d6a1d82eaef705 Sudeep Holla 2017-06-13 116 ret = devm_clk_hw_register(dev, &sclk->hw); 336512c9d93ebc3 Sudeep Holla 2020-07-09 117 if (ret) 336512c9d93ebc3 Sudeep Holla 2020-07-09 118 return ret; 336512c9d93ebc3 Sudeep Holla 2020-07-09 119 336512c9d93ebc3 Sudeep Holla 2020-07-09 120 if (sclk->info->rate_discrete) { 336512c9d93ebc3 Sudeep Holla 2020-07-09 121 int num_rates = sclk->info->list.num_rates; 336512c9d93ebc3 Sudeep Holla 2020-07-09 122 336512c9d93ebc3 Sudeep Holla 2020-07-09 123 if (num_rates <= 0) 336512c9d93ebc3 Sudeep Holla 2020-07-09 124 return -EINVAL; 336512c9d93ebc3 Sudeep Holla 2020-07-09 125 336512c9d93ebc3 Sudeep Holla 2020-07-09 126 min_rate = sclk->info->list.rates[0]; 336512c9d93ebc3 Sudeep Holla 2020-07-09 127 max_rate = sclk->info->list.rates[num_rates - 1]; 336512c9d93ebc3 Sudeep Holla 2020-07-09 128 } else { 336512c9d93ebc3 Sudeep Holla 2020-07-09 129 min_rate = sclk->info->range.min_rate; 336512c9d93ebc3 Sudeep Holla 2020-07-09 130 max_rate = sclk->info->range.max_rate; 336512c9d93ebc3 Sudeep Holla 2020-07-09 131 } 336512c9d93ebc3 Sudeep Holla 2020-07-09 132 336512c9d93ebc3 Sudeep Holla 2020-07-09 133 clk_hw_set_rate_range(&sclk->hw, min_rate, max_rate); 6d6a1d82eaef705 Sudeep Holla 2017-06-13 @134 return ret; 6d6a1d82eaef705 Sudeep Holla 2017-06-13 135 } 6d6a1d82eaef705 Sudeep Holla 2017-06-13 136 :::::: The code at line 134 was first introduced by commit :::::: 6d6a1d82eaef705f150c441350559bf5daccb533 clk: add support for clocks provided by SCMI :::::: TO: Sudeep Holla <sudeep.holla(a)arm.com&gt; :::::: CC: Sudeep Holla <sudeep.holla(a)arm.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org