5:46 p.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: d2a22790db7075dbd0738d24d1c5ee4611421c4c
commit: 7e4d47596b686bb2714d05f8774ada884ec8983d [13622/14083] ionic: replay filters after
fw upgrade
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
cppcheck warnings: (new ones prefixed by >>)
drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c:25:21: warning: The scope of the
variable 'head' can be reduced. [variableScope]
struct hlist_head *head;
^
drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c:82:21: warning: The scope of the
variable 'head' can be reduced. [variableScope]
struct hlist_head *head;
^
> drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c:28:10:
warning: Variable 'err' is assigned a value that is never used. [unreadVariable]
int err = 0;
^
vim +/err +28 drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
19
20 void ionic_rx_filter_replay(struct ionic_lif *lif)
21 {
22 struct ionic_rx_filter_add_cmd *ac;
23 struct ionic_admin_ctx ctx;
24 struct ionic_rx_filter *f;
25 struct hlist_head *head;
26 struct hlist_node *tmp;
27 unsigned int i;
28 int err = 0;
29
30 ac = &ctx.cmd.rx_filter_add;
31
32 for (i = 0; i < IONIC_RX_FILTER_HLISTS; i++) {
33 head = &lif->rx_filters.by_id[i];
34 hlist_for_each_entry_safe(f, tmp, head, by_id) {
35 ctx.work = COMPLETION_INITIALIZER_ONSTACK(ctx.work);
36 memcpy(ac, &f->cmd, sizeof(f->cmd));
37 dev_dbg(&lif->netdev->dev, "replay filter command:\n");
38 dynamic_hex_dump("cmd ", DUMP_PREFIX_OFFSET, 16, 1,
39 &ctx.cmd, sizeof(ctx.cmd), true);
40
41 err = ionic_adminq_post_wait(lif, &ctx);
42 if (err) {
43 switch (le16_to_cpu(ac->match)) {
44 case IONIC_RX_FILTER_MATCH_VLAN:
45 netdev_info(lif->netdev, "Replay failed - %d: vlan %d\n",
46 err,
47 le16_to_cpu(ac->vlan.vlan));
48 break;
49 case IONIC_RX_FILTER_MATCH_MAC:
50 netdev_info(lif->netdev, "Replay failed - %d: mac %pM\n",
51 err, ac->mac.addr);
52 break;
53 case IONIC_RX_FILTER_MATCH_MAC_VLAN:
54 netdev_info(lif->netdev, "Replay failed - %d: vlan %d mac
%pM\n",
55 err,
56 le16_to_cpu(ac->vlan.vlan),
57 ac->mac.addr);
58 break;
59 }
60 }
61 }
62 }
63 }
64
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org