10:01 p.m.
Hi Divya,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linux/master]
[also build test WARNING on linus/master v5.9-rc5 next-20200916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Divya-Bharathi/Introduce-support...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
bcf876870b95592b52519ed4aafcf9d95999bc9c
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/platform/x86/dell-wmi-enum-attributes.c:9:
> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning:
no previous prototype for 'get_enumeration_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-enum-attributes.c:28:1: note: in expansion of macro
'get_instance_id'
28 | get_instance_id(enumeration);
| ^~~~~~~~~~~~~~~
> drivers/platform/x86/dell-wmi-enum-attributes.c:57:5: warning: no
previous prototype for 'validate_enumeration_input' [-Wmissing-prototypes]
57 | int validate_enumeration_input(int instance_id, const char *buf)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/platform/x86/dell-wmi-int-attributes.c:9:
> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning:
no previous prototype for 'get_integer_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-int-attributes.c:29:1: note: in expansion of macro
'get_instance_id'
29 | get_instance_id(integer);
| ^~~~~~~~~~~~~~~
> drivers/platform/x86/dell-wmi-int-attributes.c:58:5: warning: no
previous prototype for 'validate_integer_input' [-Wmissing-prototypes]
58 | int validate_integer_input(int instance_id, const char *buf)
| ^~~~~~~~~~~~~~~~~~~~~~
--
In file included from drivers/platform/x86/dell-wmi-string-attributes.c:9:
> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning:
no previous prototype for 'get_str_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-string-attributes.c:28:1: note: in expansion of macro
'get_instance_id'
28 | get_instance_id(str);
| ^~~~~~~~~~~~~~~
> drivers/platform/x86/dell-wmi-string-attributes.c:57:5: warning:
no previous prototype for 'validate_str_input' [-Wmissing-prototypes]
57 | int validate_str_input(int instance_id, const char *buf)
| ^~~~~~~~~~~~~~~~~~
--
In file included from drivers/platform/x86/dell-wmi-passobj-attributes.c:9:
> drivers/platform/x86/dell-wmi-sysman-attributes.h:53:5: warning:
no previous prototype for 'get_po_instance_id' [-Wmissing-prototypes]
53 | int get_##type##_instance_id(struct kobject *kobj) \
| ^~~~
drivers/platform/x86/dell-wmi-passobj-attributes.c:24:1: note: in expansion of macro
'get_instance_id'
24 | get_instance_id(po);
| ^~~~~~~~~~~~~~~
# https://github.com/0day-ci/linux/commit/4809f4528720c1aa027b717b66960848b...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Divya-Bharathi/Introduce-support-for-Systems-Management-Driver-over-WMI-for-Dell-Systems/20200917-145838
git checkout 4809f4528720c1aa027b717b66960848bdae7b58
vim +/get_enumeration_instance_id +53 drivers/platform/x86/dell-wmi-sysman-attributes.h
51
52 #define get_instance_id(type) \
53 int get_##type##_instance_id(struct kobject *kobj) \
54 { \
55 int i; \
56 for (i = 0; i <= type##_instances_count; i++) { \
57 if (!(strcmp(kobj->name, type##_data[i].attribute_name))) \
58 return i; \
59 } \
60 return -EIO; \
61 }
62
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org