[kbuild-all] [lunn:v5.9-rc1-net-next-mv88e6xxx-region-v3 11/14] net/core/devlink.c:3981 devlink_nl_region_notify_build() warn: passing zero to 'ERR_PTR'

tree: https://github.com/lunn/linux.git v5.9-rc1-net-next-mv88e6xxx-region-v3 head: 55b9d3535a4fa84921397a5f206f497018df4377 commit: 32b0f7ffc39e83b2212f0a73a24f87f79bae1cc6 [11/14] net: devlink: Add support for port regions config: x86_64-randconfig-m001-20200920 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; New smatch warnings: net/core/devlink.c:3981 devlink_nl_region_notify_build() warn: passing zero to 'ERR_PTR' net/core/devlink.c:4694 devlink_nl_cmd_region_read_dumpit() warn: inconsistent returns 'devlink_mutex'. net/core/devlink.c:4694 devlink_nl_cmd_region_read_dumpit() warn: inconsistent returns 'devlink->lock'. Old smatch warnings: net/core/devlink.c:5383 devlink_fmsg_prepare_skb() error: uninitialized symbol 'err'. # https://github.com/lunn/linux/commit/32b0f7ffc39e83b2212f0a73a24f87f79bae... git remote add lunn https://github.com/lunn/linux.git git fetch --no-tags lunn v5.9-rc1-net-next-mv88e6xxx-region-v3 git checkout 32b0f7ffc39e83b2212f0a73a24f87f79bae1cc6 vim +/ERR_PTR +3981 net/core/devlink.c dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3927 static struct sk_buff * dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3928 devlink_nl_region_notify_build(struct devlink_region *region, 866319bb943761 Alex Vesker 2018-07-12 3929 struct devlink_snapshot *snapshot, dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3930 enum devlink_command cmd, u32 portid, u32 seq) 866319bb943761 Alex Vesker 2018-07-12 3931 { 866319bb943761 Alex Vesker 2018-07-12 3932 struct devlink *devlink = region->devlink; 866319bb943761 Alex Vesker 2018-07-12 3933 struct sk_buff *msg; 866319bb943761 Alex Vesker 2018-07-12 3934 void *hdr; 866319bb943761 Alex Vesker 2018-07-12 3935 int err; 866319bb943761 Alex Vesker 2018-07-12 3936 866319bb943761 Alex Vesker 2018-07-12 3937 866319bb943761 Alex Vesker 2018-07-12 3938 msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL); 866319bb943761 Alex Vesker 2018-07-12 3939 if (!msg) dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3940 return ERR_PTR(-ENOMEM); 866319bb943761 Alex Vesker 2018-07-12 3941 dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3942 hdr = genlmsg_put(msg, portid, seq, &devlink_nl_family, 0, cmd); dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3943 if (!hdr) { dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3944 err = -EMSGSIZE; 866319bb943761 Alex Vesker 2018-07-12 3945 goto out_free_msg; dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3946 } 866319bb943761 Alex Vesker 2018-07-12 3947 866319bb943761 Alex Vesker 2018-07-12 3948 err = devlink_nl_put_handle(msg, devlink); 866319bb943761 Alex Vesker 2018-07-12 3949 if (err) 866319bb943761 Alex Vesker 2018-07-12 3950 goto out_cancel_msg; 866319bb943761 Alex Vesker 2018-07-12 3951 32b0f7ffc39e83 Andrew Lunn 2020-09-09 3952 if (region->port) 32b0f7ffc39e83 Andrew Lunn 2020-09-09 3953 if (nla_put_u32(msg, DEVLINK_ATTR_PORT_INDEX, 32b0f7ffc39e83 Andrew Lunn 2020-09-09 3954 region->port->index)) 32b0f7ffc39e83 Andrew Lunn 2020-09-09 3955 goto out_cancel_msg; The error is not set on this path. 32b0f7ffc39e83 Andrew Lunn 2020-09-09 3956 866319bb943761 Alex Vesker 2018-07-12 3957 err = nla_put_string(msg, DEVLINK_ATTR_REGION_NAME, e8937681797c9a Jacob Keller 2020-03-26 3958 region->ops->name); 866319bb943761 Alex Vesker 2018-07-12 3959 if (err) 866319bb943761 Alex Vesker 2018-07-12 3960 goto out_cancel_msg; 866319bb943761 Alex Vesker 2018-07-12 3961 866319bb943761 Alex Vesker 2018-07-12 3962 if (snapshot) { 866319bb943761 Alex Vesker 2018-07-12 3963 err = nla_put_u32(msg, DEVLINK_ATTR_REGION_SNAPSHOT_ID, 866319bb943761 Alex Vesker 2018-07-12 3964 snapshot->id); 866319bb943761 Alex Vesker 2018-07-12 3965 if (err) 866319bb943761 Alex Vesker 2018-07-12 3966 goto out_cancel_msg; 866319bb943761 Alex Vesker 2018-07-12 3967 } else { 866319bb943761 Alex Vesker 2018-07-12 3968 err = nla_put_u64_64bit(msg, DEVLINK_ATTR_REGION_SIZE, 866319bb943761 Alex Vesker 2018-07-12 3969 region->size, DEVLINK_ATTR_PAD); 866319bb943761 Alex Vesker 2018-07-12 3970 if (err) 866319bb943761 Alex Vesker 2018-07-12 3971 goto out_cancel_msg; 866319bb943761 Alex Vesker 2018-07-12 3972 } 866319bb943761 Alex Vesker 2018-07-12 3973 genlmsg_end(msg, hdr); 866319bb943761 Alex Vesker 2018-07-12 3974 dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3975 return msg; 866319bb943761 Alex Vesker 2018-07-12 3976 866319bb943761 Alex Vesker 2018-07-12 3977 out_cancel_msg: 866319bb943761 Alex Vesker 2018-07-12 3978 genlmsg_cancel(msg, hdr); 866319bb943761 Alex Vesker 2018-07-12 3979 out_free_msg: 866319bb943761 Alex Vesker 2018-07-12 3980 nlmsg_free(msg); dd86fec7e06ab7 Jakub Kicinski 2020-05-01 @3981 return ERR_PTR(err); dd86fec7e06ab7 Jakub Kicinski 2020-05-01 3982 } --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org