11:29 p.m.
Hi Ming,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on e783362eb54cd99b2cac8b3a9aeac942e6f6ac07]
url:
https://github.com/0day-ci/linux/commits/Ming-Qian/amphion-video-decoder-...
base: e783362eb54cd99b2cac8b3a9aeac942e6f6ac07
config: alpha-allyesconfig
(https://download.01.org/0day-ci/archive/20220125/202201252054.hseJFdV8-lk...)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/26fe84b0a51bd240210f39bfc5a2ed1c5...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Ming-Qian/amphion-video-decoder-encoder-driver/20220125-152112
git checkout 26fe84b0a51bd240210f39bfc5a2ed1c57ce8be0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=alpha SHELL=/bin/bash drivers/media/platform/amphion/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/media/platform/amphion/vdec.c: In function 'vdec_cleanup':
drivers/media/platform/amphion/vdec.c:1383:17: error: implicit declaration of function
'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
1383 | vfree(vdec);
| ^~~~~
| kvfree
drivers/media/platform/amphion/vdec.c: In function 'vdec_open':
drivers/media/platform/amphion/vdec.c:1632:16: error: implicit declaration of function
'vzalloc'; did you mean 'kvzalloc'?
[-Werror=implicit-function-declaration]
1632 | inst = vzalloc(sizeof(*inst));
| ^~~~~~~
| kvzalloc
> drivers/media/platform/amphion/vdec.c:1632:14: warning:
assignment to 'struct vpu_inst *' from 'int' makes pointer from integer
without a cast [-Wint-conversion]
1632 | inst = vzalloc(sizeof(*inst));
| ^
> drivers/media/platform/amphion/vdec.c:1636:14: warning:
assignment to 'struct vdec_t *' from 'int' makes pointer from integer
without a cast [-Wint-conversion]
1636 | vdec = vzalloc(sizeof(*vdec));
| ^
cc1: some warnings being treated as errors
vim +1632 drivers/media/platform/amphion/vdec.c
1625
1626 static int vdec_open(struct file *file)
1627 {
1628 struct vpu_inst *inst;
1629 struct vdec_t *vdec;
1630 int ret;
1631
1632 inst = vzalloc(sizeof(*inst));
1633 if (!inst)
1634 return -ENOMEM;
1635
1636 vdec = vzalloc(sizeof(*vdec));
1637 if (!vdec) {
1638 vfree(inst);
1639 return -ENOMEM;
1640 }
1641
1642 inst->ops = &vdec_inst_ops;
1643 inst->formats = vdec_formats;
1644 inst->type = VPU_CORE_TYPE_DEC;
1645 inst->priv = vdec;
1646
1647 ret = vpu_v4l2_open(file, inst);
1648 if (ret)
1649 return ret;
1650
1651 vdec->fixed_fmt = false;
1652 inst->min_buffer_cap = VDEC_MIN_BUFFER_CAP;
1653 vdec_init(file);
1654
1655 return 0;
1656 }
1657
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org