[kbuild-all] Re: [PATCH 54/73] pata_atp867x: convert blank printk() calls

Hi Hannes, I love your patch! Perhaps something to improve: [auto build test WARNING on rostedt-trace/for-next] [also build test WARNING on axboe-block/for-next linus/master v5.16-rc4 next-20211208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/libata-rework-lo... base: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next config: arc-randconfig-r043-20211207 (https://download.01.org/0day-ci/archive/20211209/202112090637.TBRwbH92-lk...) compiler: arceb-elf-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/bd6ed9c4fe23f7c395cacd847a03e6bab... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hannes-Reinecke/libata-rework-logging-take-II/20211209-003634 git checkout bd6ed9c4fe23f7c395cacd847a03e6babd390e1f # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/ata/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from include/linux/device.h:15, from include/linux/pci.h:37, from drivers/ata/pata_atp867x.c:17: drivers/ata/pata_atp867x.c: In function 'atp867x_check_ports': 313 | (unsigned long long)ioaddr->cmd_addr, | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:314:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 314 | (unsigned long long)ATP867X_IO_PORTBASE(ap, port), | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:315:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 315 | (unsigned long long)ioaddr->ctl_addr, | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:316:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 316 | (unsigned long long)ATP867X_IO_ALTSTATUS(ap, port), | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:317:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 317 | (unsigned long long)ioaddr->bmdma_addr, | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:318:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 318 | (unsigned long long)ATP867X_IO_DMABASE(ap, port), | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:319:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 319 | (unsigned long long)ioaddr->data_addr, | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:320:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 320 | (unsigned long long)ioaddr->error_addr, | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ | ^~~~~~~~~~~ include/linux/libata.h:1452:9: note: in expansion of macro 'dev_dbg' 1452 | dev_dbg(&ap->tdev, "%s: " fmt, __func__, ##__VA_ARGS__) | ^~~~~~~ drivers/ata/pata_atp867x.c:293:9: note: in expansion of macro 'ata_port_dbg' 293 | ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" | ^~~~~~~~~~~~ drivers/ata/pata_atp867x.c:321:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 321 | (unsigned long long)ioaddr->feature_addr, | ^ include/linux/dev_printk.h:129:48: note: in definition of macro 'dev_printk' 129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \ vim +313 drivers/ata/pata_atp867x.c d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 287) d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 288) static void atp867x_check_ports(struct ata_port *ap, int port) d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 289) { d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 290) struct ata_ioports *ioaddr = &ap->ioaddr; d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 291) struct atp867x_priv *dp = ap->private_data; d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 292) bd6ed9c4fe23f7 Hannes Reinecke 2021-12-08 293 ata_port_dbg(ap, "ATP867X: port[%d] addresses\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 294) " cmd_addr =0x%llx, 0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 295) " ctl_addr =0x%llx, 0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 296) " bmdma_addr =0x%llx, 0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 297) " data_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 298) " error_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 299) " feature_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 300) " nsect_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 301) " lbal_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 302) " lbam_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 303) " lbah_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 304) " device_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 305) " status_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 306) " command_addr =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 307) " dp->dma_mode =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 308) " dp->mstr_piospd =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 309) " dp->slave_piospd =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 310) " dp->eightb_piospd =0x%llx\n" d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 311) " dp->pci66mhz =0x%lx\n", d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 312) port, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 @313) (unsigned long long)ioaddr->cmd_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 314) (unsigned long long)ATP867X_IO_PORTBASE(ap, port), d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 315) (unsigned long long)ioaddr->ctl_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 316) (unsigned long long)ATP867X_IO_ALTSTATUS(ap, port), d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 317) (unsigned long long)ioaddr->bmdma_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 318) (unsigned long long)ATP867X_IO_DMABASE(ap, port), d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 319) (unsigned long long)ioaddr->data_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 320) (unsigned long long)ioaddr->error_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 321) (unsigned long long)ioaddr->feature_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 322) (unsigned long long)ioaddr->nsect_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 323) (unsigned long long)ioaddr->lbal_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 324) (unsigned long long)ioaddr->lbam_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 325) (unsigned long long)ioaddr->lbah_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 326) (unsigned long long)ioaddr->device_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 327) (unsigned long long)ioaddr->status_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 328) (unsigned long long)ioaddr->command_addr, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 329) (unsigned long long)dp->dma_mode, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 330) (unsigned long long)dp->mstr_piospd, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 331) (unsigned long long)dp->slave_piospd, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 332) (unsigned long long)dp->eightb_piospd, d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 333) (unsigned long)dp->pci66mhz); d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 334) } d15d6e6cc34056 John(Jung-Ik Lee 2009-09-14 335) --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org