4:40 a.m.
Hi Russell,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Russell-King/net-phy-at803x-simp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
e93abb840a2c356ed2809c31fcedb058601ac2e4
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/2f590b7f42d30d029ec56cec8429effe8...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Russell-King/net-phy-at803x-simplify-custom-phy-id-matching/20210720-214010
git checkout 2f590b7f42d30d029ec56cec8429effe8505cfb9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/phy/at803x.c: In function 'at803x_get_features':
> drivers/net/phy/at803x.c:706:7: error: implicit declaration of
function 'at803x_match_phy_id' [-Werror=implicit-function-declaration]
706 | if (!at803x_match_phy_id(phydev, ATH8031_PHY_ID))
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/at803x_match_phy_id +706 drivers/net/phy/at803x.c
2318ca8aef3877 Michael Walle 2020-01-30 697
b856150c8098f1 David Bauer 2021-06-27 698 static int at803x_get_features(struct
phy_device *phydev)
b856150c8098f1 David Bauer 2021-06-27 699 {
b856150c8098f1 David Bauer 2021-06-27 700 int err;
b856150c8098f1 David Bauer 2021-06-27 701
b856150c8098f1 David Bauer 2021-06-27 702 err = genphy_read_abilities(phydev);
b856150c8098f1 David Bauer 2021-06-27 703 if (err)
b856150c8098f1 David Bauer 2021-06-27 704 return err;
b856150c8098f1 David Bauer 2021-06-27 705
b856150c8098f1 David Bauer 2021-06-27 @706 if (!at803x_match_phy_id(phydev,
ATH8031_PHY_ID))
b856150c8098f1 David Bauer 2021-06-27 707 return 0;
b856150c8098f1 David Bauer 2021-06-27 708
b856150c8098f1 David Bauer 2021-06-27 709 /* AR8031/AR8033 have different status
registers
b856150c8098f1 David Bauer 2021-06-27 710 * for copper and fiber operation. However,
the
b856150c8098f1 David Bauer 2021-06-27 711 * extended status register is the same for
both
b856150c8098f1 David Bauer 2021-06-27 712 * operation modes.
b856150c8098f1 David Bauer 2021-06-27 713 *
b856150c8098f1 David Bauer 2021-06-27 714 * As a result of that, ESTATUS_1000_XFULL
is set
b856150c8098f1 David Bauer 2021-06-27 715 * to 1 even when operating in copper TP
mode.
b856150c8098f1 David Bauer 2021-06-27 716 *
b856150c8098f1 David Bauer 2021-06-27 717 * Remove this mode from the supported link
modes,
b856150c8098f1 David Bauer 2021-06-27 718 * as this driver currently only supports
copper
b856150c8098f1 David Bauer 2021-06-27 719 * operation.
b856150c8098f1 David Bauer 2021-06-27 720 */
b856150c8098f1 David Bauer 2021-06-27 721
linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseX_Full_BIT,
b856150c8098f1 David Bauer 2021-06-27 722 phydev->supported);
b856150c8098f1 David Bauer 2021-06-27 723 return 0;
b856150c8098f1 David Bauer 2021-06-27 724 }
b856150c8098f1 David Bauer 2021-06-27 725
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org