[kbuild-all] [s390:features 40/44] drivers/gpu/drm/drm_lock.c:75:10: error: passing 'typeof (lock)' (aka 'volatile unsigned int *') to parameter of type 'void *' discards qualifiers

tree: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git features head: 9d42a4d3e27db3cabad82483ed876d4c8b8bed65 commit: 000174233b91340ca52a9eca905d029a9a2aefd9 [40/44] s390/atomic,cmpxchg: switch to use atomic-instrumented.h config: s390-randconfig-r006-20210412 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install s390 cross compiling tool for clang build # apt-get install binutils-s390x-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?id... git remote add s390 https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git git fetch --no-tags s390 features git checkout 000174233b91340ca52a9eca905d029a9a2aefd9 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/drm_lock.c:41: In file included from include/drm/drm_file.h:39: In file included from include/drm/drm_prime.h:37: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:80: include/asm-generic/io.h:464:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __raw_readb(PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:477:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/big_endian.h:36:59: note: expanded from macro '__le16_to_cpu' #define __le16_to_cpu(x) __swab16((__force __u16)(__le16)(x)) ^ include/uapi/linux/swab.h:102:54: note: expanded from macro '__swab16' #define __swab16(x) (__u16)__builtin_bswap16((__u16)(x)) ^ In file included from drivers/gpu/drm/drm_lock.c:41: In file included from include/drm/drm_file.h:39: In file included from include/drm/drm_prime.h:37: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:80: include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr)); ~~~~~~~~~~ ^ include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro '__le32_to_cpu' #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) ^ include/uapi/linux/swab.h:115:54: note: expanded from macro '__swab32' #define __swab32(x) (__u32)__builtin_bswap32((__u32)(x)) ^ In file included from drivers/gpu/drm/drm_lock.c:41: In file included from include/drm/drm_file.h:39: In file included from include/drm/drm_prime.h:37: In file included from include/linux/scatterlist.h:9: In file included from arch/s390/include/asm/io.h:80: include/asm-generic/io.h:501:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writeb(value, PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:511:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:521:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr); ~~~~~~~~~~ ^ include/asm-generic/io.h:609:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] readsb(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:617:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] readsw(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:625:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] readsl(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:634:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] writesb(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:643:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] writesw(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ include/asm-generic/io.h:652:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic] writesl(PCI_IOBASE + addr, buffer, count); ~~~~~~~~~~ ^ prev = cmpxchg(lock, old, new); ^~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/atomic-instrumented.h:1685:2: note: expanded from macro 'cmpxchg' arch_cmpxchg(__ai_ptr, __VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/cmpxchg.h:162:13: note: expanded from macro 'arch_cmpxchg' __cmpxchg((ptr), (unsigned long)(o), \ ^~~~~ arch/s390/include/asm/cmpxchg.h:87:45: note: passing argument to parameter 'ptr' here static inline unsigned long __cmpxchg(void *ptr, unsigned long old, ^ drivers/gpu/drm/drm_lock.c:118:10: error: passing 'typeof (lock)' (aka 'volatile unsigned int *') to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] prev = cmpxchg(lock, old, new); ^~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/atomic-instrumented.h:1685:2: note: expanded from macro 'cmpxchg' arch_cmpxchg(__ai_ptr, __VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/cmpxchg.h:162:13: note: expanded from macro 'arch_cmpxchg' __cmpxchg((ptr), (unsigned long)(o), \ ^~~~~ arch/s390/include/asm/cmpxchg.h:87:45: note: passing argument to parameter 'ptr' here static inline unsigned long __cmpxchg(void *ptr, unsigned long old, ^ drivers/gpu/drm/drm_lock.c:141:10: error: passing 'typeof (lock)' (aka 'volatile unsigned int *') to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] prev = cmpxchg(lock, old, new); ^~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/atomic-instrumented.h:1685:2: note: expanded from macro 'cmpxchg' arch_cmpxchg(__ai_ptr, __VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/cmpxchg.h:162:13: note: expanded from macro 'arch_cmpxchg' __cmpxchg((ptr), (unsigned long)(o), \ ^~~~~ arch/s390/include/asm/cmpxchg.h:87:45: note: passing argument to parameter 'ptr' here static inline unsigned long __cmpxchg(void *ptr, unsigned long old, ^ drivers/gpu/drm/drm_lock.c:319:12: error: passing 'typeof (lock)' (aka 'volatile unsigned int *') to parameter of type 'void *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] prev = cmpxchg(lock, old, DRM_KERNEL_CONTEXT); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/asm-generic/atomic-instrumented.h:1685:2: note: expanded from macro 'cmpxchg' arch_cmpxchg(__ai_ptr, __VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ arch/s390/include/asm/cmpxchg.h:162:13: note: expanded from macro 'arch_cmpxchg' __cmpxchg((ptr), (unsigned long)(o), \ ^~~~~ arch/s390/include/asm/cmpxchg.h:87:45: note: passing argument to parameter 'ptr' here static inline unsigned long __cmpxchg(void *ptr, unsigned long old, ^ 12 warnings and 4 errors generated. vim +75 drivers/gpu/drm/drm_lock.c 4ac5ec40ec7002 Daniel Vetter 2010-08-23 48 bd50d4a2168370 Benjamin Gaignard 2020-03-06 49 /* 1a75a222f5ca10 Daniel Vetter 2016-06-14 50 * Take the heavyweight lock. 1a75a222f5ca10 Daniel Vetter 2016-06-14 51 * 1a75a222f5ca10 Daniel Vetter 2016-06-14 52 * \param lock lock pointer. 1a75a222f5ca10 Daniel Vetter 2016-06-14 53 * \param context locking context. 1a75a222f5ca10 Daniel Vetter 2016-06-14 54 * \return one if the lock is held, or zero otherwise. 1a75a222f5ca10 Daniel Vetter 2016-06-14 55 * 1a75a222f5ca10 Daniel Vetter 2016-06-14 56 * Attempt to mark the lock as held by the given context, via the \p cmpxchg instruction. 1a75a222f5ca10 Daniel Vetter 2016-06-14 57 */ 1a75a222f5ca10 Daniel Vetter 2016-06-14 58 static 1a75a222f5ca10 Daniel Vetter 2016-06-14 59 int drm_lock_take(struct drm_lock_data *lock_data, 1a75a222f5ca10 Daniel Vetter 2016-06-14 60 unsigned int context) 1a75a222f5ca10 Daniel Vetter 2016-06-14 61 { 1a75a222f5ca10 Daniel Vetter 2016-06-14 62 unsigned int old, new, prev; 1a75a222f5ca10 Daniel Vetter 2016-06-14 63 volatile unsigned int *lock = &lock_data->hw_lock->lock; 1a75a222f5ca10 Daniel Vetter 2016-06-14 64 1a75a222f5ca10 Daniel Vetter 2016-06-14 65 spin_lock_bh(&lock_data->spinlock); 1a75a222f5ca10 Daniel Vetter 2016-06-14 66 do { 1a75a222f5ca10 Daniel Vetter 2016-06-14 67 old = *lock; 1a75a222f5ca10 Daniel Vetter 2016-06-14 68 if (old & _DRM_LOCK_HELD) 1a75a222f5ca10 Daniel Vetter 2016-06-14 69 new = old | _DRM_LOCK_CONT; 1a75a222f5ca10 Daniel Vetter 2016-06-14 70 else { 1a75a222f5ca10 Daniel Vetter 2016-06-14 71 new = context | _DRM_LOCK_HELD | 1a75a222f5ca10 Daniel Vetter 2016-06-14 72 ((lock_data->user_waiters + lock_data->kernel_waiters > 1) ? 1a75a222f5ca10 Daniel Vetter 2016-06-14 73 _DRM_LOCK_CONT : 0); 1a75a222f5ca10 Daniel Vetter 2016-06-14 74 } 1a75a222f5ca10 Daniel Vetter 2016-06-14 @75 prev = cmpxchg(lock, old, new); 1a75a222f5ca10 Daniel Vetter 2016-06-14 76 } while (prev != old); 1a75a222f5ca10 Daniel Vetter 2016-06-14 77 spin_unlock_bh(&lock_data->spinlock); 1a75a222f5ca10 Daniel Vetter 2016-06-14 78 1a75a222f5ca10 Daniel Vetter 2016-06-14 79 if (_DRM_LOCKING_CONTEXT(old) == context) { 1a75a222f5ca10 Daniel Vetter 2016-06-14 80 if (old & _DRM_LOCK_HELD) { 1a75a222f5ca10 Daniel Vetter 2016-06-14 81 if (context != DRM_KERNEL_CONTEXT) { 1a75a222f5ca10 Daniel Vetter 2016-06-14 82 DRM_ERROR("%d holds heavyweight lock\n", 1a75a222f5ca10 Daniel Vetter 2016-06-14 83 context); 1a75a222f5ca10 Daniel Vetter 2016-06-14 84 } 1a75a222f5ca10 Daniel Vetter 2016-06-14 85 return 0; 1a75a222f5ca10 Daniel Vetter 2016-06-14 86 } 1a75a222f5ca10 Daniel Vetter 2016-06-14 87 } 1a75a222f5ca10 Daniel Vetter 2016-06-14 88 1a75a222f5ca10 Daniel Vetter 2016-06-14 89 if ((_DRM_LOCKING_CONTEXT(new)) == context && (new & _DRM_LOCK_HELD)) { 1a75a222f5ca10 Daniel Vetter 2016-06-14 90 /* Have lock */ 1a75a222f5ca10 Daniel Vetter 2016-06-14 91 return 1; 1a75a222f5ca10 Daniel Vetter 2016-06-14 92 } 1a75a222f5ca10 Daniel Vetter 2016-06-14 93 return 0; 1a75a222f5ca10 Daniel Vetter 2016-06-14 94 } 1a75a222f5ca10 Daniel Vetter 2016-06-14 95 :::::: The code at line 75 was first introduced by commit :::::: 1a75a222f5ca1063249b5c92972d32dcc3c8966e drm: Hide hw.lock cleanup in filp->release better :::::: TO: Daniel Vetter <daniel.vetter(a)ffwll.ch&gt; :::::: CC: Daniel Vetter <daniel.vetter(a)ffwll.ch&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org