11:45 p.m.
Hi Hammer,
I love your patch! Yet something to improve:
[auto build test ERROR on linux/master]
[cannot apply to tty/tty-testing robh/for-next linus/master v5.17-rc4 next-20220215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Hammer-Hsieh/Add-UART-driver-for...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
2c271fe77d52a0555161926c232cd5bc07178b39
config: sh-allmodconfig
(https://download.01.org/0day-ci/archive/20220215/202202152052.4RCALWQy-lk...)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/acb196db041b9bf489d6378ffb6375107...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Hammer-Hsieh/Add-UART-driver-for-Suplus-SP7021-SoC/20220215-172535
git checkout acb196db041b9bf489d6378ffb63751070deea90
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=sh SHELL=/bin/bash drivers/tty/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers/tty/serial/sunplus-uart.c:25:
> include/linux/module.h:131:49: error: redefinition of
'__inittest'
131 | static inline initcall_t __maybe_unused
__inittest(void) \
| ^~~~~~~~~~
drivers/tty/serial/sunplus-uart.c:731:1: note: in expansion of macro
'module_init'
731 | module_init(sunplus_uart_init);
| ^~~~~~~~~~~
include/linux/module.h:131:49: note: previous definition of '__inittest' with
type 'int (*(void))(void)'
131 | static inline initcall_t __maybe_unused __inittest(void)
\
| ^~~~~~~~~~
include/linux/module.h:127:41: note: in expansion of macro 'module_init'
127 | #define console_initcall(fn) module_init(fn)
| ^~~~~~~~~~~
drivers/tty/serial/sunplus-uart.c:566:1: note: in expansion of macro
'console_initcall'
566 | console_initcall(sunplus_console_init);
| ^~~~~~~~~~~~~~~~
> include/linux/module.h:133:13: error: redefinition of
'init_module'
133 | int init_module(void) __copy(initfn)
\
| ^~~~~~~~~~~
drivers/tty/serial/sunplus-uart.c:731:1: note: in expansion of macro
'module_init'
731 | module_init(sunplus_uart_init);
| ^~~~~~~~~~~
include/linux/module.h:133:13: note: previous definition of 'init_module' with
type 'int(void)'
133 | int init_module(void) __copy(initfn) \
| ^~~~~~~~~~~
include/linux/module.h:127:41: note: in expansion of macro 'module_init'
127 | #define console_initcall(fn) module_init(fn)
| ^~~~~~~~~~~
drivers/tty/serial/sunplus-uart.c:566:1: note: in expansion of macro
'console_initcall'
566 | console_initcall(sunplus_console_init);
| ^~~~~~~~~~~~~~~~
vim +/__inittest +131 include/linux/module.h
0fd972a7d91d6e Paul Gortmaker 2015-05-01 128
0fd972a7d91d6e Paul Gortmaker 2015-05-01 129 /* Each module must use one module_init().
*/
0fd972a7d91d6e Paul Gortmaker 2015-05-01 130 #define module_init(initfn) \
1f318a8bafcfba Arnd Bergmann 2017-02-01 @131 static inline initcall_t __maybe_unused
__inittest(void) \
0fd972a7d91d6e Paul Gortmaker 2015-05-01 132 { return initfn; } \
cf68fffb66d60d Sami Tolvanen 2021-04-08 @133 int init_module(void) __copy(initfn) \
cf68fffb66d60d Sami Tolvanen 2021-04-08 134 __attribute__((alias(#initfn))); \
cf68fffb66d60d Sami Tolvanen 2021-04-08 135 __CFI_ADDRESSABLE(init_module,
__initdata);
0fd972a7d91d6e Paul Gortmaker 2015-05-01 136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org