11:29 a.m.
Hi Minas,
I love your patch! Perhaps something to improve:
[auto build test WARNING on balbi-usb/testing/next]
[also build test WARNING on usb/usb-testing v5.7-rc6 next-20200519]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Minas-Harutyunyan/usb-dwc2-Updat...
base: https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project
e6658079aca6d971b4e9d7137a3a2ecbc9c34aec)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
> drivers/usb/dwc2/platform.c:371:5: warning: no previous prototype
for function 'dwc2_check_core_version' [-Wmissing-prototypes]
int
dwc2_check_core_version(struct dwc2_hsotg *hsotg)
^
drivers/usb/dwc2/platform.c:371:1: note: declare 'static' if the function is not
intended to be used outside of this translation unit
int dwc2_check_core_version(struct dwc2_hsotg *hsotg)
^
static
1 warning generated.
vim +/dwc2_check_core_version +371 drivers/usb/dwc2/platform.c
364
365 /**
366 * Check core version
367 *
368 * @hsotg: Programming view of the DWC_otg controller
369 *
370 */
371 int dwc2_check_core_version(struct dwc2_hsotg *hsotg)
372 {
373 struct dwc2_hw_params *hw = &hsotg->hw_params;
374
375 /*
376 * Attempt to ensure this device is really a DWC_otg Controller.
377 * Read and verify the GSNPSID register contents. The value should be
378 * 0x45f4xxxx, 0x5531xxxx or 0x5532xxxx
379 */
380
381 hw->snpsid = dwc2_readl(hsotg, GSNPSID);
382 if ((hw->snpsid & GSNPSID_ID_MASK) != DWC2_OTG_ID &&
383 (hw->snpsid & GSNPSID_ID_MASK) != DWC2_FS_IOT_ID &&
384 (hw->snpsid & GSNPSID_ID_MASK) != DWC2_HS_IOT_ID) {
385 dev_err(hsotg->dev, "Bad value for GSNPSID: 0x%08x\n",
386 hw->snpsid);
387 return -ENODEV;
388 }
389
390 dev_dbg(hsotg->dev, "Core Release: %1x.%1x%1x%1x (snpsid=%x)\n",
391 hw->snpsid >> 12 & 0xf, hw->snpsid >> 8 & 0xf,
392 hw->snpsid >> 4 & 0xf, hw->snpsid & 0xf, hw->snpsid);
393 return 0;
394 }
395
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org