[kbuild-all] [chrome-os:chromeos-4.4 57/214] include/media/v4l2-rect.h:185:15: warning: comparison between signed and unsigned integer expressions

tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4 head: 165087594d83615eb48f64ee09830ccccd7f4ae4 commit: 5a4eba75642861e857fec1aeb6cfcb055cfe2650 [57/214] UPSTREAM: media: staging: rkisp1: add Rockchip ISP1 base driver config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.5.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel git fetch --no-tags chrome-os chromeos-4.4 git checkout 5a4eba75642861e857fec1aeb6cfcb055cfe2650 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from drivers/staging/media/rkisp1/rkisp1-common.c:8:0: include/media/v4l2-rect.h: In function 'v4l2_rect_overlap': if (r1->left >= r2->left + r2->width || ^~ include/media/v4l2-rect.h:186:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] r2->left >= r1->left + r1->width) ^~ include/media/v4l2-rect.h:193:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (r1->top >= r2->top + r2->height || ^~ include/media/v4l2-rect.h:194:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] r2->top >= r1->top + r1->height) ^~ In file included from drivers/staging/media/rkisp1/rkisp1-common.h:14:0, from drivers/staging/media/rkisp1/rkisp1-common.c:10: include/linux/clk.h: At top level: include/linux/clk.h:199:70: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration static inline int __must_check clk_bulk_prepare(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h:223:60: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration static inline void clk_bulk_unprepare(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h:528:17: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h:539:15: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h:546:54: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration static inline void clk_bulk_put(int num_clks, struct clk_bulk_data *clks) {} ^~~~~~~~~~~~~ include/linux/clk.h:555:69: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration static inline int __must_check clk_bulk_enable(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h:564:16: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration struct clk_bulk_data *clks) {} ^~~~~~~~~~~~~ include/linux/clk.h:624:13: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h: In function 'clk_bulk_prepare_enable': include/linux/clk.h:628:35: warning: passing argument 2 of 'clk_bulk_prepare' from incompatible pointer type [-Wincompatible-pointer-types] ret = clk_bulk_prepare(num_clks, clks); ^~~~ include/linux/clk.h:199:32: note: expected 'struct clk_bulk_data *' but argument is of type 'struct clk_bulk_data *' static inline int __must_check clk_bulk_prepare(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~~~~ include/linux/clk.h:631:34: warning: passing argument 2 of 'clk_bulk_enable' from incompatible pointer type [-Wincompatible-pointer-types] ret = clk_bulk_enable(num_clks, clks); ^~~~ include/linux/clk.h:555:32: note: expected 'struct clk_bulk_data *' but argument is of type 'struct clk_bulk_data *' static inline int __must_check clk_bulk_enable(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~~~ include/linux/clk.h:633:32: warning: passing argument 2 of 'clk_bulk_unprepare' from incompatible pointer type [-Wincompatible-pointer-types] clk_bulk_unprepare(num_clks, clks); ^~~~ include/linux/clk.h:223:20: note: expected 'struct clk_bulk_data *' but argument is of type 'struct clk_bulk_data *' static inline void clk_bulk_unprepare(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~~~~~~ include/linux/clk.h: At top level: include/linux/clk.h:639:19: warning: 'struct clk_bulk_data' declared inside parameter list will not be visible outside of this definition or declaration struct clk_bulk_data *clks) ^~~~~~~~~~~~~ include/linux/clk.h: In function 'clk_bulk_disable_unprepare': include/linux/clk.h:641:29: warning: passing argument 2 of 'clk_bulk_disable' from incompatible pointer type [-Wincompatible-pointer-types] clk_bulk_disable(num_clks, clks); ^~~~ include/linux/clk.h:563:20: note: expected 'struct clk_bulk_data *' but argument is of type 'struct clk_bulk_data *' static inline void clk_bulk_disable(int num_clks, ^~~~~~~~~~~~~~~~ include/linux/clk.h:642:31: warning: passing argument 2 of 'clk_bulk_unprepare' from incompatible pointer type [-Wincompatible-pointer-types] clk_bulk_unprepare(num_clks, clks); ^~~~ include/linux/clk.h:223:20: note: expected 'struct clk_bulk_data *' but argument is of type 'struct clk_bulk_data *' static inline void clk_bulk_unprepare(int num_clks, struct clk_bulk_data *clks) ^~~~~~~~~~~~~~~~~~ In file included from drivers/staging/media/rkisp1/rkisp1-common.c:10:0: drivers/staging/media/rkisp1/rkisp1-common.h: At top level: drivers/staging/media/rkisp1/rkisp1-common.h:145:23: error: array type has incomplete element type 'struct clk_bulk_data' struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK]; ^~~~ vim +185 include/media/v4l2-rect.h 32073753dbce4a Hans Verkuil 2016-04-03 169 32073753dbce4a Hans Verkuil 2016-04-03 170 /** 32073753dbce4a Hans Verkuil 2016-04-03 171 * v4l2_rect_overlap() - do r1 and r2 overlap? 32073753dbce4a Hans Verkuil 2016-04-03 172 * @r1: rectangle. 32073753dbce4a Hans Verkuil 2016-04-03 173 * @r2: rectangle. 32073753dbce4a Hans Verkuil 2016-04-03 174 * 32073753dbce4a Hans Verkuil 2016-04-03 175 * Returns true if @r1 and @r2 overlap. 32073753dbce4a Hans Verkuil 2016-04-03 176 */ 32073753dbce4a Hans Verkuil 2016-04-03 177 static inline bool v4l2_rect_overlap(const struct v4l2_rect *r1, 32073753dbce4a Hans Verkuil 2016-04-03 178 const struct v4l2_rect *r2) 32073753dbce4a Hans Verkuil 2016-04-03 179 { 32073753dbce4a Hans Verkuil 2016-04-03 180 /* 32073753dbce4a Hans Verkuil 2016-04-03 181 * IF the left side of r1 is to the right of the right side of r2 OR 32073753dbce4a Hans Verkuil 2016-04-03 182 * the left side of r2 is to the right of the right side of r1 THEN 32073753dbce4a Hans Verkuil 2016-04-03 183 * they do not overlap. 32073753dbce4a Hans Verkuil 2016-04-03 184 */ 32073753dbce4a Hans Verkuil 2016-04-03 @185 if (r1->left >= r2->left + r2->width || 32073753dbce4a Hans Verkuil 2016-04-03 186 r2->left >= r1->left + r1->width) 32073753dbce4a Hans Verkuil 2016-04-03 187 return false; 32073753dbce4a Hans Verkuil 2016-04-03 188 /* 32073753dbce4a Hans Verkuil 2016-04-03 189 * IF the top side of r1 is below the bottom of r2 OR 32073753dbce4a Hans Verkuil 2016-04-03 190 * the top side of r2 is below the bottom of r1 THEN 32073753dbce4a Hans Verkuil 2016-04-03 191 * they do not overlap. 32073753dbce4a Hans Verkuil 2016-04-03 192 */ 32073753dbce4a Hans Verkuil 2016-04-03 193 if (r1->top >= r2->top + r2->height || 32073753dbce4a Hans Verkuil 2016-04-03 194 r2->top >= r1->top + r1->height) 32073753dbce4a Hans Verkuil 2016-04-03 195 return false; 32073753dbce4a Hans Verkuil 2016-04-03 196 return true; 32073753dbce4a Hans Verkuil 2016-04-03 197 } 32073753dbce4a Hans Verkuil 2016-04-03 198 :::::: The code at line 185 was first introduced by commit :::::: 32073753dbce4a97ad6d3e2f8392aa35bfc46d09 UPSTREAM: [media] v4l2-rect.h: new header with struct v4l2_rect helper functions :::::: TO: Hans Verkuil <hans.verkuil(a)cisco.com&gt; :::::: CC: Commit Bot <commit-bot(a)chromium.org&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org