9:34 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
pending-5.10
head: 28d8a1bafb1d3ba5b9e84a0ef9f7505340737187
commit: 3ae415bcd38a078e241976dd34a19f49f1bab390 [486/511] block/ataflop: use the
blk_cleanup_disk() helper
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/c...
git remote add sashal-stable
https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
git fetch --no-tags sashal-stable pending-5.10
git checkout 3ae415bcd38a078e241976dd34a19f49f1bab390
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:11,
from include/linux/list.h:9,
from include/linux/module.h:12,
from drivers/block/ataflop.c:65:
include/linux/scatterlist.h: In function 'sg_set_buf':
arch/m68k/include/asm/page_mm.h:169:50: warning: ordered comparison of pointer with
null pointer [-Wextra]
169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET
&& (void *)(kaddr) < high_memory)
| ^~
include/linux/compiler.h:78:45: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
include/linux/scatterlist.h:143:9: note: in expansion of macro 'BUG_ON'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~
include/linux/scatterlist.h:143:17: note: in expansion of macro
'virt_addr_valid'
143 | BUG_ON(!virt_addr_valid(buf));
| ^~~~~~~~~~~~~~~
drivers/block/ataflop.c: In function 'atari_floppy_init':
drivers/block/ataflop.c:2045:15: error: implicit declaration of function
'__register_blkdev'; did you mean 'unregister_blkdev'?
[-Werror=implicit-function-declaration]
2045 | ret = __register_blkdev(FLOPPY_MAJOR, "fd", ataflop_probe);
| ^~~~~~~~~~~~~~~~~
| unregister_blkdev
> drivers/block/ataflop.c:2105:17: error: implicit declaration of
function 'blk_cleanup_disk'; did you mean 'blk_cleanup_queue'?
[-Werror=implicit-function-declaration]
2105 |
blk_cleanup_disk(unit[i].disk[0]);
| ^~~~~~~~~~~~~~~~
| blk_cleanup_queue
cc1: some warnings being treated as errors
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for NEED_MULTIPLE_NODES
Depends on DISCONTIGMEM || NUMA
Selected by
- SINGLE_MEMORY_CHUNK && MMU
vim +2105 drivers/block/ataflop.c
2034
2035 static int __init atari_floppy_init (void)
2036 {
2037 int i;
2038 int ret;
2039
2040 if (!MACH_IS_ATARI)
2041 /* Amiga, Mac, ... don't have Atari-compatible floppy :-) */
2042 return -ENODEV;
2043
2044 mutex_lock(&ataflop_probe_lock);
2045 ret = __register_blkdev(FLOPPY_MAJOR, "fd", ataflop_probe);
2046 if (ret)
2047 goto out_unlock;
2048
2049 for (i = 0; i < FD_MAX_UNITS; i++) {
2050 memset(&unit[i].tag_set, 0, sizeof(unit[i].tag_set));
2051 unit[i].tag_set.ops = &ataflop_mq_ops;
2052 unit[i].tag_set.nr_hw_queues = 1;
2053 unit[i].tag_set.nr_maps = 1;
2054 unit[i].tag_set.queue_depth = 2;
2055 unit[i].tag_set.numa_node = NUMA_NO_NODE;
2056 unit[i].tag_set.flags = BLK_MQ_F_SHOULD_MERGE;
2057 ret = blk_mq_alloc_tag_set(&unit[i].tag_set);
2058 if (ret)
2059 goto err;
2060
2061 ret = ataflop_alloc_disk(i, 0);
2062 if (ret) {
2063 blk_mq_free_tag_set(&unit[i].tag_set);
2064 goto err;
2065 }
2066 }
2067
2068 if (UseTrackbuffer < 0)
2069 /* not set by user -> use default: for now, we turn
2070 track buffering off for all Medusas, though it
2071 could be used with ones that have a counter
2072 card. But the test is too hard :-( */
2073 UseTrackbuffer = !MACH_IS_MEDUSA;
2074
2075 /* initialize variables */
2076 SelectedDrive = -1;
2077 BufferDrive = -1;
2078
2079 DMABuffer = atari_stram_alloc(BUFFER_SIZE+512, "ataflop");
2080 if (!DMABuffer) {
2081 printk(KERN_ERR "atari_floppy_init: cannot get dma buffer\n");
2082 ret = -ENOMEM;
2083 goto err;
2084 }
2085 TrackBuffer = DMABuffer + 512;
2086 PhysDMABuffer = atari_stram_to_phys(DMABuffer);
2087 PhysTrackBuffer = virt_to_phys(TrackBuffer);
2088 BufferDrive = BufferSide = BufferTrack = -1;
2089
2090 for (i = 0; i < FD_MAX_UNITS; i++) {
2091 unit[i].track = -1;
2092 unit[i].flags = 0;
2093 add_disk(unit[i].disk[0]);
2094 }
2095
2096 printk(KERN_INFO "Atari floppy driver: max. %cD, %strack buffering\n",
2097 DriveType == 0 ? 'D' : DriveType == 1 ? 'H' : 'E',
2098 UseTrackbuffer ? "" : "no ");
2099 config_types();
2100
2101 return 0;
2102
2103 err:
2104 while (--i >= 0) {
2105 blk_cleanup_disk(unit[i].disk[0]);
2106 blk_mq_free_tag_set(&unit[i].tag_set);
2107 }
2108
2109 unregister_blkdev(FLOPPY_MAJOR, "fd");
2110 out_unlock:
2111 mutex_unlock(&ataflop_probe_lock);
2112 return ret;
2113 }
2114
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org