[kbuild-all] Re: [PATCH v3 2/2] Adding i2c-cp2615: i2c support for Silicon Labs' CP2615 Digital Audio Bridge

Hi "Bence, Thank you for the patch! Yet something to improve: [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Bence-Cs-k-s/Add-i2c-cp2615/2021... base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: arc-allyesconfig (attached as .config) compiler: arceb-elf-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7aa4ceb301ef5116752aef6e09f6ff845... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Bence-Cs-k-s/Add-i2c-cp2615/20210318-193822 git checkout 7aa4ceb301ef5116752aef6e09f6ff845dedc106 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/i2c/busses/i2c-cp2615.c:78:5: warning: no previous prototype for 'cp2615_init_iop_msg' [-Wmissing-prototypes] 78 | int cp2615_init_iop_msg(struct cp2615_iop_msg *ret, enum cp2615_iop_msg_type msg, | ^~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:96:5: warning: no previous prototype for 'cp2615_init_i2c_msg' [-Wmissing-prototypes] 96 | int cp2615_init_i2c_msg(struct cp2615_iop_msg *ret, const struct cp2615_i2c_transfer *data) | ^~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:102:5: warning: no previous prototype for 'cp2615_check_status' [-Wmissing-prototypes] 102 | int cp2615_check_status(enum cp2615_i2c_status status) | ^~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:266:1: warning: data definition has no type or storage class 266 | MODULE_DEVICE_TABLE(usb, id_table); | ^~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:266:1: warning: parameter names (without types) in function declaration In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from include/linux/i2c.h:13, from drivers/i2c/busses/i2c-cp2615.c:9: include/linux/device/driver.h:263:1: warning: data definition has no type or storage class 263 | module_init(__driver##_init); \ | ^~~~~~~~~~~ include/linux/usb.h:1303:2: note: in expansion of macro 'module_driver' 1303 | module_driver(__usb_driver, usb_register, \ | ^~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ 263 | module_init(__driver##_init); \ | ^~~~~~~~~~~ include/linux/usb.h:1303:2: note: in expansion of macro 'module_driver' 1303 | module_driver(__usb_driver, usb_register, \ | ^~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/linkage.h:7, from include/linux/kernel.h:7, from include/linux/list.h:9, from include/linux/kobject.h:19, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/linux/i2c.h:13, from drivers/i2c/busses/i2c-cp2615.c:9: include/linux/export.h:19:30: warning: parameter names (without types) in function declaration 19 | #define THIS_MODULE ((struct module *)0) | ^~~~~~ include/linux/usb.h:1290:30: note: in expansion of macro 'THIS_MODULE' 1290 | usb_register_driver(driver, THIS_MODULE, KBUILD_MODNAME) | ^~~~~~~~~~~ include/linux/device/driver.h:261:9: note: in expansion of macro 'usb_register' 261 | return __register(&(__driver) , ##__VA_ARGS__); \ | ^~~~~~~~~~ include/linux/usb.h:1303:2: note: in expansion of macro 'module_driver' 1303 | module_driver(__usb_driver, usb_register, \ | ^~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from include/linux/i2c.h:13, from drivers/i2c/busses/i2c-cp2615.c:9: include/linux/device/driver.h:268:1: warning: data definition has no type or storage class 268 | module_exit(__driver##_exit); | ^~~~~~~~~~~ include/linux/usb.h:1303:2: note: in expansion of macro 'module_driver' 1303 | module_driver(__usb_driver, usb_register, \ | ^~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ 268 | module_exit(__driver##_exit); | ^~~~~~~~~~~ include/linux/usb.h:1303:2: note: in expansion of macro 'module_driver' 1303 | module_driver(__usb_driver, usb_register, \ | ^~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ In file included from include/linux/linkage.h:7, from include/linux/kernel.h:7, from include/linux/list.h:9, from include/linux/kobject.h:19, from include/linux/of.h:17, from include/linux/irqdomain.h:35, from include/linux/acpi.h:13, from include/linux/i2c.h:13, from drivers/i2c/busses/i2c-cp2615.c:9: include/linux/export.h:19:30: warning: parameter names (without types) in function declaration 19 | #define THIS_MODULE ((struct module *)0) | ^~~~~~ include/linux/usb.h:1290:30: note: in expansion of macro 'THIS_MODULE' 1290 | usb_register_driver(driver, THIS_MODULE, KBUILD_MODNAME) | ^~~~~~~~~~~ include/linux/device/driver.h:261:9: note: in expansion of macro 'usb_register' 261 | return __register(&(__driver) , ##__VA_ARGS__); \ | ^~~~~~~~~~ include/linux/usb.h:1303:2: note: in expansion of macro 'module_driver' 1303 | module_driver(__usb_driver, usb_register, \ | ^~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ 277 | MODULE_AUTHOR("Bence Csókás <bence98(a)sch.bme.hu&gt;&quot;); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:278:20: error: expected declaration specifiers or '...' before string constant 278 | MODULE_DESCRIPTION("CP2615 I2C bus driver"); | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:279:16: error: expected declaration specifiers or '...' before string constant 279 | MODULE_LICENSE("GPL"); | ^~~~~ In file included from include/linux/device.h:32, from include/linux/acpi.h:15, from include/linux/i2c.h:13, from drivers/i2c/busses/i2c-cp2615.c:9: drivers/i2c/busses/i2c-cp2615.c:275:19: warning: 'cp2615_i2c_driver_init' defined but not used [-Wunused-function] 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ include/linux/device/driver.h:259:19: note: in definition of macro 'module_driver' 259 | static int __init __driver##_init(void) \ | ^~~~~~~~ drivers/i2c/busses/i2c-cp2615.c:275:1: note: in expansion of macro 'module_usb_driver' 275 | module_usb_driver(cp2615_i2c_driver); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +266 drivers/i2c/busses/i2c-cp2615.c 265 267 268 static struct usb_driver cp2615_i2c_driver = { 269 .name = "i2c-cp2615", 270 .probe = cp2615_i2c_probe, 271 .disconnect = cp2615_i2c_remove, 272 .id_table = id_table, 273 }; 274 275 module_usb_driver(cp2615_i2c_driver); 276 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org