[kbuild-all] Re: [PATCH v1] drivers: make struct device_driver::remove return void

Hi "Uwe, I love your patch! Yet something to improve: [auto build test ERROR on 407ab579637ced6dc32cfb2295afb7259cca4b22] url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/drivers-make-st... base: 407ab579637ced6dc32cfb2295afb7259cca4b22 config: mips-randconfig-p002-20201110 (attached as .config) compiler: mipsel-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/b836c14181cf5aab71cd870732f724378... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Uwe-Kleine-K-nig/drivers-make-struct-device_driver-remove-return-void/20201110-230939 git checkout b836c14181cf5aab71cd870732f72437811ab228 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): 1551 | .remove = fza_remove, | ^~~~~~~~~~ drivers/net/fddi/defza.c:1551:13: note: (near initialization for 'fza_driver.driver.remove') cc1: some warnings being treated as errors -- 138 | .remove = tgafb_tc_unregister, | ^~~~~~~~~~~~~~~~~~~ drivers/video/fbdev/tgafb.c:138:14: note: (near initialization for 'tgafb_tc_driver.driver.remove') drivers/video/fbdev/tgafb.c: In function 'tgafb_clut_imageblit': drivers/video/fbdev/tgafb.c:840:16: warning: variable 'regs_base' set but not used [-Wunused-but-set-variable] 840 | void __iomem *regs_base, *fb_base; | ^~~~~~~~~ cc1: some warnings being treated as errors -- 281 | .remove = pmagaafb_remove, | ^~~~~~~~~~~~~~~ drivers/video/fbdev/pmag-aa-fb.c:281:13: note: (near initialization for 'pmagaafb_driver.driver.remove') cc1: some warnings being treated as errors -- 271 | .remove = pmagbafb_remove, | ^~~~~~~~~~~~~~~ drivers/video/fbdev/pmag-ba-fb.c:271:13: note: (near initialization for 'pmagbafb_driver.driver.remove') cc1: some warnings being treated as errors -- 389 | .remove = pmagbbfb_remove, | ^~~~~~~~~~~~~~~ drivers/video/fbdev/pmagb-b-fb.c:389:13: note: (near initialization for 'pmagbbfb_driver.driver.remove') cc1: some warnings being treated as errors -- 1330 | .remove = dec_lance_tc_remove, | ^~~~~~~~~~~~~~~~~~~ drivers/net/ethernet/amd/declance.c:1330:13: note: (near initialization for 'dec_lance_tc_driver.driver.remove') cc1: some warnings being treated as errors vim +1551 drivers/net/fddi/defza.c 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1544 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1545 static struct tc_driver fza_driver = { 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1546 .id_table = fza_tc_table, 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1547 .driver = { 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1548 .name = "defza", 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1549 .bus = &tc_bus_type, 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1550 .probe = fza_probe, 61414f5ec9834df Maciej W. Rozycki 2018-10-09 @1551 .remove = fza_remove, 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1552 }, 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1553 }; 61414f5ec9834df Maciej W. Rozycki 2018-10-09 1554 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org