[kbuild-all] Re: [PATCH v2 2/3] block: don't hide inode from block_device users

On 10/13/2021 11:12 PM, Pavel Begunkov wrote: Hi Pavel, Thanks for the feedback, we'll take a look. Best Regards, Rong Chen > > >> [cannot apply to axboe-block/for-next next-20211013] >> [If your patch is applied to the wrong git tree, kindly drop us a note. >> And when submitting patch, we suggest to use '--base' as documented in >> https://git-scm.com/docs/git-format-patch] >> >> url: >> https://github.com/0day-ci/linux/commits/Pavel-Begunkov/on-top-of-for-5-1... >> >> base:    64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc >> config: hexagon-randconfig-r045-20211013 (attached as .config) >> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project >> b6a8c695542b2987eb9a203d5663a0740cb4725f) >> reproduce (this is a W=1 build): >>          wget >> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross >> -O ~/bin/make.cross >>          chmod +x ~/bin/make.cross >>          # >> https://github.com/0day-ci/linux/commit/9e538de87cc869bd26a3ca78da49d1437... >> >>          git remote add linux-review https://github.com/0day-ci/linux >>          git fetch --no-tags linux-review >> Pavel-Begunkov/on-top-of-for-5-16-block/20211013-165953 >>          git checkout 9e538de87cc869bd26a3ca78da49d1437ec8688c >>          # save the attached .config to linux build tree >>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross >> W=1 ARCH=hexagon >> >> If you fix the issue, kindly add following tag as appropriate >> Reported-by: kernel test robot <lkp(a)intel.com&gt; >> >> All error/warnings (new ones prefixed by >>): >> >>>> block/fops.c:460:37: error: implicit declaration of function >>>> 'bdev_file_inode' [-Werror,-Wimplicit-function-declaration] >>             struct block_device *bdev = I_BDEV(bdev_file_inode(file)); >>                                                ^ >>     block/fops.c:460:37: note: did you mean 'file_inode'? >>     include/linux/fs.h:1348:29: note: 'file_inode' declared here >>     static inline struct inode *file_inode(const struct file *f) >>                                 ^ >>>> block/fops.c:460:37: warning: incompatible integer to pointer >>>> conversion passing 'int' to parameter of type 'struct inode *' >>>> [-Wint-conversion] >>             struct block_device *bdev = I_BDEV(bdev_file_inode(file)); >>                                                ^~~~~~~~~~~~~~~~~~~~~ >>     include/linux/blkdev.h:1990:57: note: passing argument to >> parameter 'inode' here >>     static inline struct block_device *I_BDEV(struct inode *inode) >>                                                             ^ >>     1 warning and 1 error generated. >> >> >> vim +/bdev_file_inode +460 block/fops.c >> >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  457 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  458  static long >> block_ioctl(struct file *file, unsigned cmd, unsigned long arg) >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  459  { >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07 @460      struct >> block_device *bdev = I_BDEV(bdev_file_inode(file)); >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  461      fmode_t mode = >> file->f_mode; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  462 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  463      /* >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  464       * O_NDELAY can >> be altered using fcntl(.., F_SETFL, ..), so we have >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  465       * to updated it >> before every ioctl. >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  466       */ >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  467      if >> (file->f_flags & O_NDELAY) >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  468          mode |= >> FMODE_NDELAY; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  469      else >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  470          mode &= >> ~FMODE_NDELAY; >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  471 >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  472      return >> blkdev_ioctl(bdev, mode, cmd, arg); >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  473  } >> cd82cca7ebfe9c Christoph Hellwig 2021-09-07  474 >> >> --- >> 0-DAY CI Kernel Test Service, Intel Corporation >> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >> >