7:49 a.m.
Hi Lukas,
I love your patch! Yet something to improve:
[auto build test ERROR on char-misc/char-misc-testing]
[also build test ERROR on pci/next soc/for-next v5.14-rc6 next-20210819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Lukas-Bulwahn/mei-improve-Denver...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
b2159182dd498fdb0f49e371ccc94efbc12d1f8e
config: i386-randconfig-c001-20210818 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
d2b574a4dea5b718e4386bf2e26af0126e5978ce)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/2b98fe0ded99ab7eaf389fa1c91b3d9aa...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Lukas-Bulwahn/mei-improve-Denverton-HSM-IFSI-support/20210819-230718
git checkout 2b98fe0ded99ab7eaf389fa1c91b3d9aad7c93a3
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross O=build_dir ARCH=i386
SHELL=/bin/bash drivers/misc/mei/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/misc/mei/pci-me.c:80:39: error: use of undeclared identifier
'MEI_ME_PCH8_SPS_CFG'
{MEI_PCI_DEVICE(MEI_DEV_ID_DNV_IE_2, MEI_ME_PCH8_SPS_CFG)},
^
> drivers/misc/mei/pci-me.c:121:1: error: definition of variable
with array type needs an explicit size or an initializer
MODULE_DEVICE_TABLE(pci,
mei_me_pci_tbl);
^
include/linux/module.h:244:21: note: expanded from macro 'MODULE_DEVICE_TABLE'
extern typeof(name) __mod_##type##__##name##_device_table \
^
<scratch space>:74:1: note: expanded from here
__mod_pci__mei_me_pci_tbl_device_table
^
drivers/misc/mei/pci-me.c:195:31: warning: shift count >= width of type
[-Wshift-count-overflow]
if (dma_set_mask(&pdev->dev, DMA_BIT_MASK(64)) ||
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
drivers/misc/mei/pci-me.c:196:40: warning: shift count >= width of type
[-Wshift-count-overflow]
dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64))) {
^~~~~~~~~~~~~~~~
include/linux/dma-mapping.h:76:54: note: expanded from macro 'DMA_BIT_MASK'
#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1))
^ ~~~
2 warnings and 2 errors generated.
vim +121 drivers/misc/mei/pci-me.c
2703d4b2e673cc Tomas Winkler 2013-02-06 120
b68301e9acd30f Tomas Winkler 2013-03-27 @121 MODULE_DEVICE_TABLE(pci, mei_me_pci_tbl);
2703d4b2e673cc Tomas Winkler 2013-02-06 122
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org