10:44 a.m.
Hi Sathish,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on next-20200312]
[cannot apply to bluetooth/master v5.6-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Sathish-Narsimman/LE-LL-Priavcy-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git
master
config: i386-randconfig-d001-20200312 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-5) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/export.h:43:0,
from include/linux/linkage.h:7,
from include/linux/kernel.h:8,
from include/linux/list.h:9,
from include/linux/rculist.h:10,
from include/linux/sched/signal.h:5,
from net/bluetooth/hci_request.c:24:
net/bluetooth/hci_request.c: In function 'add_to_white_list':
net/bluetooth/hci_request.c:721:64: error: 'b' undeclared (first use in this
function); did you mean 'mb'?
if (!hci_bdaddr_list_lookup_with_irk(&hdev->le_resolv_list,
&b->bdaddr,
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
^~~~
> net/bluetooth/hci_request.c:721:3: note: in expansion of macro
'if'
if
(!hci_bdaddr_list_lookup_with_irk(&hdev->le_resolv_list, &b->bdaddr,
^~
net/bluetooth/hci_request.c:721:64: note: each undeclared identifier is reported only
once for each function it appears in
if (!hci_bdaddr_list_lookup_with_irk(&hdev->le_resolv_list,
&b->bdaddr,
^
include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var'
#define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) :
__trace_if_value(cond))
^~~~
> net/bluetooth/hci_request.c:721:3: note: in expansion of macro
'if'
if
(!hci_bdaddr_list_lookup_with_irk(&hdev->le_resolv_list, &b->bdaddr,
^~
vim +/if +721 net/bluetooth/hci_request.c
693
694 /* Adds connection to white list if needed. On error, returns -1. */
695 static int add_to_white_list(struct hci_request *req,
696 struct hci_conn_params *params, u8 *num_entries,
697 bool allow_rpa)
698 {
699 struct hci_cp_le_add_to_white_list cp;
700 struct hci_dev *hdev = req->hdev;
701
702 /* Already in white list */
703 if (hci_bdaddr_list_lookup(&hdev->le_white_list, ¶ms->addr,
704 params->addr_type))
705 return 0;
706
707 /* Select filter policy to accept all advertising */
708 if (*num_entries >= hdev->le_white_list_size)
709 return -1;
710
711 /* White list can not be used with RPAs */
712 if (!allow_rpa &&
713 hci_find_irk_by_addr(hdev, ¶ms->addr, params->addr_type)) {
714 /* White list can not be used with RPAs if address
715 * resolution is disabled in the controller
716 */
717 if (!hci_dev_test_flag(hdev, HCI_LL_RPA_RESOLUTION))
718 return -1;
719
720 /* if the peer device is not present in the resolving list */
721 if
(!hci_bdaddr_list_lookup_with_irk(&hdev->le_resolv_list, &b->bdaddr,
722 b->bdaddr_type))
723 return -1;
724 }
725
726 /* During suspend, only wakeable devices can be in whitelist */
727 if (hdev->suspended && !params->wakeable)
728 return 0;
729
730 *num_entries += 1;
731 cp.bdaddr_type = params->addr_type;
732 bacpy(&cp.bdaddr, ¶ms->addr);
733
734 bt_dev_dbg(hdev, "Add %pMR (0x%x) to whitelist", &cp.bdaddr,
735 cp.bdaddr_type);
736 hci_req_add(req, HCI_OP_LE_ADD_TO_WHITE_LIST, sizeof(cp), &cp);
737
738 return 0;
739 }
740
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org