9:20 p.m.
Hi Colin,
url:
https://github.com/0day-ci/linux/commits/Colin-Foster/add-support-for-VSC...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
3ad4b7c81a992463c29ae130332c217607fe4452
config: arm-randconfig-m031-20211116 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/net/mdio/mdio-mscc-miim.c:235 mscc_miim_probe() error: potentially dereferencing
uninitialized 'dev'.
drivers/net/mdio/mdio-mscc-miim.c:244 mscc_miim_probe() warn: passing zero to
'PTR_ERR'
vim +/dev +235 drivers/net/mdio/mdio-mscc-miim.c
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 212 static
int mscc_miim_probe(struct platform_device *pdev)
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 213 {
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 214
struct regmap *mii_regmap, *phy_regmap;
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 215 void
__iomem *regs, *phy_regs;
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 216
struct mscc_miim_dev *dev;
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 217
struct mii_bus *bus;
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 218 int
ret;
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 219
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 220 regs
= devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 221 if
(IS_ERR(regs)) {
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 222
dev_err(&pdev->dev, "Unable to map MIIM registers\n");
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 223
return PTR_ERR(regs);
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 224 }
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 225
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 226
mii_regmap = devm_regmap_init_mmio(&pdev->dev, regs,
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 227
&mscc_miim_regmap_config);
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 228
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 229 if
(IS_ERR(mii_regmap)) {
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 230
dev_err(&pdev->dev, "Unable to create MIIM regmap\n");
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 231
return PTR_ERR(mii_regmap);
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 232 }
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 233
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 234
phy_regs = devm_platform_ioremap_resource(pdev, 1);
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 @235 if
(IS_ERR(dev->phy_regs)) {
^^^
"dev" is never initialized.
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 236
dev_err(&pdev->dev, "Unable to map internal phy registers\n");
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 237
return PTR_ERR(dev->phy_regs);
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 238 }
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 239
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 240
phy_regmap = devm_regmap_init_mmio(&pdev->dev, phy_regs,
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 241
&mscc_miim_regmap_config);
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 242 if
(IS_ERR(phy_regmap)) {
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 243
dev_err(&pdev->dev, "Unable to create phy register regmap\n");
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 @244
return PTR_ERR(dev->phy_regs);
^^^^^^^^^^^^^
Cut and paste error. "phy_regmap" intended.
c6995117b60ef3 drivers/net/mdio/mdio-mscc-miim.c Horatiu Vultur 2021-09-28 245 }
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 246
3844fce844e141 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 247
mscc_miim_setup(&pdev->dev, &bus, mii_regmap, 0, phy_regmap, 0);
5f5682772ede09 drivers/net/mdio/mdio-mscc-miim.c Colin Foster 2021-11-15 248
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 249 ret =
of_mdiobus_register(bus, pdev->dev.of_node);
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 250 if
(ret < 0) {
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 251
dev_err(&pdev->dev, "Cannot register MDIO bus (%d)\n", ret);
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 252
return ret;
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 253 }
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 254
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 255
platform_set_drvdata(pdev, bus);
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 256
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 257
return 0;
542671fe4d86ad drivers/net/phy/mdio-mscc-miim.c Alexandre Belloni 2018-05-14 258 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org