[kbuild-all] Re: [PATCH v5 1/9] MIPS: Avoid future duplicate elf core header reservation

Hi Geert, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on arm64/for-next/core arm/for-next linus/master v5.14-rc5 next-20210811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/Add-generic-s... base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: mips-randconfig-r022-20210809 (attached as .config) compiler: mips64-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/e3a0dd2c8001096543634dfedc74e52f8... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Geert-Uytterhoeven/Add-generic-support-for-kdump-DT-properties/20210811-165455 git checkout e3a0dd2c8001096543634dfedc74e52f819bd528 # save the attached .config to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): arch/mips/kernel/setup.c: In function 'mips_reserve_vmcore': 432 | if (!memblock_is_region_reserved(elfcorehdr_addr, elfcorehdr_size) | ~ ^ | ) 433 | memblock_reserve(elfcorehdr_addr, elfcorehdr_size); | ~~~~~~~~~~~~~~~~ 435 | } | ^ vim +432 arch/mips/kernel/setup.c 408 409 static void __init mips_reserve_vmcore(void) 410 { 411 #ifdef CONFIG_PROC_VMCORE 412 phys_addr_t start, end; 413 u64 i; 414 415 if (!elfcorehdr_size) { 416 for_each_mem_range(i, &start, &end) { 417 if (elfcorehdr_addr >= start && elfcorehdr_addr < end) { 418 /* 419 * Reserve from the elf core header to the end of 420 * the memory segment, that should all be kdump 421 * reserved memory. 422 */ 423 elfcorehdr_size = end - elfcorehdr_addr; 424 break; 425 } 426 } 427 } 428 429 pr_info("Reserving %ldKB of memory at %ldKB for kdump\n", 430 (unsigned long)elfcorehdr_size >> 10, (unsigned long)elfcorehdr_addr >> 10); 431 433 memblock_reserve(elfcorehdr_addr, elfcorehdr_size); 434 #endif 436 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org