[kbuild-all] Re: [PATCH] RFC: media: v4l2-subdev: add subdev-wide config struct

Hi Tomi, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v5.12-rc6 next-20210409] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Tomi-Valkeinen/RFC-media-v4l2-su... base: git://linuxtv.org/media_tree.git master config: m68k-allmodconfig (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/4690ebdd6fd3180366038788f7df1fa24... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Tomi-Valkeinen/RFC-media-v4l2-subdev-add-subdev-wide-config-struct/20210409-213822 git checkout 4690ebdd6fd3180366038788f7df1fa2420f00c9 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from include/linux/kernel.h:10, from include/linux/delay.h:22, from drivers/staging/media/imx/imx-ic-prpencvf.c:11: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra] 174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON' 137 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid' 137 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/staging/media/imx/imx-ic-prpencvf.c: In function '__prp_get_fmt': 796 | return v4l2_subdev_get_try_format(&ic_priv->sd, cfg, pad); | ^~~ | | | struct v4l2_subdev_pad_config * In file included from include/media/v4l2-device.h:13, from drivers/staging/media/imx/imx-ic-prpencvf.c:19: include/media/v4l2-subdev.h:957:34: note: expected 'struct v4l2_subdev_config *' but argument is of type 'struct v4l2_subdev_pad_config *' 957 | struct v4l2_subdev_config *cfg, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/staging/media/imx/imx-ic-prpencvf.c: At top level: 1300 | .init_cfg = imx_media_init_cfg, | ^~~~~~~~~~~~~~~~~~ drivers/staging/media/imx/imx-ic-prpencvf.c:1300:14: note: (near initialization for 'prp_pad_ops.init_cfg') 1301 | .enum_mbus_code = prp_enum_mbus_code, | ^~~~~~~~~~~~~~~~~~ drivers/staging/media/imx/imx-ic-prpencvf.c:1301:20: note: (near initialization for 'prp_pad_ops.enum_mbus_code') 1302 | .enum_frame_size = prp_enum_frame_size, | ^~~~~~~~~~~~~~~~~~~ drivers/staging/media/imx/imx-ic-prpencvf.c:1302:21: note: (near initialization for 'prp_pad_ops.enum_frame_size') drivers/staging/media/imx/imx-ic-prpencvf.c:1303:13: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_config *, struct v4l2_subdev_format *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types] 1303 | .get_fmt = prp_get_fmt, | ^~~~~~~~~~~ drivers/staging/media/imx/imx-ic-prpencvf.c:1303:13: note: (near initialization for 'prp_pad_ops.get_fmt') drivers/staging/media/imx/imx-ic-prpencvf.c:1304:13: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_config *, struct v4l2_subdev_format *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types] 1304 | .set_fmt = prp_set_fmt, | ^~~~~~~~~~~ drivers/staging/media/imx/imx-ic-prpencvf.c:1304:13: note: (near initialization for 'prp_pad_ops.set_fmt') cc1: some warnings being treated as errors -- In file included from include/linux/dev_printk.h:14, from include/linux/device.h:15, from drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:9: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:174:49: warning: ordered comparison of pointer with null pointer [-Wextra] 174 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:137:2: note: in expansion of macro 'BUG_ON' 137 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:137:10: note: in expansion of macro 'virt_addr_valid' 137 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c: In function 'sun4i_csi_subdev_init_cfg': 276 | fmt = v4l2_subdev_get_try_format(subdev, cfg, CSI_SUBDEV_SINK); | ^~~ | | | struct v4l2_subdev_pad_config * In file included from include/media/v4l2-mc.h:15, from drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:13: include/media/v4l2-subdev.h:957:34: note: expected 'struct v4l2_subdev_config *' but argument is of type 'struct v4l2_subdev_pad_config *' 957 | struct v4l2_subdev_config *cfg, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c: In function 'sun4i_csi_subdev_get_fmt': drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:290:51: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type [-Werror=incompatible-pointer-types] 290 | subdev_fmt = v4l2_subdev_get_try_format(subdev, cfg, fmt->pad); | ^~~ | | | struct v4l2_subdev_pad_config * In file included from include/media/v4l2-mc.h:15, from drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:13: include/media/v4l2-subdev.h:957:34: note: expected 'struct v4l2_subdev_config *' but argument is of type 'struct v4l2_subdev_pad_config *' 957 | struct v4l2_subdev_config *cfg, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c: In function 'sun4i_csi_subdev_set_fmt': drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:307:51: error: passing argument 2 of 'v4l2_subdev_get_try_format' from incompatible pointer type [-Werror=incompatible-pointer-types] 307 | subdev_fmt = v4l2_subdev_get_try_format(subdev, cfg, fmt->pad); | ^~~ | | | struct v4l2_subdev_pad_config * In file included from include/media/v4l2-mc.h:15, from drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:13: include/media/v4l2-subdev.h:957:34: note: expected 'struct v4l2_subdev_config *' but argument is of type 'struct v4l2_subdev_pad_config *' 957 | struct v4l2_subdev_config *cfg, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c: At top level: 339 | .init_cfg = sun4i_csi_subdev_init_cfg, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:339:14: note: (near initialization for 'sun4i_csi_subdev_pad_ops.init_cfg') 340 | .get_fmt = sun4i_csi_subdev_get_fmt, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:340:13: note: (near initialization for 'sun4i_csi_subdev_pad_ops.get_fmt') drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:341:13: error: initialization of 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_config *, struct v4l2_subdev_format *)' from incompatible pointer type 'int (*)(struct v4l2_subdev *, struct v4l2_subdev_pad_config *, struct v4l2_subdev_format *)' [-Werror=incompatible-pointer-types] 341 | .set_fmt = sun4i_csi_subdev_set_fmt, | ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:341:13: note: (near initialization for 'sun4i_csi_subdev_pad_ops.set_fmt') 342 | .enum_mbus_code = sun4i_csi_subdev_enum_mbus_code, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/sunxi/sun4i-csi/sun4i_v4l2.c:342:20: note: (near initialization for 'sun4i_csi_subdev_pad_ops.enum_mbus_code') cc1: some warnings being treated as errors vim +/v4l2_subdev_get_try_format +796 drivers/staging/media/imx/imx-ic-prpencvf.c f0d9c8924e2c33 Steve Longerbeam 2017-06-07 788 f0d9c8924e2c33 Steve Longerbeam 2017-06-07 789 static struct v4l2_mbus_framefmt * f0d9c8924e2c33 Steve Longerbeam 2017-06-07 790 __prp_get_fmt(struct prp_priv *priv, struct v4l2_subdev_pad_config *cfg, f0d9c8924e2c33 Steve Longerbeam 2017-06-07 791 unsigned int pad, enum v4l2_subdev_format_whence which) f0d9c8924e2c33 Steve Longerbeam 2017-06-07 792 { f0d9c8924e2c33 Steve Longerbeam 2017-06-07 793 struct imx_ic_priv *ic_priv = priv->ic_priv; f0d9c8924e2c33 Steve Longerbeam 2017-06-07 794 f0d9c8924e2c33 Steve Longerbeam 2017-06-07 795 if (which == V4L2_SUBDEV_FORMAT_TRY) f0d9c8924e2c33 Steve Longerbeam 2017-06-07 @796 return v4l2_subdev_get_try_format(&ic_priv->sd, cfg, pad); f0d9c8924e2c33 Steve Longerbeam 2017-06-07 797 else f0d9c8924e2c33 Steve Longerbeam 2017-06-07 798 return &priv->format_mbus[pad]; f0d9c8924e2c33 Steve Longerbeam 2017-06-07 799 } f0d9c8924e2c33 Steve Longerbeam 2017-06-07 800 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org