12:10 p.m.
Hi James,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next linus/master v5.9 next-20201012]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/James-Smart/efct-Broadcom-Emulex...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/72c2c89c37a70b6f2c3e50cd971b75818...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
James-Smart/efct-Broadcom-Emulex-FC-Target-driver/20201013-065423
git checkout 72c2c89c37a70b6f2c3e50cd971b758182f6190f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/device.h:15,
from include/linux/pci.h:37,
from drivers/scsi/elx/libefc_sli/sli4.h:15,
from drivers/scsi/elx/libefc_sli/sli4.c:11:
drivers/scsi/elx/libefc_sli/sli4.c: In function 'sli_bmbx_command':
> drivers/scsi/elx/libefc_sli/sli4.c:2941:4: warning: cast to
pointer from integer of different size [-Wint-to-pointer-cast]
2941 | (void
*)sli4->bmbx.phys,
| ^
include/linux/dev_printk.h:100:33: note: in definition of macro 'dev_crit'
100 | _dev_crit(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~
drivers/scsi/elx/libefc_sli/sli4.c:2940:3: note: in expansion of macro
'efc_log_crit'
2940 | efc_log_crit(sli4, "bootstrap mailbox write fail phys=%p
reg=%#x\n",
| ^~~~~~~~~~~~
vim +2941 drivers/scsi/elx/libefc_sli/sli4.c
d7de2565f5680e James Smart 2020-10-12 2923
d7de2565f5680e James Smart 2020-10-12 2924 int
d7de2565f5680e James Smart 2020-10-12 2925 sli_bmbx_command(struct sli4 *sli4)
d7de2565f5680e James Smart 2020-10-12 2926 {
d7de2565f5680e James Smart 2020-10-12 2927 void *cqe = (u8 *)sli4->bmbx.virt +
SLI4_BMBX_SIZE;
d7de2565f5680e James Smart 2020-10-12 2928
d7de2565f5680e James Smart 2020-10-12 2929 if (sli_fw_error_status(sli4) > 0) {
d7de2565f5680e James Smart 2020-10-12 2930 efc_log_crit(sli4, "Chip is in an
error state -Mailbox command rejected");
d7de2565f5680e James Smart 2020-10-12 2931 efc_log_crit(sli4, " status=%#x
error1=%#x error2=%#x\n",
d7de2565f5680e James Smart 2020-10-12 2932 sli_reg_read_status(sli4),
d7de2565f5680e James Smart 2020-10-12 2933 sli_reg_read_err1(sli4),
d7de2565f5680e James Smart 2020-10-12 2934 sli_reg_read_err2(sli4));
d7de2565f5680e James Smart 2020-10-12 2935 return EFC_FAIL;
d7de2565f5680e James Smart 2020-10-12 2936 }
d7de2565f5680e James Smart 2020-10-12 2937
d7de2565f5680e James Smart 2020-10-12 2938 /* Submit a command to the bootstrap mailbox
and check the status */
d7de2565f5680e James Smart 2020-10-12 2939 if (sli_bmbx_write(sli4)) {
d7de2565f5680e James Smart 2020-10-12 2940 efc_log_crit(sli4, "bootstrap mailbox
write fail phys=%p reg=%#x\n",
d7de2565f5680e James Smart 2020-10-12 @2941 (void *)sli4->bmbx.phys,
d7de2565f5680e James Smart 2020-10-12 2942 readl(sli4->reg[0] + SLI4_BMBX_REG));
d7de2565f5680e James Smart 2020-10-12 2943 return EFC_FAIL;
d7de2565f5680e James Smart 2020-10-12 2944 }
d7de2565f5680e James Smart 2020-10-12 2945
d7de2565f5680e James Smart 2020-10-12 2946 /* check completion queue entry status */
d7de2565f5680e James Smart 2020-10-12 2947 if (le32_to_cpu(((struct sli4_mcqe
*)cqe)->dw3_flags) &
d7de2565f5680e James Smart 2020-10-12 2948 SLI4_MCQE_VALID) {
d7de2565f5680e James Smart 2020-10-12 2949 return sli_cqe_mq(sli4, cqe);
d7de2565f5680e James Smart 2020-10-12 2950 }
d7de2565f5680e James Smart 2020-10-12 2951 efc_log_crit(sli4, "invalid or wrong
type\n");
d7de2565f5680e James Smart 2020-10-12 2952 return EFC_FAIL;
d7de2565f5680e James Smart 2020-10-12 2953 }
d7de2565f5680e James Smart 2020-10-12 2954
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org