4:01 p.m.
Hi Bob,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.8]
[cannot apply to linus/master v5.9-rc1 next-20200818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Bob-Pearson/rdma_rxe-Added-SPDX-...
base: bcf876870b95592b52519ed4aafcf9d95999bc9c
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/infiniband/sw/rxe/rxe_mw.c: In function 'do_bind_mw':
> drivers/infiniband/sw/rxe/rxe_mw.c:227:6: warning: variable
'ret' set but not used [-Wunused-but-set-variable]
227 | int ret;
| ^~~
# https://github.com/0day-ci/linux/commit/01db430643deac98d0b280d7d6a0939c5...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Bob-Pearson/rdma_rxe-Added-SPDX-headers-to-rxe-source-files/20200819-124026
git checkout 01db430643deac98d0b280d7d6a0939c5c0d7856
vim +/ret +227 drivers/infiniband/sw/rxe/rxe_mw.c
223
224 static int do_bind_mw(struct rxe_qp *qp, struct rxe_send_wqe *wqe,
225 struct rxe_mw *mw, struct rxe_mr *mr)
226 {
227 int ret;
228 u32 rkey;
229 u32 new_rkey;
230 struct rxe_mw *duplicate_mw;
231 struct rxe_dev *rxe = to_rdev(qp->ibqp.device);
232
233 /* key part of new rkey is provided by user for type 2
234 * and ibv_bind_mw() for type 1 MWs
235 * there is a very rare chance that the new rkey will
236 * collide with an existing MW. Return an error if this
237 * occurs
238 */
239 rkey = mw->ibmw.rkey;
240 new_rkey = (rkey & 0xffffff00) | (wqe->wr.wr.umw.rkey & 0x000000ff);
241 duplicate_mw = rxe_pool_get_key(&rxe->mw_pool, &new_rkey);
242 if (duplicate_mw) {
243 pr_err_once("new MW key is a duplicate, try another\n");
244 rxe_drop_ref(duplicate_mw);
245 return -EINVAL;
246 }
247
248 rxe_drop_key(mw);
249 ret = rxe_add_key(mw, &new_rkey);
250
251 mw->access = wqe->wr.wr.umw.access;
252 mw->state = RXE_MEM_STATE_VALID;
253 mw->addr = wqe->wr.wr.umw.addr;
254 mw->length = wqe->wr.wr.umw.length;
255
256 if (mw->mr) {
257 rxe_drop_ref(mw->mr);
258 atomic_dec(&mw->mr->num_mw);
259 mw->mr = NULL;
260 }
261
262 if (mw->length) {
263 mw->mr = mr;
264 atomic_inc(&mr->num_mw);
265 rxe_add_ref(mr);
266 }
267
268 if (mw->ibmw.type == IB_MW_TYPE_2)
269 mw->qp = qp;
270
271 return 0;
272 }
273
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org