[kbuild-all] Re: [PATCH v5 2/2] HID: logitech: Support WirelessDeviceStatus connect events

Hi Mazin, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc2 next-20191010] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Mazin-Rezk/HID-logitech-Add-MX-M... config: mips-allmodconfig (attached as .config) compiler: mips-linux-gcc (GCC) 7.4.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.4.0 make.cross ARCH=mips If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): In file included from include/linux/ioport.h:15:0, from include/linux/device.h:15, from drivers/hid/hid-logitech-hidpp.c:13: drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_send_rap_command_sync': include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32) ^~~ drivers/hid/hid-logitech-hidpp.c:351:26: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS' if (hidpp_dev->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS && ^ drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_report_is_connect_event': include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33) ^~~ return ((hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) && ^ include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32) ^~~ drivers/hid/hid-logitech-hidpp.c:415:20: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS' (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)) && ^ drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_validate_device': include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32) ^~~ drivers/hid/hid-logitech-hidpp.c:3522:22: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS' if (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS) ^ drivers/hid/hid-logitech-hidpp.c: In function 'hidpp_probe': include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33) ^~~ drivers/hid/hid-logitech-hidpp.c:3653:36: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS' if (connected && (hidpp->quirks & HIDPP_QUIRK_WIRELESS_DEVICE_STATUS)) { ^ drivers/hid/hid-logitech-hidpp.c: At top level: include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32) ^~~ drivers/hid/hid-logitech-hidpp.c:86:41: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS' #define HIDPP_QUIRK_CLASS_BLUETOOTH_LE (HIDPP_QUIRK_MISSING_SHORT_REPORTS | \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-logitech-hidpp.c:3826:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE' HIDPP_QUIRK_CLASS_BLUETOOTH_LE }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33) ^~~ drivers/hid/hid-logitech-hidpp.c:87:7: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS' HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-logitech-hidpp.c:3826:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE' HIDPP_QUIRK_CLASS_BLUETOOTH_LE }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:74:43: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_MISSING_SHORT_REPORTS BIT(32) ^~~ drivers/hid/hid-logitech-hidpp.c:86:41: note: in expansion of macro 'HIDPP_QUIRK_MISSING_SHORT_REPORTS' #define HIDPP_QUIRK_CLASS_BLUETOOTH_LE (HIDPP_QUIRK_MISSING_SHORT_REPORTS | \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-logitech-hidpp.c:3829:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE' HIDPP_QUIRK_CLASS_BLUETOOTH_LE }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/bits.h:8:26: warning: left shift count >= width of type [-Wshift-count-overflow] #define BIT(nr) (UL(1) << (nr)) ^ drivers/hid/hid-logitech-hidpp.c:75:44: note: in expansion of macro 'BIT' #define HIDPP_QUIRK_WIRELESS_DEVICE_STATUS BIT(33) ^~~ drivers/hid/hid-logitech-hidpp.c:87:7: note: in expansion of macro 'HIDPP_QUIRK_WIRELESS_DEVICE_STATUS' HIDPP_QUIRK_WIRELESS_DEVICE_STATUS) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/hid/hid-logitech-hidpp.c:3829:5: note: in expansion of macro 'HIDPP_QUIRK_CLASS_BLUETOOTH_LE' HIDPP_QUIRK_CLASS_BLUETOOTH_LE }, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +/HIDPP_QUIRK_WIRELESS_DEVICE_STATUS +412 drivers/hid/hid-logitech-hidpp.c 408 409 static inline bool hidpp_report_is_connect_event(struct hidpp_device *hidpp, 410 struct hidpp_report *report) 411 { 413 (report->fap.feature_index == hidpp->wireless_feature_index)) || 414 (((report->report_id == REPORT_ID_HIDPP_SHORT) || 415 (hidpp->quirks & HIDPP_QUIRK_MISSING_SHORT_REPORTS)) && 416 (report->rap.sub_id == 0x41)); 417 } 418 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation