3:58 a.m.
Hi Arun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.7-rc5 next-20200512]
[cannot apply to rpmsg/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Arun-Kumar-Neelakantam/Add-TIOCM...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
24085f70a6e1b0cb647ec92623284641d8270637
config: alpha-randconfig-r012-20200513 (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=alpha
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/rpmsg/rpmsg_char.c: In function 'rpmsg_eptdev_ioctl':
> drivers/rpmsg/rpmsg_char.c:322:9: warning: this statement may
fall through [-Wimplicit-fallthrough=]
322 | ret =
rpmsg_eptdev_destroy(&eptdev->dev, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/rpmsg/rpmsg_char.c:323:2: note: here
323 | default:
| ^~~~~~~
vim +322 drivers/rpmsg/rpmsg_char.c
303
304 static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd,
305 unsigned long arg)
306 {
307 struct rpmsg_eptdev *eptdev = fp->private_data;
308 int ret;
309
310 switch (cmd) {
311 case TIOCMGET:
312 ret = rpmsg_get_signals(eptdev->ept);
313 if (ret >= 0)
314 ret = put_user(ret, (int __user *)arg);
315 break;
316 case TIOCMSET:
317 case TIOCMBIS:
318 case TIOCMBIC:
319 ret = rpmsg_eptdev_tiocmset(fp, cmd, (int __user *)arg);
320 break;
321 case RPMSG_DESTROY_EPT_IOCTL:
322 ret = rpmsg_eptdev_destroy(&eptdev->dev, NULL);
323 default:
324 ret = -EINVAL;
325 }
326
327 return ret;
328 }
329
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org