4:11 a.m.
Hi Daniel,
I love your patch! Perhaps something to improve:
[auto build test WARNING on next-20200514]
[cannot apply to linus/master v5.7-rc5 v5.7-rc4 v5.7-rc3 v5.7-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Daniel-Lezcano/thermal-core-Add-...
base: c9529331c7a22b8eb7eb03e1e0e221d0f58b43de
config: x86_64-rhel-7.6-kselftests (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
> drivers/thermal/thermal_netlink.c:69:5: warning: no previous
prototype for 'thermal_genl_sampling_temp' [-Wmissing-prototypes]
int
thermal_genl_sampling_temp(int id, int temp)
^~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/thermal/thermal_netlink.c:509:5: warning: no previous
prototype for 'thermal_genl_cmd_dumpit' [-Wmissing-prototypes]
int
thermal_genl_cmd_dumpit(struct sk_buff *skb, struct netlink_callback *cb)
^~~~~~~~~~~~~~~~~~~~~~~
> drivers/thermal/thermal_netlink.c:535:5: warning: no previous
prototype for 'thermal_genl_cmd_doit' [-Wmissing-prototypes]
int
thermal_genl_cmd_doit(struct sk_buff *skb, struct genl_info *info)
^~~~~~~~~~~~~~~~~~~~~
vim +/thermal_genl_sampling_temp +69 drivers/thermal/thermal_netlink.c
68
69 int thermal_genl_sampling_temp(int id, int temp)
70 {
71 struct sk_buff *skb;
72 void *hdr;
73
74 skb = genlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
75 if (!skb)
76 return -ENOMEM;
77
78 hdr = genlmsg_put(skb, 0, 0, &thermal_gnl_family, 0,
79 THERMAL_GENL_SAMPLING_TEMP);
80 if (!hdr)
81 return -EMSGSIZE;
82
83 if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_ID, id))
84 goto out_cancel;
85
86 if (nla_put_u32(skb, THERMAL_GENL_ATTR_TZ_TEMP, temp))
87 goto out_cancel;
88
89 genlmsg_end(skb, hdr);
90
91 genlmsg_multicast(&thermal_gnl_family, skb, 0, 0, GFP_KERNEL);
92
93 return 0;
94 out_cancel:
95 genlmsg_cancel(skb, hdr);
96 nlmsg_free(skb);
97
98 return -EMSGSIZE;
99 }
100
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org