11:35 a.m.
Hi Pavel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on kselftest/next]
[also build test ERROR on tip/sched/core tip/perf/core linux/master linus/master v5.11-rc7
next-20210211]
[cannot apply to hnaz-linux-mm/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Pavel-Tatashin/prohibit-pinning-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: i386-randconfig-m021-20210209 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/44c3952d1b1e3998d6fa67b610bf24fa4...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Pavel-Tatashin/prohibit-pinning-pages-in-ZONE_MOVABLE/20210212-002530
git checkout 44c3952d1b1e3998d6fa67b610bf24fa4a4b134c
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from arch/x86/include/asm/page.h:76,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:58,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/linux/mm.h: In function 'is_pinnable_page':
include/asm-generic/memory_model.h:64:14: error: implicit declaration of function
'page_to_section'; did you mean 'present_section'?
[-Werror=implicit-function-declaration]
64 | int __sec = page_to_section(__pg); \
| ^~~~~~~~~~~~~~~
include/asm-generic/memory_model.h:81:21: note: in expansion of macro
'__page_to_pfn'
81 | #define page_to_pfn __page_to_pfn
| ^~~~~~~~~~~~~
include/linux/mmzone.h:94:32: note: in expansion of macro 'page_to_pfn'
94 | get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK)
| ^~~~~~~~~~~
include/linux/mmzone.h:74:39: note: in expansion of macro
'get_pageblock_migratetype'
74 | # define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) ==
MIGRATE_CMA)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mm.h:1128:41: note: in expansion of macro 'is_migrate_cma_page'
1128 | return !is_zone_movable_page(page) && !is_migrate_cma_page(page);
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/kallsyms.h:12,
from include/linux/bpf.h:21,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/mm.h: At top level:
> include/linux/mm.h:1502:29: error: conflicting types for
'page_to_section'
1502 | static inline unsigned long
page_to_section(const struct page *page)
| ^~~~~~~~~~~~~~~
In file included from arch/x86/include/asm/page.h:76,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:58,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/asm-generic/memory_model.h:64:14: note: previous implicit declaration of
'page_to_section' was here
64 | int __sec = page_to_section(__pg); \
| ^~~~~~~~~~~~~~~
include/asm-generic/memory_model.h:81:21: note: in expansion of macro
'__page_to_pfn'
81 | #define page_to_pfn __page_to_pfn
| ^~~~~~~~~~~~~
include/linux/mmzone.h:94:32: note: in expansion of macro 'page_to_pfn'
94 | get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK)
| ^~~~~~~~~~~
include/linux/mmzone.h:74:39: note: in expansion of macro
'get_pageblock_migratetype'
74 | # define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) ==
MIGRATE_CMA)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mm.h:1128:41: note: in expansion of macro 'is_migrate_cma_page'
1128 | return !is_zone_movable_page(page) && !is_migrate_cma_page(page);
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
--
In file included from arch/x86/include/asm/page.h:76,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:58,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/linux/mm.h: In function 'is_pinnable_page':
include/asm-generic/memory_model.h:64:14: error: implicit declaration of function
'page_to_section'; did you mean 'present_section'?
[-Werror=implicit-function-declaration]
64 | int __sec = page_to_section(__pg); \
| ^~~~~~~~~~~~~~~
include/asm-generic/memory_model.h:81:21: note: in expansion of macro
'__page_to_pfn'
81 | #define page_to_pfn __page_to_pfn
| ^~~~~~~~~~~~~
include/linux/mmzone.h:94:32: note: in expansion of macro 'page_to_pfn'
94 | get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK)
| ^~~~~~~~~~~
include/linux/mmzone.h:74:39: note: in expansion of macro
'get_pageblock_migratetype'
74 | # define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) ==
MIGRATE_CMA)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mm.h:1128:41: note: in expansion of macro 'is_migrate_cma_page'
1128 | return !is_zone_movable_page(page) && !is_migrate_cma_page(page);
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/kallsyms.h:12,
from include/linux/bpf.h:21,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/mm.h: At top level:
> include/linux/mm.h:1502:29: error: conflicting types for
'page_to_section'
1502 | static inline unsigned long
page_to_section(const struct page *page)
| ^~~~~~~~~~~~~~~
In file included from arch/x86/include/asm/page.h:76,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:58,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/asm-generic/memory_model.h:64:14: note: previous implicit declaration of
'page_to_section' was here
64 | int __sec = page_to_section(__pg); \
| ^~~~~~~~~~~~~~~
include/asm-generic/memory_model.h:81:21: note: in expansion of macro
'__page_to_pfn'
81 | #define page_to_pfn __page_to_pfn
| ^~~~~~~~~~~~~
include/linux/mmzone.h:94:32: note: in expansion of macro 'page_to_pfn'
94 | get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK)
| ^~~~~~~~~~~
include/linux/mmzone.h:74:39: note: in expansion of macro
'get_pageblock_migratetype'
74 | # define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) ==
MIGRATE_CMA)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mm.h:1128:41: note: in expansion of macro 'is_migrate_cma_page'
1128 | return !is_zone_movable_page(page) && !is_migrate_cma_page(page);
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1201: prepare0] Error 2
make[1]: Target 'modules_prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'modules_prepare' not remade because of errors.
--
In file included from arch/x86/include/asm/page.h:76,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:58,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/linux/mm.h: In function 'is_pinnable_page':
include/asm-generic/memory_model.h:64:14: error: implicit declaration of function
'page_to_section'; did you mean 'present_section'?
[-Werror=implicit-function-declaration]
64 | int __sec = page_to_section(__pg); \
| ^~~~~~~~~~~~~~~
include/asm-generic/memory_model.h:81:21: note: in expansion of macro
'__page_to_pfn'
81 | #define page_to_pfn __page_to_pfn
| ^~~~~~~~~~~~~
include/linux/mmzone.h:94:32: note: in expansion of macro 'page_to_pfn'
94 | get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK)
| ^~~~~~~~~~~
include/linux/mmzone.h:74:39: note: in expansion of macro
'get_pageblock_migratetype'
74 | # define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) ==
MIGRATE_CMA)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mm.h:1128:41: note: in expansion of macro 'is_migrate_cma_page'
1128 | return !is_zone_movable_page(page) && !is_migrate_cma_page(page);
| ^~~~~~~~~~~~~~~~~~~
In file included from include/linux/kallsyms.h:12,
from include/linux/bpf.h:21,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from arch/x86/kernel/asm-offsets.c:13:
include/linux/mm.h: At top level:
> include/linux/mm.h:1502:29: error: conflicting types for
'page_to_section'
1502 | static inline unsigned long
page_to_section(const struct page *page)
| ^~~~~~~~~~~~~~~
In file included from arch/x86/include/asm/page.h:76,
from arch/x86/include/asm/thread_info.h:12,
from include/linux/thread_info.h:58,
from arch/x86/include/asm/preempt.h:7,
from include/linux/preempt.h:78,
from include/linux/spinlock.h:51,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:6,
from include/linux/slab.h:15,
from include/linux/crypto.h:20,
from arch/x86/kernel/asm-offsets.c:9:
include/asm-generic/memory_model.h:64:14: note: previous implicit declaration of
'page_to_section' was here
64 | int __sec = page_to_section(__pg); \
| ^~~~~~~~~~~~~~~
include/asm-generic/memory_model.h:81:21: note: in expansion of macro
'__page_to_pfn'
81 | #define page_to_pfn __page_to_pfn
| ^~~~~~~~~~~~~
include/linux/mmzone.h:94:32: note: in expansion of macro 'page_to_pfn'
94 | get_pfnblock_flags_mask(page, page_to_pfn(page), MIGRATETYPE_MASK)
| ^~~~~~~~~~~
include/linux/mmzone.h:74:39: note: in expansion of macro
'get_pageblock_migratetype'
74 | # define is_migrate_cma_page(_page) (get_pageblock_migratetype(_page) ==
MIGRATE_CMA)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/mm.h:1128:41: note: in expansion of macro 'is_migrate_cma_page'
1128 | return !is_zone_movable_page(page) && !is_migrate_cma_page(page);
| ^~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1201: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:185: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/page_to_section +1502 include/linux/mm.h
bf4e8902ee5080 Daniel Kiper 2011-05-24 1501
aa462abe8aaf21 Ian Campbell 2011-08-17 @1502 static inline unsigned long
page_to_section(const struct page *page)
d41dee369bff3b Andy Whitcroft 2005-06-23 1503 {
d41dee369bff3b Andy Whitcroft 2005-06-23 1504 return (page->flags >>
SECTIONS_PGSHIFT) & SECTIONS_MASK;
d41dee369bff3b Andy Whitcroft 2005-06-23 1505 }
308c05e35e3517 Christoph Lameter 2008-04-28 1506 #endif
d41dee369bff3b Andy Whitcroft 2005-06-23 1507
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org