[kbuild-all] [asahilinux:nvme/dev 18/18] drivers/nvme/host/apple.c:335:17: error: implicit declaration of function 'dma_pool_free'; did you mean 'mempool_free'?

tree: https://github.com/AsahiLinux/linux nvme/dev head: d25eee8aced31cf92944992bec41022e6f837daf commit: d25eee8aced31cf92944992bec41022e6f837daf [18/18] HACK/DO-NOT-MERGE: nvme-apple: add initial Apple SoC NVMe driver config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20211210/202112101023.ETj5xDqK-lk...) compiler: sh4-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/AsahiLinux/linux/commit/d25eee8aced31cf92944992bec4102... git remote add asahilinux https://github.com/AsahiLinux/linux git fetch --no-tags asahilinux nvme/dev git checkout d25eee8aced31cf92944992bec41022e6f837daf # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=sh SHELL=/bin/bash drivers/nvme/host/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): drivers/nvme/host/apple.c: In function 'apple_nvme_free_prps': 335 | dma_pool_free(anv->prp_page_pool, prp_list, dma_addr); | ^~~~~~~~~~~~~ | mempool_free drivers/nvme/host/apple.c: In function 'apple_nvme_setup_prps': 420 | prp_list = dma_pool_alloc(pool, GFP_ATOMIC, &prp_dma); | ^~~~~~~~~~~~~~ | mempool_alloc 420 | prp_list = dma_pool_alloc(pool, GFP_ATOMIC, &prp_dma); | ^ drivers/nvme/host/apple.c:432:34: warning: assignment to '__le64 *' {aka 'long long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion] 432 | prp_list = dma_pool_alloc(pool, GFP_ATOMIC, &prp_dma); | ^ In file included from arch/sh/include/asm/bug.h:112, from include/linux/bug.h:5, from include/linux/thread_info.h:13, from include/asm-generic/current.h:5, from ./arch/sh/include/generated/asm/current.h:1, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/async.h:14, from drivers/nvme/host/apple.c:12: drivers/nvme/host/apple.c:462:14: error: implicit declaration of function 'DO_ONCE' [-Werror=implicit-function-declaration] 462 | WARN(DO_ONCE(apple_nvme_print_sgl, iod->sg, iod->nents), | ^~~~~~~ include/asm-generic/bug.h:130:32: note: in definition of macro 'WARN' 130 | int __ret_warn_on = !!(condition); \ | ^~~~~~~~~ drivers/nvme/host/apple.c: In function 'apple_nvme_probe': 1385 | dmam_pool_create("prp list page", anv->dev, NVME_CTRL_PAGE_SIZE, | ^~~~~~~~~~~~~~~~ | mempool_create 1384 | anv->prp_page_pool = | ^ drivers/nvme/host/apple.c:1390:29: warning: assignment to 'struct dma_pool *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 1390 | anv->prp_small_pool = | ^ cc1: some warnings being treated as errors vim +335 drivers/nvme/host/apple.c 323 324 static void apple_nvme_free_prps(struct apple_nvme *anv, struct request *req) 325 { 326 const int last_prp = NVME_CTRL_PAGE_SIZE / sizeof(__le64) - 1; 327 struct apple_nvme_iod *iod = blk_mq_rq_to_pdu(req); 328 dma_addr_t dma_addr = iod->first_dma; 329 int i; 330 331 for (i = 0; i < iod->npages; i++) { 332 __le64 *prp_list = apple_nvme_iod_list(req)[i]; 333 dma_addr_t next_dma_addr = le64_to_cpu(prp_list[last_prp]); 334 336 dma_addr = next_dma_addr; 337 } 338 } 339 340 static void apple_nvme_unmap_data(struct apple_nvme *anv, struct request *req) 341 { 342 struct apple_nvme_iod *iod = blk_mq_rq_to_pdu(req); 343 344 if (iod->dma_len) { 345 dma_unmap_page(anv->dev, iod->first_dma, iod->dma_len, 346 rq_dma_dir(req)); 347 return; 348 } 349 350 WARN_ON_ONCE(!iod->nents); 351 352 dma_unmap_sg(anv->dev, iod->sg, iod->nents, rq_dma_dir(req)); 353 if (iod->npages == 0) 354 dma_pool_free(anv->prp_small_pool, apple_nvme_iod_list(req)[0], 355 iod->first_dma); 356 else 357 apple_nvme_free_prps(anv, req); 358 mempool_free(iod->sg, anv->iod_mempool); 359 } 360 361 static void apple_nvme_print_sgl(struct scatterlist *sgl, int nents) 362 { 363 int i; 364 struct scatterlist *sg; 365 366 for_each_sg (sgl, sg, nents, i) { 367 dma_addr_t phys = sg_phys(sg); 368 pr_warn("sg[%d] phys_addr:%pad offset:%d length:%d " 369 "dma_address:%pad dma_length:%d\n", 370 i, &phys, sg->offset, sg->length, &sg_dma_address(sg), 371 sg_dma_len(sg)); 372 } 373 } 374 375 static blk_status_t apple_nvme_setup_prps(struct apple_nvme *anv, 376 struct request *req, 377 struct nvme_rw_command *cmnd) 378 { 379 struct apple_nvme_iod *iod = blk_mq_rq_to_pdu(req); 380 struct dma_pool *pool; 381 int length = blk_rq_payload_bytes(req); 382 struct scatterlist *sg = iod->sg; 383 int dma_len = sg_dma_len(sg); 384 u64 dma_addr = sg_dma_address(sg); 385 int offset = dma_addr & (NVME_CTRL_PAGE_SIZE - 1); 386 __le64 *prp_list; 387 void **list = apple_nvme_iod_list(req); 388 dma_addr_t prp_dma; 389 int nprps, i; 390 391 length -= (NVME_CTRL_PAGE_SIZE - offset); 392 if (length <= 0) { 393 iod->first_dma = 0; 394 goto done; 395 } 396 397 dma_len -= (NVME_CTRL_PAGE_SIZE - offset); 398 if (dma_len) { 399 dma_addr += (NVME_CTRL_PAGE_SIZE - offset); 400 } else { 401 sg = sg_next(sg); 402 dma_addr = sg_dma_address(sg); 403 dma_len = sg_dma_len(sg); 404 } 405 406 if (length <= NVME_CTRL_PAGE_SIZE) { 407 iod->first_dma = dma_addr; 408 goto done; 409 } 410 411 nprps = DIV_ROUND_UP(length, NVME_CTRL_PAGE_SIZE); 412 if (nprps <= (256 / 8)) { 413 pool = anv->prp_small_pool; 414 iod->npages = 0; 415 } else { 416 pool = anv->prp_page_pool; 417 iod->npages = 1; 418 } 419 421 if (!prp_list) { 422 iod->first_dma = dma_addr; 423 iod->npages = -1; 424 return BLK_STS_RESOURCE; 425 } 426 list[0] = prp_list; 427 iod->first_dma = prp_dma; 428 i = 0; 429 for (;;) { 430 if (i == NVME_CTRL_PAGE_SIZE >> 3) { 431 __le64 *old_prp_list = prp_list; 432 prp_list = dma_pool_alloc(pool, GFP_ATOMIC, &prp_dma); 433 if (!prp_list) 434 goto free_prps; 435 list[iod->npages++] = prp_list; 436 prp_list[0] = old_prp_list[i - 1]; 437 old_prp_list[i - 1] = cpu_to_le64(prp_dma); 438 i = 1; 439 } 440 prp_list[i++] = cpu_to_le64(dma_addr); 441 dma_len -= NVME_CTRL_PAGE_SIZE; 442 dma_addr += NVME_CTRL_PAGE_SIZE; 443 length -= NVME_CTRL_PAGE_SIZE; 444 if (length <= 0) 445 break; 446 if (dma_len > 0) 447 continue; 448 if (unlikely(dma_len < 0)) 449 goto bad_sgl; 450 sg = sg_next(sg); 451 dma_addr = sg_dma_address(sg); 452 dma_len = sg_dma_len(sg); 453 } 454 done: 455 cmnd->dptr.prp1 = cpu_to_le64(sg_dma_address(iod->sg)); 456 cmnd->dptr.prp2 = cpu_to_le64(iod->first_dma); 457 return BLK_STS_OK; 458 free_prps: 459 apple_nvme_free_prps(anv, req); 460 return BLK_STS_RESOURCE; 461 bad_sgl: 462 WARN(DO_ONCE(apple_nvme_print_sgl, iod->sg, iod->nents), 463 "Invalid SGL for payload:%d nents:%d\n", blk_rq_payload_bytes(req), 464 iod->nents); 465 return BLK_STS_IOERR; 466 } 467 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org