6:10 p.m.
Hi Sasha,
url:
https://github.com/0day-ci/linux/commits/Sasha-Levin/DirectX-on-Linux/202...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
642b151f45dd54809ea00ecd3976a56c1ec9b53d
config: i386-allyesconfig (attached as .config)
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/gpu/dxgkrnl/dxgadapter.c:923 dxgallocation_destroy() error: we previously assumed
'alloc->owner.device' could be null (see line 919)
drivers/gpu/dxgkrnl/dxgadapter.c:1246 dxgsyncobject_create() error: we previously assumed
'syncobj' could be null (see line 1205)
drivers/gpu/dxgkrnl/dxgadapter.c:1248 dxgsyncobject_create() warn: variable dereferenced
before check 'syncobj' (see line 1246)
drivers/gpu/dxgkrnl/dxgvmbus.c:205 dxgvmbuschannel_receive() warn: inconsistent indenting
drivers/gpu/dxgkrnl/dxgvmbus.c:240 dxgvmb_send_sync_msg() warn: inconsistent indenting
drivers/gpu/dxgkrnl/dxgvmbus.c:2310 dxgvmb_send_create_hwqueue() error: we previously
assumed 'command' could be null (see line 2234)
Old smatch warnings:
drivers/gpu/dxgkrnl/dxgvmbus.c:246 dxgvmb_send_sync_msg() warn: inconsistent indenting
# https://github.com/0day-ci/linux/commit/09405fa255395b8e7fb7c8a886b18028b...
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 09405fa255395b8e7fb7c8a886b18028b907487c
vim +923 drivers/gpu/dxgkrnl/dxgadapter.c
9cc562c3695b5b Sasha Levin 2020-05-19 911 void dxgallocation_destroy(struct
dxgallocation *alloc)
9cc562c3695b5b Sasha Levin 2020-05-19 912 {
9cc562c3695b5b Sasha Levin 2020-05-19 913 struct dxgprocess *process =
alloc->process;
9cc562c3695b5b Sasha Levin 2020-05-19 914 struct d3dkmt_destroyallocation2 args = { };
9cc562c3695b5b Sasha Levin 2020-05-19 915
9cc562c3695b5b Sasha Levin 2020-05-19 916 dxgallocation_stop(alloc);
9cc562c3695b5b Sasha Levin 2020-05-19 917 if (alloc->resource_owner)
9cc562c3695b5b Sasha Levin 2020-05-19 918
dxgresource_remove_alloc(alloc->owner.resource, alloc);
9cc562c3695b5b Sasha Levin 2020-05-19 @919 else if (alloc->owner.device)
^^^^^^^^^^^^^^^^^^^
Checked.
9cc562c3695b5b Sasha Levin 2020-05-19 920
dxgdevice_remove_alloc(alloc->owner.device, alloc);
^^^^^^^^^^^^^^^^^^^
Freed here?
9cc562c3695b5b Sasha Levin 2020-05-19 921 dxgallocation_free_handle(alloc);
9cc562c3695b5b Sasha Levin 2020-05-19 922 if (alloc->alloc_handle &&
!alloc->resource_owner) {
9cc562c3695b5b Sasha Levin 2020-05-19 @923 args.device =
alloc->owner.device->handle;
^^^^^^^^^^^^^^^^^^^
Unchecked dereference.
9cc562c3695b5b Sasha Levin 2020-05-19 924 args.alloc_count = 1;
9cc562c3695b5b Sasha Levin 2020-05-19 925 args.flags.assume_not_in_use = 1;
9cc562c3695b5b Sasha Levin 2020-05-19 926 dxgvmb_send_destroy_allocation(process,
9cc562c3695b5b Sasha Levin 2020-05-19 927 alloc->owner.device,
9cc562c3695b5b Sasha Levin 2020-05-19 928
&alloc->owner.device->adapter->
9cc562c3695b5b Sasha Levin 2020-05-19 929 channel, &args,
9cc562c3695b5b Sasha Levin 2020-05-19 930 &alloc->alloc_handle);
9cc562c3695b5b Sasha Levin 2020-05-19 931 }
9cc562c3695b5b Sasha Levin 2020-05-19 932 if (alloc->gpadl) {
9cc562c3695b5b Sasha Levin 2020-05-19 933 TRACE_DEBUG(1, "Teardown gpadl
%d", alloc->gpadl);
9cc562c3695b5b Sasha Levin 2020-05-19 934 vmbus_teardown_gpadl(dxgglobal_get_vmbus(),
alloc->gpadl);
9cc562c3695b5b Sasha Levin 2020-05-19 935 TRACE_DEBUG(1, "Teardown gpadl
end");
9cc562c3695b5b Sasha Levin 2020-05-19 936 alloc->gpadl = 0;
9cc562c3695b5b Sasha Levin 2020-05-19 937 }
9cc562c3695b5b Sasha Levin 2020-05-19 938 if (alloc->priv_drv_data)
9cc562c3695b5b Sasha Levin 2020-05-19 939 dxgmem_free(alloc->process,
DXGMEM_ALLOCPRIVATE,
9cc562c3695b5b Sasha Levin 2020-05-19 940 alloc->priv_drv_data);
9cc562c3695b5b Sasha Levin 2020-05-19 941 if (alloc->cpu_address_mapped)
9cc562c3695b5b Sasha Levin 2020-05-19 942 pr_err("Alloc IO space is mapped:
%p", alloc);
9cc562c3695b5b Sasha Levin 2020-05-19 943 dxgmem_free(alloc->process,
DXGMEM_ALLOCATION, alloc);
9cc562c3695b5b Sasha Levin 2020-05-19 944 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org