[kbuild-all] [xlnx:xlnx_rebase_v5.10 813/1761] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1141:3: warning: comparison of distinct pointer types ('unsigned long ' and 'typeof (flags) ' (aka 'unsigned int *'))

Friday, 13 August 2021

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.10
head:   e14d4574ca81a569ee6d07e03271f2ae2dad38e4
commit: 1b5d1c43433b3ec5407db48688e717285e7edafe [813/1761] net: xilinx: axiethernet: Add
check for transmit data FIFO vacancy
config: s390-randconfig-r012-20210812 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
767496d19cb9a1fbba57ff08095faa161998ee36)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install s390 cross compiling tool for clang build
        # apt-get install binutils-s390x-linux-gnu
        #
https://github.com/Xilinx/linux-xlnx/commit/1b5d1c43433b3ec5407db48688e71...
        git remote add xlnx https://github.com/Xilinx/linux-xlnx
        git fetch --no-tags xlnx xlnx_rebase_v5.10
        git checkout 1b5d1c43433b3ec5407db48688e717285e7edafe
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;

All warnings (new ones prefixed by >>):

   include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
                                                           ~~~~~~~~~~ ^
   include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro
'__le32_to_cpu'
   #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
                                                             ^
   include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32'
           ___constant_swab32(x) :                 \
                              ^
   include/uapi/linux/swab.h:20:12: note: expanded from macro
'___constant_swab32'
           (((__u32)(x) & (__u32)0x0000ff00UL) <<  8) |            \
                     ^
   In file included from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:28:
   In file included from include/linux/etherdevice.h:20:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/s390/include/asm/io.h:80:
   include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
                                                           ~~~~~~~~~~ ^
   include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro
'__le32_to_cpu'
   #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
                                                             ^
   include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32'
           ___constant_swab32(x) :                 \
                              ^
   include/uapi/linux/swab.h:21:12: note: expanded from macro
'___constant_swab32'
           (((__u32)(x) & (__u32)0x00ff0000UL) >>  8) |            \
                     ^
   In file included from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:28:
   In file included from include/linux/etherdevice.h:20:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/s390/include/asm/io.h:80:
   include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
                                                           ~~~~~~~~~~ ^
   include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro
'__le32_to_cpu'
   #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
                                                             ^
   include/uapi/linux/swab.h:119:21: note: expanded from macro '__swab32'
           ___constant_swab32(x) :                 \
                              ^
   include/uapi/linux/swab.h:22:12: note: expanded from macro
'___constant_swab32'
           (((__u32)(x) & (__u32)0xff000000UL) >> 24)))
                     ^
   In file included from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:28:
   In file included from include/linux/etherdevice.h:20:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/s390/include/asm/io.h:80:
   include/asm-generic/io.h:490:61: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
                                                           ~~~~~~~~~~ ^
   include/uapi/linux/byteorder/big_endian.h:34:59: note: expanded from macro
'__le32_to_cpu'
   #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x))
                                                             ^
   include/uapi/linux/swab.h:120:12: note: expanded from macro '__swab32'
           __fswab32(x))
                     ^
   In file included from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:28:
   In file included from include/linux/etherdevice.h:20:
   In file included from include/linux/if_ether.h:19:
   In file included from include/linux/skbuff.h:31:
   In file included from include/linux/dma-mapping.h:10:
   In file included from include/linux/scatterlist.h:9:
   In file included from arch/s390/include/asm/io.h:80:
   include/asm-generic/io.h:501:33: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           __raw_writeb(value, PCI_IOBASE + addr);
                               ~~~~~~~~~~ ^
   include/asm-generic/io.h:511:59: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
                                                         ~~~~~~~~~~ ^
   include/asm-generic/io.h:521:59: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
                                                         ~~~~~~~~~~ ^
   include/asm-generic/io.h:609:20: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           readsb(PCI_IOBASE + addr, buffer, count);
                  ~~~~~~~~~~ ^
   include/asm-generic/io.h:617:20: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           readsw(PCI_IOBASE + addr, buffer, count);
                  ~~~~~~~~~~ ^
   include/asm-generic/io.h:625:20: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           readsl(PCI_IOBASE + addr, buffer, count);
                  ~~~~~~~~~~ ^
   include/asm-generic/io.h:634:21: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           writesb(PCI_IOBASE + addr, buffer, count);
                   ~~~~~~~~~~ ^
   include/asm-generic/io.h:643:21: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           writesw(PCI_IOBASE + addr, buffer, count);
                   ~~~~~~~~~~ ^
   include/asm-generic/io.h:652:21: warning: performing pointer arithmetic on a null
pointer has undefined behavior [-Wnull-pointer-arithmetic]
           writesl(PCI_IOBASE + addr, buffer, count);
                   ~~~~~~~~~~ ^
...
> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1141:3:
warning: comparison of distinct pointer types ('unsigned long *' and 'typeof
(flags) *' (aka 'unsigned int *')) [-Wcompare-distinct-pointer-types]   
                spin_lock_irqsave(&lp->ptp_tx_lock, flags);
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/spinlock.h:384:2: note: expanded from macro 'spin_lock_irqsave'
           raw_spin_lock_irqsave(spinlock_check(lock), flags);     \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/spinlock.h:251:3: note: expanded from macro
'raw_spin_lock_irqsave'
                   typecheck(unsigned long, flags);        \
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/typecheck.h:12:18: note: expanded from macro 'typecheck'
           (void)(&__dummy == &__dummy2); \
                  ~~~~~~~~ ^  ~~~~~~~~~
   drivers/net/ethernet/xilinx/xilinx_axienet_main.c:702:12: warning: unused function
'axienet_free_tx_chain' [-Wunused-function]
   static int axienet_free_tx_chain(struct net_device *ndev, u32 first_bd,
              ^
   In file included from drivers/net/ethernet/xilinx/xilinx_axienet_main.c:25:
   In file included from include/linux/clk.h:13:
   In file included from include/linux/kernel.h:12:
   In file included from include/linux/bitops.h:29:
   arch/s390/include/asm/bitops.h:90:4: error: invalid operand in inline asm:
'ni	$0,${1:b}'
                           "ni     %0,%b1\n"
                           ^
   arch/s390/include/asm/bitops.h:90:4: error: invalid operand in inline asm:
'ni	$0,${1:b}'
   arch/s390/include/asm/bitops.h:90:4: error: invalid operand in inline asm:
'ni	$0,${1:b}'
   arch/s390/include/asm/bitops.h:69:4: error: invalid operand in inline asm:
'oi	$0,${1:b}'
                           "oi     %0,%b1\n"
                           ^
   arch/s390/include/asm/bitops.h:69:4: error: invalid operand in inline asm:
'oi	$0,${1:b}'
   22 warnings and 5 errors generated.

vim +1141 drivers/net/ethernet/xilinx/xilinx_axienet_main.c

  1118	
  1119		if (msg_type == TX_TS_OP_NOOP) {
  1120			buf[0] = TX_TS_OP_NOOP;
  1121		} else if (msg_type == TX_TS_OP_ONESTEP) {
  1122			buf[0] = TX_TS_OP_ONESTEP;
  1123			buf[1] = TX_TS_CSUM_UPDATE;
  1124			buf[4] = TX_PTP_TS_OFFSET;
  1125			buf[6] = TX_PTP_CSUM_OFFSET;
  1126		} else {
  1127			buf[0] = TX_TS_OP_TWOSTEP;
  1128			buf[2] = cur_p->ptp_tx_ts_tag & 0xFF;
  1129			buf[3] = (cur_p->ptp_tx_ts_tag >> 8) & 0xFF;
  1130		}
  1131	
  1132		if (lp->axienet_config->mactype == XAXIENET_1G ||
  1133		    lp->axienet_config->mactype == XAXIENET_2_5G) {
  1134			memcpy(&val, buf, AXIENET_TS_HEADER_LEN);
  1135			swab64s(&val);
  1136			memcpy(buf, &val, AXIENET_TS_HEADER_LEN);
  1137		} else if (lp->axienet_config->mactype == XAXIENET_10G_25G ||
  1138			   lp->axienet_config->mactype == XAXIENET_MRMAC) {
  1139			memcpy(&tmp, buf, XXVENET_TS_HEADER_LEN);
  1140			/* Check for Transmit Data FIFO Vacancy */
...
 1141			spin_lock_irqsave(&lp->ptp_tx_lock, flags);  
1142			if (!axienet_txts_ior(lp, XAXIFIFO_TXTS_TDFV)) {
  1143				spin_unlock_irqrestore(&lp->ptp_tx_lock, flags);
  1144				return NETDEV_TX_BUSY;
  1145			}
  1146			axienet_txts_iow(lp, XAXIFIFO_TXTS_TXFD, tmp);
  1147			axienet_txts_iow(lp, XAXIFIFO_TXTS_TLR,
  1148					 XXVENET_TS_HEADER_LEN);
  1149			spin_unlock_irqrestore(&lp->ptp_tx_lock, flags);
  1150		}
  1151	
  1152		return 0;
  1153	}
  1154	#endif
  1155	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019

[kbuild-all] [xlnx:xlnx_rebase_v5.10 813/1761] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1141:3: warning: comparison of distinct pointer types ('unsigned long ' and 'typeof (flags) ' (aka 'unsigned int *'))

2022

2021

2020

2019

[kbuild-all] [xlnx:xlnx_rebase_v5.10 813/1761] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1141:3: warning: comparison of distinct pointer types ('unsigned long *' and 'typeof (flags) *' (aka 'unsigned int *'))

[kbuild-all] [xlnx:xlnx_rebase_v5.10 813/1761] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1141:3: warning: comparison of distinct pointer types ('unsigned long ' and 'typeof (flags) ' (aka 'unsigned int *'))