6:01 a.m.
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on v5.8-rc5]
[cannot apply to scsi/for-next mkp-scsi/for-next next-20200717]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/scsi-use-generic-p...
base: 11ba468877bb23f28956a35e896356252d63c983
config: arm64-randconfig-r004-20200716 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project
ed6b578040a85977026c93bf4188f996148f3218)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/scsi/esas2r/esas2r_init.c:696:6: warning: variable
'rez' is used uninitialized whenever 'if' condition is true
[-Wsometimes-uninitialized]
if (test_bit(AF2_IRQ_CLAIMED,
&a->flags2)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/esas2r/esas2r_init.c:712:10: note: uninitialized use occurs here
rez);
^~~
drivers/scsi/esas2r/esas2r_init.c:696:2: note: remove the 'if' if its condition
is always false
if (test_bit(AF2_IRQ_CLAIMED, &a->flags2)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/scsi/esas2r/esas2r_init.c:661:9: note: initialize the variable 'rez' to
silence this warning
int rez;
^
= 0
1 warning generated.
vim +696 drivers/scsi/esas2r/esas2r_init.c
26780d9e12edf4 Bradley Grove 2013-08-23 656
d045ddf3e97346 Vaibhav Gupta 2020-07-17 657 static int __maybe_unused
esas2r_resume(struct device *dev)
26780d9e12edf4 Bradley Grove 2013-08-23 658 {
d045ddf3e97346 Vaibhav Gupta 2020-07-17 659 struct Scsi_Host *host =
dev_get_drvdata(dev);
26780d9e12edf4 Bradley Grove 2013-08-23 660 struct esas2r_adapter *a = (struct
esas2r_adapter *)host->hostdata;
26780d9e12edf4 Bradley Grove 2013-08-23 661 int rez;
26780d9e12edf4 Bradley Grove 2013-08-23 662
d045ddf3e97346 Vaibhav Gupta 2020-07-17 663 esas2r_log_dev(ESAS2R_LOG_INFO, dev,
"resuming adapter()");
d045ddf3e97346 Vaibhav Gupta 2020-07-17 664 esas2r_log_dev(ESAS2R_LOG_INFO, dev,
d045ddf3e97346 Vaibhav Gupta 2020-07-17 665 "device_wakeup_disable()
"
26780d9e12edf4 Bradley Grove 2013-08-23 666 "called");
d045ddf3e97346 Vaibhav Gupta 2020-07-17 667 device_wakeup_disable(dev);
26780d9e12edf4 Bradley Grove 2013-08-23 668
26780d9e12edf4 Bradley Grove 2013-08-23 669 if (!a) {
26780d9e12edf4 Bradley Grove 2013-08-23 670 rez = -ENODEV;
26780d9e12edf4 Bradley Grove 2013-08-23 671 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 672 }
26780d9e12edf4 Bradley Grove 2013-08-23 673
26780d9e12edf4 Bradley Grove 2013-08-23 674 if (esas2r_map_regions(a) != 0) {
26780d9e12edf4 Bradley Grove 2013-08-23 675 esas2r_log(ESAS2R_LOG_CRIT, "could
not re-map PCI regions!");
26780d9e12edf4 Bradley Grove 2013-08-23 676 rez = -ENOMEM;
26780d9e12edf4 Bradley Grove 2013-08-23 677 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 678 }
26780d9e12edf4 Bradley Grove 2013-08-23 679
26780d9e12edf4 Bradley Grove 2013-08-23 680 /* Set up interupt mode */
26780d9e12edf4 Bradley Grove 2013-08-23 681 esas2r_setup_interrupts(a,
a->intr_mode);
26780d9e12edf4 Bradley Grove 2013-08-23 682
26780d9e12edf4 Bradley Grove 2013-08-23 683 /*
26780d9e12edf4 Bradley Grove 2013-08-23 684 * Disable chip interrupts to prevent
spurious interrupts until we
26780d9e12edf4 Bradley Grove 2013-08-23 685 * claim the IRQ.
26780d9e12edf4 Bradley Grove 2013-08-23 686 */
26780d9e12edf4 Bradley Grove 2013-08-23 687 esas2r_disable_chip_interrupts(a);
26780d9e12edf4 Bradley Grove 2013-08-23 688 if (!esas2r_power_up(a, true)) {
26780d9e12edf4 Bradley Grove 2013-08-23 689 esas2r_debug("yikes, esas2r_power_up
failed");
26780d9e12edf4 Bradley Grove 2013-08-23 690 rez = -ENOMEM;
26780d9e12edf4 Bradley Grove 2013-08-23 691 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 692 }
26780d9e12edf4 Bradley Grove 2013-08-23 693
26780d9e12edf4 Bradley Grove 2013-08-23 694 esas2r_claim_interrupts(a);
26780d9e12edf4 Bradley Grove 2013-08-23 695
9588d24e36003b Bradley Grove 2013-10-01 @696 if (test_bit(AF2_IRQ_CLAIMED,
&a->flags2)) {
26780d9e12edf4 Bradley Grove 2013-08-23 697 /*
26780d9e12edf4 Bradley Grove 2013-08-23 698 * Now that system interrupt(s) are
claimed, we can enable
26780d9e12edf4 Bradley Grove 2013-08-23 699 * chip interrupts.
26780d9e12edf4 Bradley Grove 2013-08-23 700 */
26780d9e12edf4 Bradley Grove 2013-08-23 701 esas2r_enable_chip_interrupts(a);
26780d9e12edf4 Bradley Grove 2013-08-23 702 esas2r_kickoff_timer(a);
26780d9e12edf4 Bradley Grove 2013-08-23 703 } else {
26780d9e12edf4 Bradley Grove 2013-08-23 704 esas2r_debug("yikes, unable to claim
IRQ");
26780d9e12edf4 Bradley Grove 2013-08-23 705 esas2r_log(ESAS2R_LOG_CRIT, "could
not re-claim IRQ!");
26780d9e12edf4 Bradley Grove 2013-08-23 706 rez = -ENOMEM;
26780d9e12edf4 Bradley Grove 2013-08-23 707 goto error_exit;
26780d9e12edf4 Bradley Grove 2013-08-23 708 }
26780d9e12edf4 Bradley Grove 2013-08-23 709
26780d9e12edf4 Bradley Grove 2013-08-23 710 error_exit:
d045ddf3e97346 Vaibhav Gupta 2020-07-17 711 esas2r_log_dev(ESAS2R_LOG_CRIT, dev,
"esas2r_resume(): %d",
26780d9e12edf4 Bradley Grove 2013-08-23 712 rez);
26780d9e12edf4 Bradley Grove 2013-08-23 713 return rez;
26780d9e12edf4 Bradley Grove 2013-08-23 714 }
26780d9e12edf4 Bradley Grove 2013-08-23 715
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org