4:18 p.m.
Hi Manivannan,
I love your patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing]
[also build test ERROR on linux/master linus/master v5.15-rc6]
[cannot apply to char-misc/char-misc-testing next-20211021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/MHI-patche...
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
502408a61f4b7eb4713f44bd77f4a48e6cb1b59a
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/f0be8fa21fa4e6ddc6998710bf912a648...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Manivannan-Sadhasivam/MHI-patches-for-v5-16/20211016-145939
git checkout f0be8fa21fa4e6ddc6998710bf912a6483a3c09d
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=m68k SHELL=/bin/bash drivers/net/wwan/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/net/wwan/mhi_wwan_mbim.c: In function 'mhi_mbim_probe':
> drivers/net/wwan/mhi_wwan_mbim.c:612:15: error: too few arguments
to function 'mhi_prepare_for_transfer'
612 | err =
mhi_prepare_for_transfer(mhi_dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/wwan/mhi_wwan_mbim.c:18:
include/linux/mhi.h:728:5: note: declared here
728 | int mhi_prepare_for_transfer(struct mhi_device *mhi_dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/mhi_prepare_for_transfer +612 drivers/net/wwan/mhi_wwan_mbim.c
aa730a9905b7b0 Loic Poulain 2021-08-03 593
aa730a9905b7b0 Loic Poulain 2021-08-03 594 static int mhi_mbim_probe(struct mhi_device
*mhi_dev, const struct mhi_device_id *id)
aa730a9905b7b0 Loic Poulain 2021-08-03 595 {
aa730a9905b7b0 Loic Poulain 2021-08-03 596 struct mhi_controller *cntrl =
mhi_dev->mhi_cntrl;
aa730a9905b7b0 Loic Poulain 2021-08-03 597 struct mhi_mbim_context *mbim;
aa730a9905b7b0 Loic Poulain 2021-08-03 598 int err;
aa730a9905b7b0 Loic Poulain 2021-08-03 599
aa730a9905b7b0 Loic Poulain 2021-08-03 600 mbim = devm_kzalloc(&mhi_dev->dev,
sizeof(*mbim), GFP_KERNEL);
aa730a9905b7b0 Loic Poulain 2021-08-03 601 if (!mbim)
aa730a9905b7b0 Loic Poulain 2021-08-03 602 return -ENOMEM;
aa730a9905b7b0 Loic Poulain 2021-08-03 603
94c0a6fbd5cfc3 Wei Yongjun 2021-08-08 604 spin_lock_init(&mbim->tx_lock);
aa730a9905b7b0 Loic Poulain 2021-08-03 605 dev_set_drvdata(&mhi_dev->dev,
mbim);
aa730a9905b7b0 Loic Poulain 2021-08-03 606 mbim->mdev = mhi_dev;
aa730a9905b7b0 Loic Poulain 2021-08-03 607 mbim->mru =
mhi_dev->mhi_cntrl->mru ? mhi_dev->mhi_cntrl->mru : MHI_DEFAULT_MRU;
aa730a9905b7b0 Loic Poulain 2021-08-03 608
aa730a9905b7b0 Loic Poulain 2021-08-03 609 INIT_DELAYED_WORK(&mbim->rx_refill,
mhi_net_rx_refill_work);
aa730a9905b7b0 Loic Poulain 2021-08-03 610
aa730a9905b7b0 Loic Poulain 2021-08-03 611 /* Start MHI channels */
97c78d0af55fff Jakub Kicinski 2021-08-26 @612 err = mhi_prepare_for_transfer(mhi_dev);
aa730a9905b7b0 Loic Poulain 2021-08-03 613 if (err)
aa730a9905b7b0 Loic Poulain 2021-08-03 614 return err;
aa730a9905b7b0 Loic Poulain 2021-08-03 615
aa730a9905b7b0 Loic Poulain 2021-08-03 616 /* Number of transfer descriptors
determines size of the queue */
aa730a9905b7b0 Loic Poulain 2021-08-03 617 mbim->rx_queue_sz =
mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
aa730a9905b7b0 Loic Poulain 2021-08-03 618
aa730a9905b7b0 Loic Poulain 2021-08-03 619 /* Register wwan link ops with MHI
controller representing WWAN instance */
aa730a9905b7b0 Loic Poulain 2021-08-03 620 return
wwan_register_ops(&cntrl->mhi_dev->dev, &mhi_mbim_wwan_ops, mbim, 0);
aa730a9905b7b0 Loic Poulain 2021-08-03 621 }
aa730a9905b7b0 Loic Poulain 2021-08-03 622
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org