[kbuild-all] [PATCH] scripts/dtc: fix bugon.cocci warnings

From: kernel test robot <lkp(a)intel.com&gt; fs/ntfs/aops.c:1198:3-6: WARNING: Use BUG_ON Use BUG_ON instead of a if condition followed by BUG. Semantic patch information: This makes an effort to find cases where BUG() follows an if condition on an expression and replaces the if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. Generated by: scripts/coccinelle/misc/bugon.cocci Fixes: 8214bf079208 ("scripts/dtc: Export YYLOC global declaration") Reported-by: kernel test robot <lkp(a)intel.com&gt; Signed-off-by: kernel test robot <lkp(a)intel.com&gt; --- tree: https://android.googlesource.com/kernel/goldfish android-3.18 head: dd54b61f1458c03f68fc019b4874d98f2f0ae3a5 commit: 8214bf079208b146e63cd0a3ce0ed335a87ce7b3 [396/1051] scripts/dtc: Export YYLOC global declaration :::::: branch date: 5 weeks ago :::::: commit date: 3 months ago Please take the patch only if it's a positive warning. Thanks! aops.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/fs/ntfs/aops.c +++ b/fs/ntfs/aops.c @@ -1194,8 +1194,7 @@ lock_retry_remap: tbh = bhs[i]; if (!tbh) continue; - if (!trylock_buffer(tbh)) - BUG(); + BUG_ON(!trylock_buffer(tbh)); /* The buffer dirty state is now irrelevant, just clean it. */ clear_buffer_dirty(tbh); BUG_ON(!buffer_uptodate(tbh));