[kbuild-all] drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: error: format string is not a string literal (potentially insecure)

Hi Chris, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 88fe49249c99de14e543c632a46248d85411ab9e commit: 70a2b431c36483c0c06e589e11c59e438cd0ac06 drm/i915/gt: Rename lrc.c to execlists_submission.c date: 3 months ago config: x86_64-randconfig-r034-20210314 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project dfd27ebbd0eb137c9a439b7c537bb87ba903efd3) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit... git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout 70a2b431c36483c0c06e589e11c59e438cd0ac06 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116: GEM_TRACE("spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:167:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116: drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("lo spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:1790:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ In file included from drivers/gpu/drm/i915/gt/intel_execlists_submission.c:6116: drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] GEM_TRACE("hi spinner failed to start\n"); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^~~~~~~~~~~~~~~~ drivers/gpu/drm/i915/gt/selftest_execlists.c:1807:4: note: treat the string as an argument to avoid this drivers/gpu/drm/i915/i915_gem.h:69:24: note: expanded from macro 'GEM_TRACE' #define GEM_TRACE(...) trace_printk(__VA_ARGS__) ^ include/linux/kernel.h:724:3: note: expanded from macro 'trace_printk' do_trace_printk(fmt, ##__VA_ARGS__); \ ^ include/linux/kernel.h:738:30: note: expanded from macro 'do_trace_printk' __trace_bprintk(_THIS_IP_, trace_printk_fmt, ##args); \ ^ 3 errors generated. vim +167 drivers/gpu/drm/i915/gt/selftest_execlists.c 280e285dc78f73 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2020-02-27 134 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 135 static int live_sanitycheck(void *arg) 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 136 { 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 137 struct intel_gt *gt = arg; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 138 struct intel_engine_cs *engine; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 139 enum intel_engine_id id; 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 140 struct igt_spinner spin; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 141 int err = 0; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 142 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 143 if (!HAS_LOGICAL_RING_CONTEXTS(gt->i915)) 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 144 return 0; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 145 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 146 if (igt_spinner_init(&spin, gt)) 2af402982ab382 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-04 147 return -ENOMEM; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 148 e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 149 for_each_engine(engine, gt, id) { e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 150 struct intel_context *ce; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 151 struct i915_request *rq; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 152 e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 153 ce = intel_context_create(engine); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 154 if (IS_ERR(ce)) { e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 155 err = PTR_ERR(ce); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 156 break; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 157 } e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 158 f277bc0c98a407 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-07-31 159 rq = igt_spinner_create_request(&spin, ce, MI_NOOP); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 160 if (IS_ERR(rq)) { 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 161 err = PTR_ERR(rq); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 162 goto out_ctx; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 163 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 164 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 165 i915_request_add(rq); 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 166 if (!igt_wait_for_spinner(&spin, rq)) { 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 @167 GEM_TRACE("spinner failed to start\n"); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 168 GEM_TRACE_DUMP(); 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 169 intel_gt_set_wedged(gt); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 170 err = -EIO; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 171 goto out_ctx; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 172 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 173 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 174 igt_spinner_end(&spin); 1357fa8136ea03 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-10-16 175 if (igt_flush_test(gt->i915)) { 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 176 err = -EIO; e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 177 goto out_ctx; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 178 } e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 179 e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 180 out_ctx: e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 181 intel_context_put(ce); e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 182 if (err) e6ba76480299a0 drivers/gpu/drm/i915/gt/selftest_lrc.c Chris Wilson 2019-12-21 183 break; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 184 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 185 8d2f6e2f272109 drivers/gpu/drm/i915/selftests/intel_lrc.c Tvrtko Ursulin 2018-11-30 186 igt_spinner_fini(&spin); 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 187 return err; 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 188 } 2c66555ec19235 drivers/gpu/drm/i915/selftests/intel_lrc.c Chris Wilson 2018-04-04 189 :::::: The code at line 167 was first introduced by commit :::::: 2c66555ec19235efd689741c44bbeb893aa8e7de drm/i915/selftests: Add basic sanitychecks for execlists :::::: TO: Chris Wilson <chris(a)chris-wilson.co.uk&gt; :::::: CC: Chris Wilson <chris(a)chris-wilson.co.uk&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org