[kbuild-all] [intel-linux-intel-lts:5.4/yocto 39/9195] drivers/trusty/trusty.c:282:9: warning: no previous prototype for function 'trusty_version_show'

tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto head: 87241c08286384feb3ddc57d4cb0daca4be1e384 commit: 7e855c11a2297ad72d2952f075dd82640f3cd70a [39/9195] Modify Google's trusty drivers so as to support Intel platform config: x86_64-randconfig-r023-20200811 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 4f2ad15db535873dda9bfe248a2771023b64a43c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install x86_64 cross compiling tool for clang build # apt-get install binutils-x86-64-linux-gnu git checkout 7e855c11a2297ad72d2952f075dd82640f3cd70a # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): ssize_t trusty_version_show(struct device *dev, struct device_attribute *attr, ^ drivers/trusty/trusty.c:282:1: note: declare 'static' if the function is not intended to be used outside of this translation unit ssize_t trusty_version_show(struct device *dev, struct device_attribute *attr, ^ static void trusty_dev_release(struct device *dev) ^ drivers/trusty/trusty.c:439:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void trusty_dev_release(struct device *dev) ^ static 2 warnings generated. -- drivers/trusty/trusty-irq.c:214:13: warning: no previous prototype for function 'trusty_irq_handler' [-Wmissing-prototypes] irqreturn_t trusty_irq_handler(int irq, void *data) ^ drivers/trusty/trusty-irq.c:214:1: note: declare 'static' if the function is not intended to be used outside of this translation unit irqreturn_t trusty_irq_handler(int irq, void *data) ^ static drivers/trusty/trusty-irq.c:282:20: error: use of undeclared identifier 'CPU_TASKS_FROZEN' switch (action & ~CPU_TASKS_FROZEN) { ^ void trusty_irq_eoi(struct irq_data *data) ^ drivers/trusty/trusty-irq.c:394:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void trusty_irq_eoi(struct irq_data *data) ^ static drivers/trusty/trusty-irq.c:637:8: error: implicit declaration of function 'register_hotcpu_notifier' [-Werror,-Wimplicit-function-declaration] ret = register_hotcpu_notifier(&is->cpu_notifier); ^ drivers/trusty/trusty-irq.c:637:8: note: did you mean 'register_module_notifier'? include/linux/module.h:662:5: note: 'register_module_notifier' declared here int register_module_notifier(struct notifier_block *nb); ^ drivers/trusty/trusty-irq.c:642:6: error: assigning to 'int' from incompatible type 'void' ret = on_each_cpu(trusty_irq_cpu_up, is, 0); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/trusty/trusty-irq.c:651:2: error: implicit declaration of function 'unregister_hotcpu_notifier' [-Werror,-Wimplicit-function-declaration] unregister_hotcpu_notifier(&is->cpu_notifier); ^ drivers/trusty/trusty-irq.c:651:2: note: did you mean 'register_hotcpu_notifier'? drivers/trusty/trusty-irq.c:637:8: note: 'register_hotcpu_notifier' declared here ret = register_hotcpu_notifier(&is->cpu_notifier); ^ drivers/trusty/trusty-irq.c:687:2: error: implicit declaration of function 'unregister_hotcpu_notifier' [-Werror,-Wimplicit-function-declaration] unregister_hotcpu_notifier(&is->cpu_notifier); ^ drivers/trusty/trusty-irq.c:688:6: error: assigning to 'int' from incompatible type 'void' ret = on_each_cpu(trusty_irq_cpu_down, is, 1); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/trusty/trusty-irq.c:283:7: error: use of undeclared identifier 'CPU_STARTING' case CPU_STARTING: ^ drivers/trusty/trusty-irq.c:286:7: error: use of undeclared identifier 'CPU_DYING' case CPU_DYING: ^ 2 warnings and 8 errors generated. -- drivers/trusty/trusty-virtio.c:323:17: error: no member named 'reserved' in 'struct fw_rsc_vdev_vring' tvr->vr_descr->reserved = (u32)(pa >> 32); ~~~~~~~~~~~~~ ^ drivers/trusty/trusty-virtio.c:330:47: error: too few arguments to function call, expected 10, have 9 trusty_virtio_notify, callback, name); ^ include/linux/virtio_ring.h:94:19: note: 'vring_new_virtqueue' declared here struct virtqueue *vring_new_virtqueue(unsigned int index, ^ drivers/trusty/trusty-virtio.c:380:14: error: incompatible function pointer types initializing 'int (*)(struct virtio_device *, unsigned int, struct virtqueue **, vq_callback_t **, const char *const *, const bool *, struct irq_affinity *)' (aka 'int (*)(struct virtio_device *, unsigned int, struct virtqueue **, void (**)(struct virtqueue *), const char *const *, const _Bool *, struct irq_affinity *)') with an expression of type 'int (struct virtio_device *, unsigned int, struct virtqueue **, vq_callback_t **, const char **)' (aka 'int (struct virtio_device *, unsigned int, struct virtqueue **, void (**)(struct virtqueue *), const char **)') [-Werror,-Wincompatible-function-pointer-types] .find_vqs = trusty_virtio_find_vqs, ^~~~~~~~~~~~~~~~~~~~~~ void virtio_vdev_release(struct device *dev) ^ drivers/trusty/trusty-virtio.c:385:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void virtio_vdev_release(struct device *dev) ^ static 1 warning and 3 errors generated. vim +/trusty_version_show +282 drivers/trusty/trusty.c 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 281 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 @282 ssize_t trusty_version_show(struct device *dev, struct device_attribute *attr, 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 283 char *buf) 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 284 { 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 285 struct trusty_state *s = platform_get_drvdata(to_platform_device(dev)); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 286 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 287 return scnprintf(buf, PAGE_SIZE, "%s\n", s->version_str); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 288 } 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 289 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 290 DEVICE_ATTR(trusty_version, S_IRUSR, trusty_version_show, NULL); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 291 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 292 const char *trusty_version_str_get(struct device *dev) 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 293 { 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 294 struct trusty_state *s = platform_get_drvdata(to_platform_device(dev)); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 295 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 296 return s->version_str; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 297 } 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 298 EXPORT_SYMBOL(trusty_version_str_get); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 299 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 300 static void trusty_init_version(struct trusty_state *s, struct device *dev) 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 301 { 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 302 int ret; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 303 int i; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 304 int version_str_len; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 305 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 306 ret = trusty_fast_call32(dev, SMC_FC_GET_VERSION_STR, -1, 0, 0); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 307 if (ret <= 0) 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 308 goto err_get_size; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 309 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 310 version_str_len = ret; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 311 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 312 s->version_str = kmalloc(version_str_len + 1, GFP_KERNEL); 7e855c11a2297a weideng 2016-10-28 313 if (!s->version_str) 7e855c11a2297a weideng 2016-10-28 314 goto err_get_size; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 315 for (i = 0; i < version_str_len; i++) { 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 316 ret = trusty_fast_call32(dev, SMC_FC_GET_VERSION_STR, i, 0, 0); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 317 if (ret < 0) 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 318 goto err_get_char; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 319 s->version_str[i] = ret; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 320 } 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 321 s->version_str[i] = '\0'; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 322 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 323 dev_info(dev, "trusty version: %s\n", s->version_str); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 324 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 325 ret = device_create_file(dev, &dev_attr_trusty_version); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 326 if (ret) 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 327 goto err_create_file; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 328 return; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 329 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 330 err_create_file: 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 331 err_get_char: 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 332 kfree(s->version_str); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 333 s->version_str = NULL; 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 334 err_get_size: 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 335 dev_err(dev, "failed to get version: %d\n", ret); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 336 } 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 337 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 338 u32 trusty_get_api_version(struct device *dev) f734a5b21364b1 Arve Hjønnevåg 2015-06-11 339 { f734a5b21364b1 Arve Hjønnevåg 2015-06-11 340 struct trusty_state *s = platform_get_drvdata(to_platform_device(dev)); f734a5b21364b1 Arve Hjønnevåg 2015-06-11 341 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 342 return s->api_version; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 343 } f734a5b21364b1 Arve Hjønnevåg 2015-06-11 344 EXPORT_SYMBOL(trusty_get_api_version); f734a5b21364b1 Arve Hjønnevåg 2015-06-11 345 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 346 static int trusty_init_api_version(struct trusty_state *s, struct device *dev) f734a5b21364b1 Arve Hjønnevåg 2015-06-11 347 { f734a5b21364b1 Arve Hjønnevåg 2015-06-11 348 u32 api_version; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 349 api_version = trusty_fast_call32(dev, SMC_FC_API_VERSION, f734a5b21364b1 Arve Hjønnevåg 2015-06-11 350 TRUSTY_API_VERSION_CURRENT, 0, 0); f734a5b21364b1 Arve Hjønnevåg 2015-06-11 351 if (api_version == SM_ERR_UNDEFINED_SMC) f734a5b21364b1 Arve Hjønnevåg 2015-06-11 352 api_version = 0; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 353 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 354 if (api_version > TRUSTY_API_VERSION_CURRENT) { f734a5b21364b1 Arve Hjønnevåg 2015-06-11 355 dev_err(dev, "unsupported api version %u > %u\n", f734a5b21364b1 Arve Hjønnevåg 2015-06-11 356 api_version, TRUSTY_API_VERSION_CURRENT); f734a5b21364b1 Arve Hjønnevåg 2015-06-11 357 return -EINVAL; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 358 } f734a5b21364b1 Arve Hjønnevåg 2015-06-11 359 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 360 dev_info(dev, "selected api version: %u (requested %u)\n", f734a5b21364b1 Arve Hjønnevåg 2015-06-11 361 api_version, TRUSTY_API_VERSION_CURRENT); f734a5b21364b1 Arve Hjønnevåg 2015-06-11 362 s->api_version = api_version; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 363 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 364 return 0; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 365 } f734a5b21364b1 Arve Hjønnevåg 2015-06-11 366 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 367 static int trusty_probe(struct platform_device *pdev) 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 368 { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 369 int ret; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 370 struct trusty_state *s; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 371 struct device_node *node = pdev->dev.of_node; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 372 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 373 if (!node) { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 374 dev_err(&pdev->dev, "of_node required\n"); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 375 return -EINVAL; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 376 } 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 377 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 378 s = kzalloc(sizeof(*s), GFP_KERNEL); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 379 if (!s) { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 380 ret = -ENOMEM; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 381 goto err_allocate_state; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 382 } 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 383 mutex_init(&s->smc_lock); 0bead160edaa03 Arve Hjønnevåg 2016-05-05 384 ATOMIC_INIT_NOTIFIER_HEAD(&s->notifier); 2680cdd3b9cc6b Arve Hjønnevåg 2015-01-23 385 init_completion(&s->cpu_idle_completion); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 386 platform_set_drvdata(pdev, s); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 387 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 388 trusty_init_version(s, &pdev->dev); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 389 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 390 ret = trusty_init_api_version(s, &pdev->dev); f734a5b21364b1 Arve Hjønnevåg 2015-06-11 391 if (ret < 0) f734a5b21364b1 Arve Hjønnevåg 2015-06-11 392 goto err_api_version; f734a5b21364b1 Arve Hjønnevåg 2015-06-11 393 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 394 return 0; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 395 f734a5b21364b1 Arve Hjønnevåg 2015-06-11 396 err_api_version: 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 397 if (s->version_str) { 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 398 device_remove_file(&pdev->dev, &dev_attr_trusty_version); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 399 kfree(s->version_str); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 400 } 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 401 device_for_each_child(&pdev->dev, NULL, trusty_remove_child); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 402 mutex_destroy(&s->smc_lock); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 403 kfree(s); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 404 err_allocate_state: 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 405 return ret; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 406 } 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 407 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 408 static int trusty_remove(struct platform_device *pdev) 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 409 { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 410 struct trusty_state *s = platform_get_drvdata(pdev); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 411 7e855c11a2297a weideng 2016-10-28 412 dev_dbg(&(pdev->dev), "%s() is called\n", __func__); 7e855c11a2297a weideng 2016-10-28 413 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 414 device_for_each_child(&pdev->dev, NULL, trusty_remove_child); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 415 mutex_destroy(&s->smc_lock); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 416 if (s->version_str) { 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 417 device_remove_file(&pdev->dev, &dev_attr_trusty_version); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 418 kfree(s->version_str); 3db108326d2fe8 Arve Hjønnevåg 2014-10-09 419 } 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 420 kfree(s); 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 421 return 0; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 422 } 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 423 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 424 static const struct of_device_id trusty_of_match[] = { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 425 { .compatible = "android,trusty-smc-v1", }, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 426 {}, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 427 }; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 428 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 429 static struct platform_driver trusty_driver = { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 430 .probe = trusty_probe, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 431 .remove = trusty_remove, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 432 .driver = { 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 433 .name = "trusty", 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 434 .owner = THIS_MODULE, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 435 .of_match_table = trusty_of_match, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 436 }, 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 437 }; 86d0dcf35966f0 Arve Hjønnevåg 2013-11-18 438 7e855c11a2297a weideng 2016-10-28 @439 void trusty_dev_release(struct device *dev) 7e855c11a2297a weideng 2016-10-28 440 { 7e855c11a2297a weideng 2016-10-28 441 dev_dbg(dev, "%s() is called()\n", __func__); 7e855c11a2297a weideng 2016-10-28 442 return; 7e855c11a2297a weideng 2016-10-28 443 } 7e855c11a2297a weideng 2016-10-28 444 :::::: The code at line 282 was first introduced by commit :::::: 3db108326d2fe8a24470ecb267fb202ac09f663a trusty: Get version string from trusty :::::: TO: Arve Hjønnevåg <arve(a)android.com&gt; :::::: CC: Zhou Furong <furong.zhou(a)intel.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org