[kbuild-all] Re: [RFC Patch Resend 1/2] i2c debug counters as sysfs attributes

Hi Sui, [FYI, it's a private test report for your RFC patch.] [auto build test ERROR on wsa/i2c/for-next] [also build test ERROR on linux/master linus/master v5.15 next-20211111] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sui-Chen/I2C-statistics-as-sysfs... base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next config: openrisc-buildonly-randconfig-r003-20211111 (attached as .config) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/769ea06c7d8b5744deba5e6cfe2df6d90... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sui-Chen/I2C-statistics-as-sysfs-attributes/20211110-065938 git checkout 769ea06c7d8b5744deba5e6cfe2df6d9079b41df # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=openrisc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/i2c/i2c-dev.c: In function 'ber_cnt_show': 779 | ssize_t ret = sprintf(buf, "%llu\n", *ber_cnt); | ^~~~~~~ drivers/i2c/i2c-dev.c: At top level: 784 | ssize_t nack_cnt_show(struct device* pdev, | ^~~~~~~~~~~~~ drivers/i2c/i2c-dev.c: In function 'nack_cnt_show': drivers/i2c/i2c-dev.c:788:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 788 | ssize_t ret = sprintf(buf, "%llu\n", *nack_cnt); | ^~~~~~~ drivers/i2c/i2c-dev.c: At top level: 793 | ssize_t rec_succ_cnt_show(struct device* pdev, | ^~~~~~~~~~~~~~~~~ drivers/i2c/i2c-dev.c: In function 'rec_succ_cnt_show': drivers/i2c/i2c-dev.c:797:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 797 | ssize_t ret = sprintf(buf, "%llu\n", *rec_succ_cnt); | ^~~~~~~ drivers/i2c/i2c-dev.c: At top level: 802 | ssize_t rec_fail_cnt_show(struct device* pdev, | ^~~~~~~~~~~~~~~~~ drivers/i2c/i2c-dev.c: In function 'rec_fail_cnt_show': drivers/i2c/i2c-dev.c:806:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 806 | ssize_t ret = sprintf(buf, "%llu\n", *rec_fail_cnt); | ^~~~~~~ drivers/i2c/i2c-dev.c: At top level: 811 | ssize_t timeout_cnt_show(struct device* pdev, | ^~~~~~~~~~~~~~~~ drivers/i2c/i2c-dev.c: In function 'timeout_cnt_show': drivers/i2c/i2c-dev.c:815:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 815 | ssize_t ret = sprintf(buf, "%llu\n", *timeout_cnt); | ^~~~~~~ drivers/i2c/i2c-dev.c: At top level: 820 | ssize_t i2c_speed_show(struct device* pdev, | ^~~~~~~~~~~~~~ drivers/i2c/i2c-dev.c: In function 'i2c_speed_show': drivers/i2c/i2c-dev.c:824:9: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] 824 | ssize_t ret = sprintf(buf, "%llu\n", *i2c_speed); | ^~~~~~~ cc1: all warnings being treated as errors vim +779 drivers/i2c/i2c-dev.c 774 775 static ssize_t ber_cnt_show(struct device* pdev, 776 struct device_attribute* attr, char* buf) { 777 u64* ber_cnt = kobj_to_adapter(pdev)->stats->ber_cnt; 778 if (ber_cnt == NULL) return 0; 780 return ret; 781 } 782 DEVICE_ATTR_RO(ber_cnt); 783 785 struct device_attribute* attr, char* buf) { 786 u64* nack_cnt = kobj_to_adapter(pdev)->stats->nack_cnt; 787 if (nack_cnt == NULL) return 0; 788 ssize_t ret = sprintf(buf, "%llu\n", *nack_cnt); 789 return ret; 790 } 791 DEVICE_ATTR_RO(nack_cnt); 792 794 struct device_attribute* attr, char* buf) { 795 u64* rec_succ_cnt = kobj_to_adapter(pdev)->stats->rec_succ_cnt; 796 if (rec_succ_cnt == NULL) return 0; 797 ssize_t ret = sprintf(buf, "%llu\n", *rec_succ_cnt); 798 return ret; 799 } 800 DEVICE_ATTR_RO(rec_succ_cnt); 801 803 struct device_attribute* attr, char* buf) { 804 u64* rec_fail_cnt = kobj_to_adapter(pdev)->stats->rec_fail_cnt; 805 if (rec_fail_cnt == NULL) return 0; 806 ssize_t ret = sprintf(buf, "%llu\n", *rec_fail_cnt); 807 return ret; 808 } 809 DEVICE_ATTR_RO(rec_fail_cnt); 810 812 struct device_attribute* attr, char* buf) { 813 u64* timeout_cnt = kobj_to_adapter(pdev)->stats->timeout_cnt; 814 if (timeout_cnt == NULL) return 0; 815 ssize_t ret = sprintf(buf, "%llu\n", *timeout_cnt); 816 return ret; 817 } 818 DEVICE_ATTR_RO(timeout_cnt); 819 821 struct device_attribute* attr, char* buf) { 822 u64* i2c_speed = kobj_to_adapter(pdev)->stats->i2c_speed; 823 if (i2c_speed == NULL) return 0; 824 ssize_t ret = sprintf(buf, "%llu\n", *i2c_speed); 825 return ret; 826 } 827 DEVICE_ATTR_RO(i2c_speed); 828 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org