1:50 a.m.
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.10
head: 93e7d232f85b0d597f8e9884386b9e3d43cedd3a
commit: b192f39b07ce2cf4436dd6a18fb5e11da05fcff5 [9976/9999] UPSTREAM: drm/i915/tc: Fix
TypeC PHY connect/disconnect logic on ADL-P
config: i386-randconfig-m021-20220214
(https://download.01.org/0day-ci/archive/20220217/202202170550.Y6vQX0Fm-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/gpu/drm/i915/display/intel_ddi.c:4177 intel_ddi_encoder_destroy() warn: variable
dereferenced before check 'dig_port' (see line 4169)
vim +/dig_port +4177 drivers/gpu/drm/i915/display/intel_ddi.c
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4165
static void intel_ddi_encoder_destroy(struct drm_encoder *encoder)
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4166
{
cd7826aa85f1f30 drivers/gpu/drm/i915/display/intel_ddi.c Imre Deak 2021-05-26 4167
struct drm_i915_private *i915 = to_i915(encoder->dev);
b7d02c3a124d9be drivers/gpu/drm/i915/display/intel_ddi.c Ville Syrjälä 2019-12-04 4168
struct intel_digital_port *dig_port = enc_to_dig_port(to_intel_encoder(encoder));
b192f39b07ce2cf drivers/gpu/drm/i915/display/intel_ddi.c Imre Deak 2021-09-29 @4169
enum phy phy = intel_port_to_phy(i915, dig_port->base.port);
^^^^^^^^^^^^^^
Dereference
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4170
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4171
intel_dp_encoder_flush_work(encoder);
b192f39b07ce2cf drivers/gpu/drm/i915/display/intel_ddi.c Imre Deak 2021-09-29 4172
if (intel_phy_is_tc(i915, phy))
b192f39b07ce2cf drivers/gpu/drm/i915/display/intel_ddi.c Imre Deak 2021-09-29 4173
intel_tc_port_flush_work(dig_port);
cd7826aa85f1f30 drivers/gpu/drm/i915/display/intel_ddi.c Imre Deak 2021-05-26 4174
intel_display_power_flush_work(i915);
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4175
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4176
drm_encoder_cleanup(encoder);
41dcbc7513c69d3 drivers/gpu/drm/i915/display/intel_ddi.c Anshuman Gupta 2021-01-11 @4177
if (dig_port)
^^^^^^^^
Checked too late
41dcbc7513c69d3 drivers/gpu/drm/i915/display/intel_ddi.c Anshuman Gupta 2021-01-11 4178
kfree(dig_port->hdcp_port_data.streams);
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4179
kfree(dig_port);
f6bff60e927b2f1 drivers/gpu/drm/i915/intel_ddi.c Imre Deak 2018-12-14 4180
}
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org