10:45 p.m.
Hi Thomas,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20200813]
[cannot apply to drm-intel/for-linux-next linux-arm/drm-armada-devel
linux-arm/drm-armada-fixes v5.8]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/Convert-all-re...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
dc06fe51d26efc100ac74121607c01a454867c91
config: arc-allmodconfig (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/arm/malidp_planes.c: In function
'malidp_check_pages_threshold':
> drivers/gpu/drm/arm/malidp_planes.c:349:28: error: 'struct
drm_driver' has no member named 'gem_prime_get_sg_table'; did you mean
'gem_prime_import_sg_table'?
349 | sgt =
obj->dev->driver->gem_prime_get_sg_table(obj);
| ^~~~~~~~~~~~~~~~~~~~~~
| gem_prime_import_sg_table
vim +349 drivers/gpu/drm/arm/malidp_planes.c
1f23a56a46b81d Jamie Fox 2018-10-01 325
1f23a56a46b81d Jamie Fox 2018-10-01 326 /*
1f23a56a46b81d Jamie Fox 2018-10-01 327 * Check if the framebuffer is entirely made up
of pages at least pgsize in
1f23a56a46b81d Jamie Fox 2018-10-01 328 * size. Only a heuristic: assumes that each
scatterlist entry has been aligned
1f23a56a46b81d Jamie Fox 2018-10-01 329 * to the largest page size smaller than its
length and that the MMU maps to
1f23a56a46b81d Jamie Fox 2018-10-01 330 * the largest page size possible.
1f23a56a46b81d Jamie Fox 2018-10-01 331 */
1f23a56a46b81d Jamie Fox 2018-10-01 332 static bool malidp_check_pages_threshold(struct
malidp_plane_state *ms,
1f23a56a46b81d Jamie Fox 2018-10-01 333 u32 pgsize)
1f23a56a46b81d Jamie Fox 2018-10-01 334 {
1f23a56a46b81d Jamie Fox 2018-10-01 335 int i;
1f23a56a46b81d Jamie Fox 2018-10-01 336
1f23a56a46b81d Jamie Fox 2018-10-01 337 for (i = 0; i < ms->n_planes; i++) {
1f23a56a46b81d Jamie Fox 2018-10-01 338 struct drm_gem_object *obj;
1f23a56a46b81d Jamie Fox 2018-10-01 339 struct drm_gem_cma_object *cma_obj;
1f23a56a46b81d Jamie Fox 2018-10-01 340 struct sg_table *sgt;
1f23a56a46b81d Jamie Fox 2018-10-01 341 struct scatterlist *sgl;
1f23a56a46b81d Jamie Fox 2018-10-01 342
1f23a56a46b81d Jamie Fox 2018-10-01 343 obj = drm_gem_fb_get_obj(ms->base.fb, i);
1f23a56a46b81d Jamie Fox 2018-10-01 344 cma_obj = to_drm_gem_cma_obj(obj);
1f23a56a46b81d Jamie Fox 2018-10-01 345
1f23a56a46b81d Jamie Fox 2018-10-01 346 if (cma_obj->sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 347 sgt = cma_obj->sgt;
1f23a56a46b81d Jamie Fox 2018-10-01 348 else
1f23a56a46b81d Jamie Fox 2018-10-01 @349 sgt =
obj->dev->driver->gem_prime_get_sg_table(obj);
1f23a56a46b81d Jamie Fox 2018-10-01 350
1f23a56a46b81d Jamie Fox 2018-10-01 351 if (!sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 352 return false;
1f23a56a46b81d Jamie Fox 2018-10-01 353
1f23a56a46b81d Jamie Fox 2018-10-01 354 sgl = sgt->sgl;
1f23a56a46b81d Jamie Fox 2018-10-01 355
1f23a56a46b81d Jamie Fox 2018-10-01 356 while (sgl) {
1f23a56a46b81d Jamie Fox 2018-10-01 357 if (sgl->length < pgsize) {
1f23a56a46b81d Jamie Fox 2018-10-01 358 if (!cma_obj->sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 359 kfree(sgt);
1f23a56a46b81d Jamie Fox 2018-10-01 360 return false;
1f23a56a46b81d Jamie Fox 2018-10-01 361 }
1f23a56a46b81d Jamie Fox 2018-10-01 362
1f23a56a46b81d Jamie Fox 2018-10-01 363 sgl = sg_next(sgl);
1f23a56a46b81d Jamie Fox 2018-10-01 364 }
1f23a56a46b81d Jamie Fox 2018-10-01 365 if (!cma_obj->sgt)
1f23a56a46b81d Jamie Fox 2018-10-01 366 kfree(sgt);
1f23a56a46b81d Jamie Fox 2018-10-01 367 }
1f23a56a46b81d Jamie Fox 2018-10-01 368
1f23a56a46b81d Jamie Fox 2018-10-01 369 return true;
1f23a56a46b81d Jamie Fox 2018-10-01 370 }
1f23a56a46b81d Jamie Fox 2018-10-01 371
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org