[kbuild-all] Re: [PATCH v2 2/4] iwlwifi: integrate with iwlmei

Hi Emmanuel, Thank you for the patch! Yet something to improve: [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on wireless-drivers/master mac80211-next/master mac80211/master v5.13-rc7 next-20210618] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Emmanuel-Grumbach/iwlwifi-mei-ad... base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-ne... master config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/6d71c3e1548b6ebe15ecb36efcbac1516... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Emmanuel-Grumbach/iwlwifi-mei-add-the-driver-to-allow-cooperation-with-CSME/20210621-160318 git checkout 6d71c3e1548b6ebe15ecb36efcbac1516d170f46 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All errors (new ones prefixed by >>): drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c: In function 'iwl_parse_mei_nvm_data': 1117 | iwl_init_sbands(trans, data, mei_nvm->channels, tx_chains, rx_chains, | ^~~~~~~~~~~~~~~ drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c:797:13: note: declared here 797 | static void iwl_init_sbands(struct iwl_trans *trans, | ^~~~~~~~~~~~~~~ vim +/iwl_init_sbands +1117 drivers/net/wireless/intel/iwlwifi/iwl-nvm-parse.c 1063 1064 struct iwl_nvm_data * 1065 iwl_parse_mei_nvm_data(struct iwl_trans *trans, const struct iwl_cfg *cfg, 1066 const struct iwl_mei_nvm *mei_nvm, 1067 const struct iwl_fw *fw) 1068 { 1069 struct iwl_nvm_data *data; 1070 u32 sbands_flags = 0; 1071 u8 rx_chains = fw->valid_rx_ant; 1072 u8 tx_chains = fw->valid_rx_ant; 1073 1074 if (cfg->uhb_supported) 1075 data = kzalloc(struct_size(data, channels, 1076 IWL_NVM_NUM_CHANNELS_UHB), 1077 GFP_KERNEL); 1078 else 1079 data = kzalloc(struct_size(data, channels, 1080 IWL_NVM_NUM_CHANNELS_EXT), 1081 GFP_KERNEL); 1082 if (!data) 1083 return NULL; 1084 1085 BUILD_BUG_ON(ARRAY_SIZE(mei_nvm->channels) != 1086 IWL_NVM_NUM_CHANNELS_UHB); 1087 data->nvm_version = mei_nvm->nvm_version; 1088 1089 iwl_set_radio_cfg(cfg, data, mei_nvm->radio_cfg); 1090 if (data->valid_tx_ant) 1091 tx_chains &= data->valid_tx_ant; 1092 if (data->valid_rx_ant) 1093 rx_chains &= data->valid_rx_ant; 1094 1095 data->sku_cap_mimo_disabled = false; 1096 data->sku_cap_band_24ghz_enable = true; 1097 data->sku_cap_band_52ghz_enable = true; 1098 data->sku_cap_11n_enable = 1099 !(iwlwifi_mod_params.disable_11n & IWL_DISABLE_HT_ALL); 1100 data->sku_cap_11ac_enable = true; 1101 data->sku_cap_11ax_enable = 1102 mei_nvm->caps & MEI_NVM_CAPS_11AX_SUPPORT; 1103 1104 data->lar_enabled = mei_nvm->caps & MEI_NVM_CAPS_LARI_SUPPORT; 1105 1106 data->n_hw_addrs = mei_nvm->n_hw_addrs; 1107 /* If no valid mac address was found - bail out */ 1108 if (iwl_set_hw_address(trans, cfg, data, NULL, NULL)) { 1109 kfree(data); 1110 return NULL; 1111 } 1112 1113 if (data->lar_enabled && 1114 fw_has_capa(&fw->ucode_capa, IWL_UCODE_TLV_CAPA_LAR_SUPPORT)) 1115 sbands_flags |= IWL_NVM_SBANDS_FLAGS_LAR; 1116 1118 sbands_flags, true, fw); 1119 1120 return data; 1121 } 1122 IWL_EXPORT_SYMBOL(iwl_parse_mei_nvm_data); 1123 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org