4:28 a.m.
Hi Jan,
I love your patch! Yet something to improve:
[auto build test ERROR on ext4/dev]
[also build test ERROR on ext3/for_next v5.8-rc4 next-20200709]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Jan-Kara/ext4-don-t-BUG-on-incon...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
config: arm-at91_dt_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/ext4/super.c: In function 'ext4_fill_super':
> fs/ext4/super.c:4736:4: error: label 'failed_mount8' used
but not defined
4736 | goto failed_mount8;
| ^~~~
fs/ext4/super.c: In function 'ext4_remount':
fs/ext4/super.c:5430:6: warning: variable 'enable_quota' set but not used
[-Wunused-but-set-variable]
5430 | int enable_quota = 0;
| ^~~~~~~~~~~~
vim +/failed_mount8 +4736 fs/ext4/super.c
4728
4729 EXT4_SB(sb)->s_mount_state |= EXT4_ORPHAN_FS;
4730 ext4_orphan_cleanup(sb, es);
4731 EXT4_SB(sb)->s_mount_state &= ~EXT4_ORPHAN_FS;
4732 if (needs_recovery) {
4733 ext4_msg(sb, KERN_INFO, "recovery complete");
4734 err = ext4_mark_recovery_complete(sb, es);
4735 if (err)
4736 goto failed_mount8;
4737 }
4738 if (EXT4_SB(sb)->s_journal) {
4739 if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_JOURNAL_DATA)
4740 descr = " journalled data mode";
4741 else if (test_opt(sb, DATA_FLAGS) == EXT4_MOUNT_ORDERED_DATA)
4742 descr = " ordered data mode";
4743 else
4744 descr = " writeback data mode";
4745 } else
4746 descr = "out journal";
4747
4748 if (test_opt(sb, DISCARD)) {
4749 struct request_queue *q = bdev_get_queue(sb->s_bdev);
4750 if (!blk_queue_discard(q))
4751 ext4_msg(sb, KERN_WARNING,
4752 "mounting with \"discard\" option, but "
4753 "the device does not support discard");
4754 }
4755
4756 if (___ratelimit(&ext4_mount_msg_ratelimit, "EXT4-fs mount"))
4757 ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
4758 "Opts: %.*s%s%s", descr,
4759 (int) sizeof(sbi->s_es->s_mount_opts),
4760 sbi->s_es->s_mount_opts,
4761 *sbi->s_es->s_mount_opts ? "; " : "", orig_data);
4762
4763 if (es->s_error_count)
4764 mod_timer(&sbi->s_err_report, jiffies + 300*HZ); /* 5 minutes */
4765
4766 /* Enable message ratelimiting. Default is 10 messages per 5 secs. */
4767 ratelimit_state_init(&sbi->s_err_ratelimit_state, 5 * HZ, 10);
4768 ratelimit_state_init(&sbi->s_warning_ratelimit_state, 5 * HZ, 10);
4769 ratelimit_state_init(&sbi->s_msg_ratelimit_state, 5 * HZ, 10);
4770
4771 kfree(orig_data);
4772 return 0;
4773
4774 cantfind_ext4:
4775 if (!silent)
4776 ext4_msg(sb, KERN_ERR, "VFS: Can't find ext4 filesystem");
4777 goto failed_mount;
4778
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org