Hi Baolin,
I love your patch! Perhaps something to improve:
[auto build test WARNING on iommu/next]
[also build test WARNING on soc/for-next linus/master v5.7 next-20200605]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Baolin-Wang/Some-improvements-fo...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: i386-randconfig-s001-20200608 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-247-gcadbd124-dirty
# save the attached .config to linux build tree
make W=1 C=1 ARCH=i386 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
> drivers/iommu/io-pgtable-arm-v7s.c:922:29: sparse: sparse: not
enough arguments for function map
drivers/iommu/io-pgtable-arm-v7s.c:929:30:
sparse: sparse: not enough arguments for function map
drivers/iommu/io-pgtable-arm-v7s.c:949:29: sparse: sparse: not enough arguments for
function map
drivers/iommu/io-pgtable-arm-v7s.c:970:29: sparse: sparse: not enough arguments for
function map
#
https://github.com/0day-ci/linux/commit/6047fa5558b1fdb8d2d52c9807fd96022...
git remote add linux-review
https://github.com/0day-ci/linux
git remote update linux-review
git checkout 6047fa5558b1fdb8d2d52c9807fd960220478d3d
vim +922 drivers/iommu/io-pgtable-arm-v7s.c
e5fc9753b1a831 Robin Murphy 2016-01-26 878
e5fc9753b1a831 Robin Murphy 2016-01-26 879 static int __init arm_v7s_do_selftests(void)
e5fc9753b1a831 Robin Murphy 2016-01-26 880 {
e5fc9753b1a831 Robin Murphy 2016-01-26 881 struct io_pgtable_ops *ops;
e5fc9753b1a831 Robin Murphy 2016-01-26 882 struct io_pgtable_cfg cfg = {
e5fc9753b1a831 Robin Murphy 2016-01-26 883 .tlb = &dummy_tlb_ops,
e5fc9753b1a831 Robin Murphy 2016-01-26 884 .oas = 32,
e5fc9753b1a831 Robin Murphy 2016-01-26 885 .ias = 32,
4f41845b340783 Will Deacon 2019-06-25 886 .coherent_walk = true,
4f41845b340783 Will Deacon 2019-06-25 887 .quirks = IO_PGTABLE_QUIRK_ARM_NS,
e5fc9753b1a831 Robin Murphy 2016-01-26 888 .pgsize_bitmap = SZ_4K | SZ_64K | SZ_1M |
SZ_16M,
e5fc9753b1a831 Robin Murphy 2016-01-26 889 };
e5fc9753b1a831 Robin Murphy 2016-01-26 890 unsigned int iova, size, iova_start;
e5fc9753b1a831 Robin Murphy 2016-01-26 891 unsigned int i, loopnr = 0;
e5fc9753b1a831 Robin Murphy 2016-01-26 892
e5fc9753b1a831 Robin Murphy 2016-01-26 893 selftest_running = true;
e5fc9753b1a831 Robin Murphy 2016-01-26 894
e5fc9753b1a831 Robin Murphy 2016-01-26 895 cfg_cookie = &cfg;
e5fc9753b1a831 Robin Murphy 2016-01-26 896
e5fc9753b1a831 Robin Murphy 2016-01-26 897 ops = alloc_io_pgtable_ops(ARM_V7S,
&cfg, &cfg);
e5fc9753b1a831 Robin Murphy 2016-01-26 898 if (!ops) {
e5fc9753b1a831 Robin Murphy 2016-01-26 899 pr_err("selftest: failed to allocate
io pgtable ops\n");
e5fc9753b1a831 Robin Murphy 2016-01-26 900 return -EINVAL;
e5fc9753b1a831 Robin Murphy 2016-01-26 901 }
e5fc9753b1a831 Robin Murphy 2016-01-26 902
e5fc9753b1a831 Robin Murphy 2016-01-26 903 /*
e5fc9753b1a831 Robin Murphy 2016-01-26 904 * Initial sanity checks.
e5fc9753b1a831 Robin Murphy 2016-01-26 905 * Empty page tables shouldn't provide
any translations.
e5fc9753b1a831 Robin Murphy 2016-01-26 906 */
e5fc9753b1a831 Robin Murphy 2016-01-26 907 if (ops->iova_to_phys(ops, 42))
e5fc9753b1a831 Robin Murphy 2016-01-26 908 return __FAIL(ops);
e5fc9753b1a831 Robin Murphy 2016-01-26 909
e5fc9753b1a831 Robin Murphy 2016-01-26 910 if (ops->iova_to_phys(ops, SZ_1G + 42))
e5fc9753b1a831 Robin Murphy 2016-01-26 911 return __FAIL(ops);
e5fc9753b1a831 Robin Murphy 2016-01-26 912
e5fc9753b1a831 Robin Murphy 2016-01-26 913 if (ops->iova_to_phys(ops, SZ_2G + 42))
e5fc9753b1a831 Robin Murphy 2016-01-26 914 return __FAIL(ops);
e5fc9753b1a831 Robin Murphy 2016-01-26 915
e5fc9753b1a831 Robin Murphy 2016-01-26 916 /*
e5fc9753b1a831 Robin Murphy 2016-01-26 917 * Distinct mappings of different granule
sizes.
e5fc9753b1a831 Robin Murphy 2016-01-26 918 */
e5fc9753b1a831 Robin Murphy 2016-01-26 919 iova = 0;
4ae8a5c528c0b1 Kefeng Wang 2016-09-21 920 for_each_set_bit(i, &cfg.pgsize_bitmap,
BITS_PER_LONG) {
e5fc9753b1a831 Robin Murphy 2016-01-26 921 size = 1UL << i;
e5fc9753b1a831 Robin Murphy 2016-01-26 @922 if (ops->map(ops, iova, iova, size,
IOMMU_READ |
:::::: The code at line 922 was first introduced by commit
:::::: e5fc9753b1a831466be9b45d0bf926eeaa8b84a0 iommu/io-pgtable: Add ARMv7 short
descriptor support
:::::: TO: Robin Murphy <robin.murphy(a)arm.com>
:::::: CC: Will Deacon <will.deacon(a)arm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org