[kbuild-all] Re: [linux-next:master 10767/11658] drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: sparse: incorrect type in argument 1 (different address spaces)

On 2/18/21 11:55 AM, kernel test robot wrote: Greg, should I fix my patch? Pritthijit Nath <pritthijit.nath at icloud.com> has already made a fix for this warning: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2021-Fe... > > "sparse warnings: (new ones prefixed by >>)" >>> drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void const [noderef] __user * @@ got char *[usertype] data @@ > drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: expected void const [noderef] __user * > drivers/staging/wlan-ng/p80211netdev.c:572:33: sparse: got char *[usertype] data > > vim +572 drivers/staging/wlan-ng/p80211netdev.c > > 557 > 558 /* Test the magic, assume ifr is good if it's there */ > 559 if (req->magic != P80211_IOCTL_MAGIC) { > 560 result = -EINVAL; > 561 goto bail; > 562 } > 563 > 564 if (cmd == P80211_IFTEST) { > 565 result = 0; > 566 goto bail; > 567 } else if (cmd != P80211_IFREQ) { > 568 result = -EINVAL; > 569 goto bail; > 570 } > 571 > > 572 msgbuf = memdup_user(req->data, req->len); > 573 if (IS_ERR(msgbuf)) { > 574 result = PTR_ERR(msgbuf); > 575 goto bail; > 576 } > 577 > 578 result = p80211req_dorequest(wlandev, msgbuf); > 579 > 580 if (result == 0) { > 581 if (copy_to_user > 582 ((void __user *)req->data, msgbuf, req->len)) { > 583 result = -EFAULT; > 584 } > 585 } > 586 kfree(msgbuf); > 587 > 588 bail: > 589 /* If allocate,copyfrom or copyto fails, return errno */ > 590 return result; > 591 } > 592 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org >