[kbuild-all] Re: [PATCH v15 02/17] block: Add bio_for_each_folio_all()

Hi "Matthew, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.14-rc2 next-20210720] [cannot apply to xfs-linux/for-next block/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox-Oracle/Folio-supp... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 2734d6c1b1a089fb593ef6a23d4b70903526fe0c config: i386-tinyconfig (attached as .config) compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/d611eec3f37483e1acbcc299bf47e9297... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Matthew-Wilcox-Oracle/Folio-support-in-block-iomap-layers/20210720-152323 git checkout d611eec3f37483e1acbcc299bf47e929766afc8d # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/bio.h: In function 'bio_first_folio': 338 | fi->folio = page_folio(bvec->bv_page); | ^~~~~~~~~~ 338 | fi->folio = page_folio(bvec->bv_page); | ^ 340 | PAGE_SIZE * (bvec->bv_page - &fi->folio->page); | ^~ In file included from include/linux/kernel.h:16, from include/linux/crypto.h:16, from arch/x86/kernel/asm-offsets.c:9: 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~~~~~~~~ include/linux/minmax.h:20:21: note: in definition of macro '__typecheck' 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:342:15: note: in expansion of macro 'min' 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~ In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/bio.h: In function 'bio_next_folio': 350 | fi->folio = folio_next(fi->folio); | ^~~~~~~~~~ include/linux/bio.h:350:13: warning: assignment to 'struct folio *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 350 | fi->folio = folio_next(fi->folio); | ^ In file included from include/linux/kernel.h:16, from include/linux/crypto.h:16, from arch/x86/kernel/asm-offsets.c:9: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck' 26 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:352:16: note: in expansion of macro 'min' 352 | fi->length = min(folio_size(fi->folio), fi->_seg_count); | ^~~ cc1: some warnings being treated as errors -- In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/bio.h: In function 'bio_first_folio': 338 | fi->folio = page_folio(bvec->bv_page); | ^~~~~~~~~~ 338 | fi->folio = page_folio(bvec->bv_page); | ^ 340 | PAGE_SIZE * (bvec->bv_page - &fi->folio->page); | ^~ In file included from include/linux/kernel.h:16, from include/linux/crypto.h:16, from arch/x86/kernel/asm-offsets.c:9: 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~~~~~~~~ include/linux/minmax.h:20:21: note: in definition of macro '__typecheck' 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:342:15: note: in expansion of macro 'min' 342 | fi->length = min(folio_size(fi->folio) - fi->offset, fi->_seg_count); | ^~~ In file included from include/linux/blkdev.h:18, from include/linux/blk-cgroup.h:23, from include/linux/writeback.h:14, from include/linux/memcontrol.h:22, from include/linux/swap.h:9, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets.c:13: include/linux/bio.h: In function 'bio_next_folio': 350 | fi->folio = folio_next(fi->folio); | ^~~~~~~~~~ include/linux/bio.h:350:13: warning: assignment to 'struct folio *' from 'int' makes pointer from integer without a cast [-Wint-conversion] 350 | fi->folio = folio_next(fi->folio); | ^ In file included from include/linux/kernel.h:16, from include/linux/crypto.h:16, from arch/x86/kernel/asm-offsets.c:9: include/linux/minmax.h:20:28: warning: comparison of distinct pointer types lacks a cast 20 | (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) | ^~ include/linux/minmax.h:26:4: note: in expansion of macro '__typecheck' 26 | (__typecheck(x, y) && __no_side_effects(x, y)) | ^~~~~~~~~~~ include/linux/minmax.h:36:24: note: in expansion of macro '__safe_cmp' 36 | __builtin_choose_expr(__safe_cmp(x, y), \ | ^~~~~~~~~~ include/linux/minmax.h:45:19: note: in expansion of macro '__careful_cmp' 45 | #define min(x, y) __careful_cmp(x, y, <) | ^~~~~~~~~~~~~ include/linux/bio.h:352:16: note: in expansion of macro 'min' 352 | fi->length = min(folio_size(fi->folio), fi->_seg_count); | ^~~ cc1: some warnings being treated as errors make[2]: *** [scripts/Makefile.build:117: arch/x86/kernel/asm-offsets.s] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [Makefile:1213: prepare0] Error 2 make[1]: Target 'prepare' not remade because of errors. make: *** [Makefile:220: __sub-make] Error 2 make: Target 'prepare' not remade because of errors. vim +/page_folio +338 include/linux/bio.h 332 333 static inline 334 void bio_first_folio(struct folio_iter *fi, struct bio *bio, int i) 335 { 336 struct bio_vec *bvec = bio_first_bvec_all(bio) + i; 337 339 fi->offset = bvec->bv_offset + 341 fi->_seg_count = bvec->bv_len; 343 fi->_i = i; 344 } 345 346 static inline void bio_next_folio(struct folio_iter *fi, struct bio *bio) 347 { 348 fi->_seg_count -= fi->length; 349 if (fi->_seg_count) { 351 fi->offset = 0; 352 fi->length = min(folio_size(fi->folio), fi->_seg_count); 353 } else if (fi->_i + 1 < bio->bi_vcnt) { 354 bio_first_folio(fi, bio, fi->_i + 1); 355 } else { 356 fi->folio = NULL; 357 } 358 } 359 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org