Hi Cezary,
I love your patch! Yet something to improve:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on tiwai-sound/for-next linus/master v5.16-rc5 next-20211215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Cezary-Rojewski/ASoC-Intel-catpt...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: x86_64-buildonly-randconfig-r003-20211216
(
https://download.01.org/0day-ci/archive/20211217/202112171009.7QVDVnji-lk...)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
#
https://github.com/0day-ci/linux/commit/1ad5d0805b19369eabd9476253a94343f...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Cezary-Rojewski/ASoC-Intel-catpt-Dma-transfer-fix-and-couple/20211216-195950
git checkout 1ad5d0805b19369eabd9476253a94343fe09ce75
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash sound/soc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
> sound/soc/soc-acpi.c:34:1: error: redefinition of
'snd_soc_acpi_find_machine'
34 | snd_soc_acpi_find_machine(struct
snd_soc_acpi_mach *machines)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sound/soc/soc-acpi.c:9:
include/sound/soc-acpi.h:38:1: note: previous definition of
'snd_soc_acpi_find_machine' was here
38 | snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
sound/soc/soc-acpi.c: In function 'snd_soc_acpi_find_package':
> sound/soc/soc-acpi.c:64:6: error: implicit declaration of
function 'acpi_bus_get_device'; did you mean 'acpi_get_gpe_device'?
[-Werror=implicit-function-declaration]
64 | if (acpi_bus_get_device(handle,
&adev))
| ^~~~~~~~~~~~~~~~~~~
| acpi_get_gpe_device
> sound/soc/soc-acpi.c:67:10: error: dereferencing pointer to
incomplete type 'struct acpi_device'
67 | if (adev->status.present
&& adev->status.functional) {
| ^~
> sound/soc/soc-acpi.c:83:12: error: implicit declaration of
function 'acpi_extract_package' [-Werror=implicit-function-declaration]
83 | status = acpi_extract_package(myobj,
| ^~~~~~~~~~~~~~~~~~~~
sound/soc/soc-acpi.c: At top level:
> sound/soc/soc-acpi.c:98:6: error: redefinition of
'snd_soc_acpi_find_package_from_hid'
98 | bool
snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from sound/soc/soc-acpi.c:9:
include/sound/soc-acpi.h:44:1: note: previous definition of
'snd_soc_acpi_find_package_from_hid' was here
44 | snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/soc-acpi.c:112:27: error: redefinition of
'snd_soc_acpi_codec_list'
112 | struct snd_soc_acpi_mach
*snd_soc_acpi_codec_list(void *arg)
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from sound/soc/soc-acpi.c:9:
include/sound/soc-acpi.h:51:41: note: previous definition of
'snd_soc_acpi_codec_list' was here
51 | static inline struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/snd_soc_acpi_find_machine +34 sound/soc/soc-acpi.c
cafa39b650ec3ba sound/soc/soc-acpi.c Brent Lu 2021-10-30
32
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
33 struct snd_soc_acpi_mach *
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
@34 snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
95f098014815b33 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05
35 {
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
36 struct snd_soc_acpi_mach *mach;
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
37 struct snd_soc_acpi_mach *mach_alt;
95f098014815b33 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05
38
cafa39b650ec3ba sound/soc/soc-acpi.c Brent Lu 2021-10-30
39 for (mach = machines; mach->id[0] || mach->comp_ids; mach++) {
cafa39b650ec3ba sound/soc/soc-acpi.c Brent Lu 2021-10-30
40 if (snd_soc_acpi_id_present(mach)) {
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
41 if (mach->machine_quirk) {
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
42 mach_alt = mach->machine_quirk(mach);
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
43 if (!mach_alt)
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
44 continue; /* not full match, ignore */
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
45 mach = mach_alt;
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
46 }
a3e620f8422832a sound/soc/soc-acpi.c Keyon Jie 2018-11-16
47
7827d66946ad3af sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
48 return mach;
7827d66946ad3af sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
49 }
7827d66946ad3af sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
50 }
95f098014815b33 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05
51 return NULL;
95f098014815b33 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2015-11-05
52 }
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
53 EXPORT_SYMBOL_GPL(snd_soc_acpi_find_machine);
8ceffd229f0ef13 sound/soc/intel/common/sst-match-acpi.c Vinod Koul 2016-02-08
54
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
55 static acpi_status snd_soc_acpi_find_package(acpi_handle handle, u32 level,
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
56 void *context, void **ret)
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
57 {
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
58 struct acpi_device *adev;
59ce3233a538fc2 sound/soc/soc-acpi.c Pierre-Louis Bossart 2021-04-16
59 acpi_status status;
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
60 struct snd_soc_acpi_package_context *pkg_ctx = context;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
61
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
62 pkg_ctx->data_valid = false;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
63
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
@64 if (acpi_bus_get_device(handle, &adev))
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
65 return AE_OK;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
66
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
@67 if (adev->status.present && adev->status.functional) {
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
68 struct acpi_buffer buffer = {ACPI_ALLOCATE_BUFFER, NULL};
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
69 union acpi_object *myobj = NULL;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
70
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
71 status = acpi_evaluate_object_typed(handle, pkg_ctx->name,
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
72 NULL, &buffer,
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
73 ACPI_TYPE_PACKAGE);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
74 if (ACPI_FAILURE(status))
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
75 return AE_OK;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
76
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
77 myobj = buffer.pointer;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
78 if (!myobj || myobj->package.count != pkg_ctx->length) {
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
79 kfree(buffer.pointer);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
80 return AE_OK;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
81 }
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
82
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
@83 status = acpi_extract_package(myobj,
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
84 pkg_ctx->format, pkg_ctx->state);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
85 if (ACPI_FAILURE(status)) {
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
86 kfree(buffer.pointer);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
87 return AE_OK;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
88 }
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
89
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
90 kfree(buffer.pointer);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
91 pkg_ctx->data_valid = true;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
92 return AE_CTRL_TERMINATE;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
93 }
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
94
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
95 return AE_OK;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
96 }
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
97
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
@98 bool snd_soc_acpi_find_package_from_hid(const u8 hid[ACPI_ID_LEN],
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
99 struct snd_soc_acpi_package_context *ctx)
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
100 {
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
101 acpi_status status;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
102
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
103 status = acpi_get_devices(hid, snd_soc_acpi_find_package, ctx, NULL);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
104
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
105 if (ACPI_FAILURE(status) || !ctx->data_valid)
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
106 return false;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
107
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
108 return true;
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
109 }
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
110 EXPORT_SYMBOL_GPL(snd_soc_acpi_find_package_from_hid);
3421894765a345c sound/soc/intel/common/sst-match-acpi.c Pierre-Louis Bossart 2016-11-12
111
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
@112 struct snd_soc_acpi_mach *snd_soc_acpi_codec_list(void *arg)
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
113 {
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
114 struct snd_soc_acpi_mach *mach = arg;
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
115 struct snd_soc_acpi_codecs *codec_list =
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
116 (struct snd_soc_acpi_codecs *) mach->quirk_data;
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
117 int i;
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
118
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
119 if (mach->quirk_data == NULL)
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
120 return mach;
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
121
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
122 for (i = 0; i < codec_list->num_codecs; i++) {
0d5ea120abc020f sound/soc/soc-acpi.c Jeremy Cline 2018-01-05
123 if (!acpi_dev_present(codec_list->codecs[i], NULL, -1))
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
124 return NULL;
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
125 }
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
126
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
127 return mach;
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
128 }
7feb2f786a46d34 sound/soc/soc-acpi.c Pierre-Louis Bossart 2017-10-12
129 EXPORT_SYMBOL_GPL(snd_soc_acpi_codec_list);
54746dabf770eb2 sound/soc/intel/common/sst-match-acpi.c Naveen M 2017-05-15
130
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org