[kbuild-all] Re: [PATCH] printk: Make linux/printk.h self-contained

Hi Herbert, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on pmladek/for-next linux/master v5.7 next-20200611] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Herbert-Xu/printk-Make-linux-pri... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git b29482fde649c72441d5478a4ea2c52c56d97a5e config: s390-allyesconfig (attached as .config) compiler: s390-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>, old ones prefixed by <<): In file included from drivers/block/drbd/drbd_interval.c:2: 43 | #define BUG() do { | In file included from include/linux/bug.h:32, from include/linux/mmdebug.h:5, from arch/s390/include/asm/cmpxchg.h:11, from arch/s390/include/asm/atomic.h:16, from include/linux/atomic.h:7, from include/linux/debug_locks.h:6, from include/linux/lockdep.h:44, from include/linux/spinlock_types.h:18, from include/linux/ratelimit_types.h:7, from include/linux/printk.h:10, from include/linux/kernel.h:15, from arch/s390/include/asm/bug.h:5, from drivers/block/drbd/drbd_interval.c:2: include/asm-generic/bug.h:54: note: this is the location of the previous definition 54 | #define BUG() do { | In file included from drivers/block/drbd/drbd_interval.c:2: 52 | #define WARN_ON(x) ({ | In file included from include/linux/bug.h:32, from include/linux/mmdebug.h:5, from arch/s390/include/asm/cmpxchg.h:11, from arch/s390/include/asm/atomic.h:16, from include/linux/atomic.h:7, from include/linux/debug_locks.h:6, from include/linux/lockdep.h:44, from include/linux/spinlock_types.h:18, from include/linux/ratelimit_types.h:7, from include/linux/printk.h:10, from include/linux/kernel.h:15, from arch/s390/include/asm/bug.h:5, from drivers/block/drbd/drbd_interval.c:2: include/asm-generic/bug.h:112: note: this is the location of the previous definition 112 | #define WARN_ON(condition) ({ | vim +/BUG +43 arch/s390/include/asm/bug.h c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 42 2d6cd2a5908ade arch/s390/include/asm/bug.h Martin Schwidefsky 2008-12-25 @43 #define BUG() do { \ 2d6cd2a5908ade arch/s390/include/asm/bug.h Martin Schwidefsky 2008-12-25 44 __EMIT_BUG(0); \ 5506e68975c346 arch/s390/include/asm/bug.h David Daney 2009-12-04 45 unreachable(); \ 2d6cd2a5908ade arch/s390/include/asm/bug.h Martin Schwidefsky 2008-12-25 46 } while (0) c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 47 19d436268dde95 arch/s390/include/asm/bug.h Peter Zijlstra 2017-02-25 48 #define __WARN_FLAGS(flags) do { \ 19d436268dde95 arch/s390/include/asm/bug.h Peter Zijlstra 2017-02-25 49 __EMIT_BUG(BUGFLAG_WARNING|(flags)); \ a9df8e325d0de5 arch/s390/include/asm/bug.h Heiko Carstens 2010-01-13 50 } while (0) a9df8e325d0de5 arch/s390/include/asm/bug.h Heiko Carstens 2010-01-13 51 c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 @52 #define WARN_ON(x) ({ \ fd0cbdd378258f include/asm-s390/bug.h Heiko Carstens 2007-08-02 53 int __ret_warn_on = !!(x); \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 54 if (__builtin_constant_p(__ret_warn_on)) { \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 55 if (__ret_warn_on) \ b2be05273a1744 arch/s390/include/asm/bug.h Ben Hutchings 2010-04-03 56 __WARN(); \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 57 } else { \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 58 if (unlikely(__ret_warn_on)) \ b2be05273a1744 arch/s390/include/asm/bug.h Ben Hutchings 2010-04-03 59 __WARN(); \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 60 } \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 61 unlikely(__ret_warn_on); \ c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 62 }) c0007f1a65762e include/asm-s390/bug.h Heiko Carstens 2007-04-27 63 :::::: The code at line 43 was first introduced by commit :::::: 2d6cd2a5908adecd06c8cee2a73814463ed71493 [S390] remove warnings with functions ending in BUG :::::: TO: Martin Schwidefsky <schwidefsky(a)de.ibm.com&gt; :::::: CC: Martin Schwidefsky <schwidefsky(a)de.ibm.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org