4:31 a.m.
Hi Christoph,
I love your patch! Perhaps something to improve:
[auto build test WARNING on axboe-block/for-next]
[also build test WARNING on ceph-client/for-linus xen-tip/linux-next
device-mapper-dm/for-next linus/master v5.17-rc4 next-20220216]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/Christoph-Hellwig/block-fix-surp...
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: nds32-allnoconfig
(https://download.01.org/0day-ci/archive/20220217/202202170106.0gjJs3bN-lk...)
compiler: nds32le-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/97d6b5e4c96fcbf1dc26120c918dd1bac...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Christoph-Hellwig/block-fix-surprise-removal-for-drivers-calling-blk_set_queue_dying/20220216-231057
git checkout 97d6b5e4c96fcbf1dc26120c918dd1baca987188
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir
ARCH=nds32 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> block/blk-core.c:296: warning: expecting prototype for
blk_set_disk_dead(). Prototype was for blk_mark_disk_dead() instead
vim +296 block/blk-core.c
8e141f9eb803e20 Christoph Hellwig 2021-09-29 287
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 288 /**
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 289 * blk_set_disk_dead - mark a disk as
dead
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 290 * @disk: disk to mark as dead
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 291 *
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 292 * Mark as disk as dead (e.g. surprise
removed) and don't accept any new I/O
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 293 * to this disk.
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 294 */
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 295 void blk_mark_disk_dead(struct gendisk
*disk)
8e141f9eb803e20 Christoph Hellwig 2021-09-29 @296 {
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 297 set_bit(GD_DEAD,
&disk->state);
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 298
blk_queue_start_drain(disk->queue);
8e141f9eb803e20 Christoph Hellwig 2021-09-29 299 }
97d6b5e4c96fcbf Christoph Hellwig 2022-02-16 300 EXPORT_SYMBOL_GPL(blk_mark_disk_dead);
aed3ea94bdd2ac0 Jens Axboe 2014-12-22 301
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org