11:31 p.m.
Hi Chengguang,
url:
https://github.com/0day-ci/linux/commits/Chengguang-Xu/implement-containe...
base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
config: i386-randconfig-m021-20201011 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
fs/overlayfs/super.c:293 ovl_sync_fs() error: uninitialized symbol 'ret'.
vim +/ret +293 fs/overlayfs/super.c
e593b2bf513dd4d Amir Goldstein 2017-01-23 261 static int ovl_sync_fs(struct
super_block *sb, int wait)
e593b2bf513dd4d Amir Goldstein 2017-01-23 262 {
ad204488d3046b3 Miklos Szeredi 2017-11-10 263 struct ovl_fs *ofs =
sb->s_fs_info;
e593b2bf513dd4d Amir Goldstein 2017-01-23 264 struct super_block *upper_sb;
e593b2bf513dd4d Amir Goldstein 2017-01-23 265 int ret;
e593b2bf513dd4d Amir Goldstein 2017-01-23 266
08f4c7c86d4cf12 Miklos Szeredi 2020-06-04 267 if (!ovl_upper_mnt(ofs))
e593b2bf513dd4d Amir Goldstein 2017-01-23 268 return 0;
e8d4bfe3a715372 Chengguang Xu 2017-11-29 269
c86243b090bc25f Vivek Goyal 2020-08-31 270 if (!ovl_should_sync(ofs))
c86243b090bc25f Vivek Goyal 2020-08-31 271 return 0;
e8d4bfe3a715372 Chengguang Xu 2017-11-29 272 /*
32b1924b210a70d Konstantin Khlebnikov 2020-04-09 273 * Not called for sync(2) call or
an emergency sync (SB_I_SKIP_SYNC).
32b1924b210a70d Konstantin Khlebnikov 2020-04-09 274 * All the super blocks will be
iterated, including upper_sb.
e8d4bfe3a715372 Chengguang Xu 2017-11-29 275 *
e8d4bfe3a715372 Chengguang Xu 2017-11-29 276 * If this is a syncfs(2) call,
then we do need to call
e8d4bfe3a715372 Chengguang Xu 2017-11-29 277 * sync_filesystem() on upper_sb,
but enough if we do it when being
e8d4bfe3a715372 Chengguang Xu 2017-11-29 278 * called with wait == 1.
e8d4bfe3a715372 Chengguang Xu 2017-11-29 279 */
e8d4bfe3a715372 Chengguang Xu 2017-11-29 280 if (!wait)
e593b2bf513dd4d Amir Goldstein 2017-01-23 281 return 0;
e593b2bf513dd4d Amir Goldstein 2017-01-23 282
08f4c7c86d4cf12 Miklos Szeredi 2020-06-04 283 upper_sb =
ovl_upper_mnt(ofs)->mnt_sb;
e8d4bfe3a715372 Chengguang Xu 2017-11-29 284
12d938a37e0a31d Chengguang Xu 2020-10-10 285 if (upper_sb->s_op->sync_fs)
{
e593b2bf513dd4d Amir Goldstein 2017-01-23 286
down_read(&upper_sb->s_umount);
12d938a37e0a31d Chengguang Xu 2020-10-10 287 ret =
upper_sb->s_op->sync_fs(upper_sb, wait);
12d938a37e0a31d Chengguang Xu 2020-10-10 288 if (!ret)
12d938a37e0a31d Chengguang Xu 2020-10-10 289 ret =
sync_blockdev(upper_sb->s_bdev);
e593b2bf513dd4d Amir Goldstein 2017-01-23 290
up_read(&upper_sb->s_umount);
12d938a37e0a31d Chengguang Xu 2020-10-10 291 }
"ret" not initialized on else path.
e8d4bfe3a715372 Chengguang Xu 2017-11-29 292
e593b2bf513dd4d Amir Goldstein 2017-01-23 @293 return ret;
e593b2bf513dd4d Amir Goldstein 2017-01-23 294 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org