[kbuild-all] Re: [PATCH V2 XRT Alveo 6/6] fpga: xrt: Kconfig and Makefile updates for XRT drivers

Hi Sonal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on linus/master v5.10 next-20201217] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Sonal-Santan/XRT-Alveo-driver-ov... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 09162bc32c880a791c6c0668ce0745cf7958f576 config: i386-randconfig-r035-20201217 (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/3096c9b7caac1243afabb56e8b6c6f752... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Sonal-Santan/XRT-Alveo-driver-overview/20201217-160048 git checkout 3096c9b7caac1243afabb56e8b6c6f752cd1a0de # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): drivers/fpga/xrt/lib/xrt-main.c: In function 'xrt_subdev_register_external_driver': 158 | int result = 0; | ^~~~~~ -- 76 | int xrt_md_add_node(struct device *dev, char *blob, int parent_offset, | ^~~~~~~~~~~~~~~ -- drivers/fpga/xrt/lib/subdevs/xrt-icap.c: In function 'icap_probe_chip': 181 | u32 w; | ^ -- 55 | const static struct xmgmt_ocl_clockwiz { | ^~~~~ -- drivers/fpga/xrt/lib/subdevs/xrt-ucs.c: In function 'xrt_ucs_event_cb': 77 | struct xrt_ucs *ucs; | ^~~ -- 125 | int xrt_calib_remove(struct platform_device *pdev) | ^~~~~~~~~~~~~~~~ 141 | int xrt_calib_probe(struct platform_device *pdev) | ^~~~~~~~~~~~~~~ -- In file included from include/linux/device.h:15, from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14, from drivers/fpga/xrt/mgmt/xmgmt-main.c:13: drivers/fpga/xrt/mgmt/xmgmt-main.c: In function 'ulp_image_write': 187 | prt_fn(DEV(pdev), "%s %s: "fmt, \ | ^~~~~~~~~ include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' 19 | #define dev_fmt(fmt) fmt | ^~~ drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err' 187 | prt_fn(DEV(pdev), "%s %s: "fmt, \ | ^~~~~~ drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT' 189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args) | ^~~~~~~ drivers/fpga/xrt/mgmt/xmgmt-main.c:216:4: note: in expansion of macro 'xrt_err' 216 | xrt_err(xmm->pdev, "count is too small %ld", count); | ^~~~~~~ drivers/fpga/xrt/mgmt/xmgmt-main.c:216:45: note: format string is defined here 216 | xrt_err(xmm->pdev, "count is too small %ld", count); | ~~^ | | | long int | %d In file included from include/linux/device.h:15, from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14, from drivers/fpga/xrt/mgmt/xmgmt-main.c:13: drivers/fpga/xrt/mgmt/xmgmt-main.c: In function 'is_valid_firmware': 187 | prt_fn(DEV(pdev), "%s %s: "fmt, \ | ^~~~~~~~~ include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' 19 | #define dev_fmt(fmt) fmt | ^~~ drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err' 187 | prt_fn(DEV(pdev), "%s %s: "fmt, \ | ^~~~~~ drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT' 189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args) | ^~~~~~~ drivers/fpga/xrt/mgmt/xmgmt-main.c:370:3: note: in expansion of macro 'xrt_err' 370 | xrt_err(pdev, "truncated fw, length: %ld, expect: %ld", | ^~~~~~~ drivers/fpga/xrt/mgmt/xmgmt-main.c:370:42: note: format string is defined here 370 | xrt_err(pdev, "truncated fw, length: %ld, expect: %ld", | ~~^ | | | long int | %d In file included from include/linux/device.h:15, from drivers/fpga/xrt/mgmt/../common/xrt-xclbin.h:14, from drivers/fpga/xrt/mgmt/xmgmt-main.c:13: drivers/fpga/xrt/mgmt/../include/subdev.h:187:20: warning: format '%ld' expects argument of type 'long int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=] 187 | prt_fn(DEV(pdev), "%s %s: "fmt, \ | ^~~~~~~~~ include/linux/dev_printk.h:19:22: note: in definition of macro 'dev_fmt' 19 | #define dev_fmt(fmt) fmt | ^~~ drivers/fpga/xrt/mgmt/../include/subdev.h:187:2: note: in expansion of macro 'dev_err' 187 | prt_fn(DEV(pdev), "%s %s: "fmt, \ | ^~~~~~ drivers/fpga/xrt/mgmt/../include/subdev.h:189:37: note: in expansion of macro 'FMT_PRT' 189 | #define xrt_err(pdev, fmt, args...) FMT_PRT(dev_err, pdev, fmt, ##args) | ^~~~~~~ drivers/fpga/xrt/mgmt/xmgmt-main.c:370:3: note: in expansion of macro 'xrt_err' 370 | xrt_err(pdev, "truncated fw, length: %ld, expect: %ld", | ^~~~~~~ drivers/fpga/xrt/mgmt/xmgmt-main.c:370:55: note: format string is defined here 370 | xrt_err(pdev, "truncated fw, length: %ld, expect: %ld", | ~~^ | | | long int | %d In file included from drivers/fpga/xrt/mgmt/xmgmt-main.c:21: At top level: drivers/fpga/xrt/mgmt/../include/subdev/axigate.h:25:27: warning: 'xrt_axigate_epnames' defined but not used [-Wunused-const-variable=] 25 | static const char * const xrt_axigate_epnames[] = { | ^~~~~~~~~~~~~~~~~~~ -- 76 | int xrt_md_add_node(struct device *dev, char *blob, int parent_offset, | ^~~~~~~~~~~~~~~ vim +/result +158 drivers/fpga/xrt/lib/xrt-main.c 2039758de374ce7 Sonal Santan 2020-12-16 153 2039758de374ce7 Sonal Santan 2020-12-16 154 int xrt_subdev_register_external_driver(enum xrt_subdev_id id, 2039758de374ce7 Sonal Santan 2020-12-16 155 struct platform_driver *drv, struct xrt_subdev_endpoints *eps) 2039758de374ce7 Sonal Santan 2020-12-16 156 { 2039758de374ce7 Sonal Santan 2020-12-16 157 int i; 2039758de374ce7 Sonal Santan 2020-12-16 @158 int result = 0; 2039758de374ce7 Sonal Santan 2020-12-16 159 2039758de374ce7 Sonal Santan 2020-12-16 160 mutex_lock(&xrt_class_lock); 2039758de374ce7 Sonal Santan 2020-12-16 161 for (i = 0; i < ARRAY_SIZE(xrt_drv_maps); i++) { 2039758de374ce7 Sonal Santan 2020-12-16 162 struct xrt_drv_map *map = &xrt_drv_maps[i]; 2039758de374ce7 Sonal Santan 2020-12-16 163 2039758de374ce7 Sonal Santan 2020-12-16 164 if (map->id != id) 2039758de374ce7 Sonal Santan 2020-12-16 165 continue; 2039758de374ce7 Sonal Santan 2020-12-16 166 if (map->drv) { 2039758de374ce7 Sonal Santan 2020-12-16 167 result = -EEXIST; 2039758de374ce7 Sonal Santan 2020-12-16 168 pr_err("Id %d already has a registered driver, 0x%p\n", 2039758de374ce7 Sonal Santan 2020-12-16 169 id, map->drv); 2039758de374ce7 Sonal Santan 2020-12-16 170 break; 2039758de374ce7 Sonal Santan 2020-12-16 171 } 2039758de374ce7 Sonal Santan 2020-12-16 172 map->drv = drv; 2039758de374ce7 Sonal Santan 2020-12-16 173 BUG_ON(map->eps); 2039758de374ce7 Sonal Santan 2020-12-16 174 map->eps = eps; 2039758de374ce7 Sonal Santan 2020-12-16 175 xrt_drv_register_driver(id); 2039758de374ce7 Sonal Santan 2020-12-16 176 } 2039758de374ce7 Sonal Santan 2020-12-16 177 mutex_unlock(&xrt_class_lock); 2039758de374ce7 Sonal Santan 2020-12-16 178 return 0; 2039758de374ce7 Sonal Santan 2020-12-16 179 } 2039758de374ce7 Sonal Santan 2020-12-16 180 EXPORT_SYMBOL_GPL(xrt_subdev_register_external_driver); 2039758de374ce7 Sonal Santan 2020-12-16 181 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org