[kbuild-all] [jimc:dyn-drm-trc 20/21] drivers/gpu/drm/virtio/virtgpu_display.c:179:27: error: incompatible type for argument 2 of '___drm_dbg'

tree: https://github.com/jimc/linux.git dyn-drm-trc head: a78f403dcd7765c2691998346cffdd311310e1d0 commit: 13e0bac0f355292a71358b9a61022e9f4b1bcc43 [20/21] drm_print: add struct _ddebug desc to drm_*dbg config: openrisc-randconfig-r021-20220208 (https://download.01.org/0day-ci/archive/20220208/202202082222.IuhOFAb1-lk...) compiler: or1k-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/jimc/linux/commit/13e0bac0f355292a71358b9a61022e9f4b1b... git remote add jimc https://github.com/jimc/linux.git git fetch --no-tags jimc dyn-drm-trc git checkout 13e0bac0f355292a71358b9a61022e9f4b1bcc43 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/gpu/drm/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All error/warnings (new ones prefixed by >>): In file included from drivers/gpu/drm/drm_debugfs_crc.c:38: drivers/gpu/drm/drm_debugfs_crc.c: In function 'crc_control_write': include/drm/drm_print.h:580:19: warning: passing argument 1 of '___drm_dbg' makes pointer from integer without a cast [-Wint-conversion] 580 | __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__) | ^~~~~~~~~~ | | | int include/drm/drm_print.h:530:52: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/drm_debugfs_crc.c:134:17: note: in expansion of macro 'DRM_DEBUG_KMS' 134 | DRM_DEBUG_KMS("Expected < %lu bytes into crtc crc control\n", | ^~~~~~~~~~~~~ include/drm/drm_print.h:525:33: note: expected 'struct _ddebug *' but argument is of type 'int' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~^~~~ drivers/gpu/drm/drm_debugfs_crc.c:134:31: error: incompatible type for argument 2 of '___drm_dbg' 134 | DRM_DEBUG_KMS("Expected < %lu bytes into crtc crc control\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/drm_debugfs_crc.c:134:17: note: in expansion of macro 'DRM_DEBUG_KMS' 134 | DRM_DEBUG_KMS("Expected < %lu bytes into crtc crc control\n", | ^~~~~~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ In file included from arch/openrisc/include/asm/processor.h:19, from arch/openrisc/include/asm/thread_info.h:22, from include/linux/thread_info.h:60, from include/asm-generic/preempt.h:5, from ./arch/openrisc/include/generated/asm/preempt.h:1, from include/linux/preempt.h:78, from include/linux/spinlock.h:55, from include/linux/wait.h:9, from include/linux/wait_bit.h:8, from include/linux/fs.h:6, from include/linux/debugfs.h:15, from drivers/gpu/drm/drm_debugfs_crc.c:31: 25 | #define PAGE_SIZE (1UL << PAGE_SHIFT) | ^~~~~~~~~~~~~~~~~~~ | | | long unsigned int include/drm/drm_print.h:530:64: note: in expansion of macro 'PAGE_SIZE' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ include/drm/drm_print.h:580:9: note: in expansion of macro '__drm_dbg' 580 | __drm_dbg(DRM_UT_KMS, fmt, ##__VA_ARGS__) | ^~~~~~~~~ drivers/gpu/drm/drm_debugfs_crc.c:134:17: note: in expansion of macro 'DRM_DEBUG_KMS' 134 | DRM_DEBUG_KMS("Expected < %lu bytes into crtc crc control\n", | ^~~~~~~~~~~~~ In file included from drivers/gpu/drm/drm_debugfs_crc.c:38: include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'long unsigned int' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ -- In file included from include/drm/drm_mm.h:51, from include/drm/drm_vma_manager.h:26, from include/drm/drm_gem.h:40, from drivers/gpu/drm/virtio/virtgpu_drv.h:40, from drivers/gpu/drm/virtio/virtgpu_display.c:35: drivers/gpu/drm/virtio/virtgpu_display.c: In function 'virtio_gpu_conn_get_modes': 179 | DRM_DEBUG("add mode: %dx%d\n", width, height); | ^~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_display.c:179:17: note: in expansion of macro 'DRM_DEBUG' 179 | DRM_DEBUG("add mode: %dx%d\n", width, height); | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ 179 | DRM_DEBUG("add mode: %dx%d\n", width, height); | ^~~~~ | | | int include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_display.c:179:17: note: in expansion of macro 'DRM_DEBUG' 179 | DRM_DEBUG("add mode: %dx%d\n", width, height); | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'int' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ drivers/gpu/drm/virtio/virtgpu_display.c: In function 'virtio_gpu_conn_mode_valid': drivers/gpu/drm/virtio/virtgpu_display.c:208:19: error: incompatible type for argument 2 of '___drm_dbg' 208 | DRM_DEBUG("del mode: %dx%d\n", mode->hdisplay, mode->vdisplay); | ^~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_display.c:208:9: note: in expansion of macro 'DRM_DEBUG' 208 | DRM_DEBUG("del mode: %dx%d\n", mode->hdisplay, mode->vdisplay); | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ drivers/gpu/drm/virtio/virtgpu_display.c:208:44: warning: passing argument 3 of '___drm_dbg' makes pointer from integer without a cast [-Wint-conversion] 208 | DRM_DEBUG("del mode: %dx%d\n", mode->hdisplay, mode->vdisplay); | ~~~~^~~~~~~~~~ | | | u16 {aka short unsigned int} include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_display.c:208:9: note: in expansion of macro 'DRM_DEBUG' 208 | DRM_DEBUG("del mode: %dx%d\n", mode->hdisplay, mode->vdisplay); | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'u16' {aka 'short unsigned int'} 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ -- In file included from include/drm/drm_mm.h:51, from include/drm/drm_vma_manager.h:26, from include/drm/drm_gem.h:40, from drivers/gpu/drm/virtio/virtgpu_drv.h:40, from drivers/gpu/drm/virtio/virtgpu_vq.c:34: drivers/gpu/drm/virtio/virtgpu_vq.c: In function 'reclaim_vbufs': 191 | DRM_DEBUG("Huh? zero vbufs reclaimed"); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_vq.c:191:17: note: in expansion of macro 'DRM_DEBUG' 191 | DRM_DEBUG("Huh? zero vbufs reclaimed"); | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ include/drm/drm_print.h:530:41: error: too few arguments to function '___drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~ include/drm/drm_print.h:572:9: note: in expansion of macro '__drm_dbg' 572 | __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__) | ^~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c:191:17: note: in expansion of macro 'DRM_DEBUG' 191 | DRM_DEBUG("Huh? zero vbufs reclaimed"); | ^~~~~~~~~ include/drm/drm_print.h:525:6: note: declared here 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ^~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c: In function 'virtio_gpu_dequeue_ctrl_func': drivers/gpu/drm/virtio/virtgpu_vq.c:226:43: error: incompatible type for argument 2 of '___drm_dbg' 226 | DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type)); | ^~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_vq.c:226:33: note: in expansion of macro 'DRM_DEBUG' 226 | DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type)); | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ In file included from include/linux/swab.h:5, from include/uapi/linux/byteorder/big_endian.h:14, from include/linux/byteorder/big_endian.h:5, from arch/openrisc/include/uapi/asm/byteorder.h:1, from include/asm-generic/bitops/le.h:6, from arch/openrisc/include/asm/bitops.h:45, from include/linux/bitops.h:33, from include/linux/log2.h:12, from include/asm-generic/div64.h:55, from ./arch/openrisc/include/generated/asm/div64.h:1, from include/linux/math.h:5, from include/linux/math64.h:6, from include/linux/time64.h:5, from include/linux/restart_block.h:10, from include/linux/thread_info.h:14, from include/asm-generic/current.h:5, from ./arch/openrisc/include/generated/asm/current.h:1, from include/linux/sched.h:12, from include/linux/ratelimit.h:6, from include/linux/dev_printk.h:16, from include/linux/device.h:15, from include/linux/dma-mapping.h:7, from drivers/gpu/drm/virtio/virtgpu_vq.c:29: 118 | (__builtin_constant_p((__u32)(x)) ? \ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 119 | ___constant_swab32(x) : \ | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ | | | unsigned int 120 | __fswab32(x)) | ~~~~~~~~~~~~~ include/uapi/linux/byteorder/big_endian.h:35:26: note: in expansion of macro '__swab32' 35 | #define __le32_to_cpu(x) __swab32((__force __u32)(__le32)(x)) | ^~~~~~~~ include/linux/byteorder/generic.h:89:21: note: in expansion of macro '__le32_to_cpu' 89 | #define le32_to_cpu __le32_to_cpu | ^~~~~~~~~~~~~ include/drm/drm_print.h:530:64: note: in expansion of macro 'le32_to_cpu' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ include/drm/drm_print.h:572:9: note: in expansion of macro '__drm_dbg' 572 | __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__) | ^~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c:226:33: note: in expansion of macro 'DRM_DEBUG' 226 | DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type)); | ^~~~~~~~~ In file included from include/drm/drm_mm.h:51, from include/drm/drm_vma_manager.h:26, from include/drm/drm_gem.h:40, from drivers/gpu/drm/virtio/virtgpu_drv.h:40, from drivers/gpu/drm/virtio/virtgpu_vq.c:34: include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'unsigned int' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c: In function 'virtio_gpu_cmd_get_display_info_cb': drivers/gpu/drm/virtio/virtgpu_vq.c:651:35: error: incompatible type for argument 2 of '___drm_dbg' 651 | DRM_DEBUG("output %d: %dx%d+%d+%d", i, | ^~~~~~~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_vq.c:651:25: note: in expansion of macro 'DRM_DEBUG' 651 | DRM_DEBUG("output %d: %dx%d+%d+%d", i, | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ 651 | DRM_DEBUG("output %d: %dx%d+%d+%d", i, | ^ | | | int include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c:651:25: note: in expansion of macro 'DRM_DEBUG' 651 | DRM_DEBUG("output %d: %dx%d+%d+%d", i, | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'int' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c:657:35: error: incompatible type for argument 2 of '___drm_dbg' 657 | DRM_DEBUG("output %d: disabled", i); | ^~~~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_vq.c:657:25: note: in expansion of macro 'DRM_DEBUG' 657 | DRM_DEBUG("output %d: disabled", i); | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c:657:58: warning: passing argument 3 of '___drm_dbg' makes pointer from integer without a cast [-Wint-conversion] 657 | DRM_DEBUG("output %d: disabled", i); | ^ | | | int include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_vq.c:657:25: note: in expansion of macro 'DRM_DEBUG' 657 | DRM_DEBUG("output %d: disabled", i); | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'int' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ -- In file included from include/drm/drm_mm.h:51, from include/drm/drm_vma_manager.h:26, from include/drm/drm_gem.h:40, from drivers/gpu/drm/virtio/virtgpu_drv.h:40, from drivers/gpu/drm/virtio/virtgpu_plane.c:31: drivers/gpu/drm/virtio/virtgpu_plane.c: In function 'virtio_gpu_primary_plane_update': 185 | DRM_DEBUG("nofb\n"); | ^~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_plane.c:185:17: note: in expansion of macro 'DRM_DEBUG' 185 | DRM_DEBUG("nofb\n"); | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ include/drm/drm_print.h:530:41: error: too few arguments to function '___drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~ include/drm/drm_print.h:572:9: note: in expansion of macro '__drm_dbg' 572 | __drm_dbg(DRM_UT_CORE, fmt, ##__VA_ARGS__) | ^~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:185:17: note: in expansion of macro 'DRM_DEBUG' 185 | DRM_DEBUG("nofb\n"); | ^~~~~~~~~ include/drm/drm_print.h:525:6: note: declared here 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ^~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:208:27: error: incompatible type for argument 2 of '___drm_dbg' 208 | DRM_DEBUG("handle 0x%x, crtc %dx%d+%d+%d, src %dx%d+%d+%d\n", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_plane.c:208:17: note: in expansion of macro 'DRM_DEBUG' 208 | DRM_DEBUG("handle 0x%x, crtc %dx%d+%d+%d, src %dx%d+%d+%d\n", | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ 209 | bo->hw_res_handle, | ~~^~~~~~~~~~~~~~~ | | | uint32_t {aka unsigned int} include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:208:17: note: in expansion of macro 'DRM_DEBUG' 208 | DRM_DEBUG("handle 0x%x, crtc %dx%d+%d+%d, src %dx%d+%d+%d\n", | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'uint32_t' {aka 'unsigned int'} 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c: In function 'virtio_gpu_cursor_plane_update': drivers/gpu/drm/virtio/virtgpu_plane.c:331:27: error: incompatible type for argument 2 of '___drm_dbg' 331 | DRM_DEBUG("update, handle %d, pos +%d+%d, hot %d,%d\n", handle, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_plane.c:331:17: note: in expansion of macro 'DRM_DEBUG' 331 | DRM_DEBUG("update, handle %d, pos +%d+%d, hot %d,%d\n", handle, | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:331:73: warning: passing argument 3 of '___drm_dbg' makes pointer from integer without a cast [-Wint-conversion] 331 | DRM_DEBUG("update, handle %d, pos +%d+%d, hot %d,%d\n", handle, | ^~~~~~ | | | uint32_t {aka unsigned int} include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:331:17: note: in expansion of macro 'DRM_DEBUG' 331 | DRM_DEBUG("update, handle %d, pos +%d+%d, hot %d,%d\n", handle, | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'uint32_t' {aka 'unsigned int'} 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:349:27: error: incompatible type for argument 2 of '___drm_dbg' 349 | DRM_DEBUG("move +%d+%d\n", | ^~~~~~~~~~~~~~~ | | | char * include/drm/drm_print.h:530:57: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~ drivers/gpu/drm/virtio/virtgpu_plane.c:349:17: note: in expansion of macro 'DRM_DEBUG' 349 | DRM_DEBUG("move +%d+%d\n", | ^~~~~~~~~ include/drm/drm_print.h:525:63: note: expected 'enum drm_debug_category' but argument is of type 'char *' 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:350:39: warning: passing argument 3 of '___drm_dbg' makes pointer from integer without a cast [-Wint-conversion] 350 | plane->state->crtc_x, | ~~~~~~~~~~~~^~~~~~~~ | | | int32_t {aka int} include/drm/drm_print.h:530:64: note: in definition of macro '__drm_dbg' 530 | #define __drm_dbg(cat, fmt, ...) ___drm_dbg(cat, fmt, ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/virtio/virtgpu_plane.c:349:17: note: in expansion of macro 'DRM_DEBUG' 349 | DRM_DEBUG("move +%d+%d\n", | ^~~~~~~~~ include/drm/drm_print.h:525:85: note: expected 'const char *' but argument is of type 'int32_t' {aka 'int'} 525 | void ___drm_dbg(struct _ddebug *desc, enum drm_debug_category category, const char *format, ...); | ~~~~~~~~~~~~^~~~~~ vim +/___drm_dbg +179 drivers/gpu/drm/virtio/virtgpu_display.c a3d639776e601d Sam Ravnborg 2019-06-30 34 a3d639776e601d Sam Ravnborg 2019-06-30 @35 #include "virtgpu_drv.h" dc5698e80cf724 Dave Airlie 2013-09-09 36 bbbed8884f8e62 Gerd Hoffmann 2016-05-26 37 #define XRES_MIN 32 bbbed8884f8e62 Gerd Hoffmann 2016-05-26 38 #define YRES_MIN 32 dc5698e80cf724 Dave Airlie 2013-09-09 39 dc5698e80cf724 Dave Airlie 2013-09-09 40 #define XRES_DEF 1024 dc5698e80cf724 Dave Airlie 2013-09-09 41 #define YRES_DEF 768 dc5698e80cf724 Dave Airlie 2013-09-09 42 dc5698e80cf724 Dave Airlie 2013-09-09 43 #define XRES_MAX 8192 dc5698e80cf724 Dave Airlie 2013-09-09 44 #define YRES_MAX 8192 dc5698e80cf724 Dave Airlie 2013-09-09 45 570c815698c4c1 Gurchetan Singh 2019-12-18 46 #define drm_connector_to_virtio_gpu_output(x) \ 570c815698c4c1 Gurchetan Singh 2019-12-18 47 container_of(x, struct virtio_gpu_output, conn) 570c815698c4c1 Gurchetan Singh 2019-12-18 48 dc5698e80cf724 Dave Airlie 2013-09-09 49 static const struct drm_crtc_funcs virtio_gpu_crtc_funcs = { dc5698e80cf724 Dave Airlie 2013-09-09 50 .set_config = drm_atomic_helper_set_config, dc5698e80cf724 Dave Airlie 2013-09-09 51 .destroy = drm_crtc_cleanup, dc5698e80cf724 Dave Airlie 2013-09-09 52 0d841ac0ec213f Daniel Vetter 2016-06-10 53 .page_flip = drm_atomic_helper_page_flip, dc5698e80cf724 Dave Airlie 2013-09-09 54 .reset = drm_atomic_helper_crtc_reset, dc5698e80cf724 Dave Airlie 2013-09-09 55 .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state, dc5698e80cf724 Dave Airlie 2013-09-09 56 .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state, dc5698e80cf724 Dave Airlie 2013-09-09 57 }; dc5698e80cf724 Dave Airlie 2013-09-09 58 dc5698e80cf724 Dave Airlie 2013-09-09 59 static const struct drm_framebuffer_funcs virtio_gpu_fb_funcs = { 3823da3aeb47c1 Daniel Stone 2018-03-30 60 .create_handle = drm_gem_fb_create_handle, 3823da3aeb47c1 Daniel Stone 2018-03-30 61 .destroy = drm_gem_fb_destroy, b07baa0393d09f Gerd Hoffmann 2019-06-11 62 .dirty = drm_atomic_helper_dirtyfb, dc5698e80cf724 Dave Airlie 2013-09-09 63 }; dc5698e80cf724 Dave Airlie 2013-09-09 64 9567728ae28c6a Gurchetan Singh 2019-12-18 65 static int dc5698e80cf724 Dave Airlie 2013-09-09 66 virtio_gpu_framebuffer_init(struct drm_device *dev, dc5698e80cf724 Dave Airlie 2013-09-09 67 struct virtio_gpu_framebuffer *vgfb, 1eb83451ba55d7 Ville Syrjälä 2015-11-11 68 const struct drm_mode_fb_cmd2 *mode_cmd, dc5698e80cf724 Dave Airlie 2013-09-09 69 struct drm_gem_object *obj) dc5698e80cf724 Dave Airlie 2013-09-09 70 { dc5698e80cf724 Dave Airlie 2013-09-09 71 int ret; 9d492b6bece4ec Rodrigo Siqueira 2018-02-22 72 3823da3aeb47c1 Daniel Stone 2018-03-30 73 vgfb->base.obj[0] = obj; dc5698e80cf724 Dave Airlie 2013-09-09 74 9d020467a1c2f7 Ville Syrjälä 2016-11-18 75 drm_helper_mode_fill_fb_struct(dev, &vgfb->base, mode_cmd); 9d020467a1c2f7 Ville Syrjälä 2016-11-18 76 dc5698e80cf724 Dave Airlie 2013-09-09 77 ret = drm_framebuffer_init(dev, &vgfb->base, &virtio_gpu_fb_funcs); dc5698e80cf724 Dave Airlie 2013-09-09 78 if (ret) { 3823da3aeb47c1 Daniel Stone 2018-03-30 79 vgfb->base.obj[0] = NULL; dc5698e80cf724 Dave Airlie 2013-09-09 80 return ret; dc5698e80cf724 Dave Airlie 2013-09-09 81 } dc5698e80cf724 Dave Airlie 2013-09-09 82 return 0; dc5698e80cf724 Dave Airlie 2013-09-09 83 } dc5698e80cf724 Dave Airlie 2013-09-09 84 dc5698e80cf724 Dave Airlie 2013-09-09 85 static void virtio_gpu_crtc_mode_set_nofb(struct drm_crtc *crtc) dc5698e80cf724 Dave Airlie 2013-09-09 86 { dc5698e80cf724 Dave Airlie 2013-09-09 87 struct drm_device *dev = crtc->dev; dc5698e80cf724 Dave Airlie 2013-09-09 88 struct virtio_gpu_device *vgdev = dev->dev_private; dc5698e80cf724 Dave Airlie 2013-09-09 89 struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); dc5698e80cf724 Dave Airlie 2013-09-09 90 dc5698e80cf724 Dave Airlie 2013-09-09 91 virtio_gpu_cmd_set_scanout(vgdev, output->index, 0, dc5698e80cf724 Dave Airlie 2013-09-09 92 crtc->mode.hdisplay, dc5698e80cf724 Dave Airlie 2013-09-09 93 crtc->mode.vdisplay, 0, 0); 790bcd79142885 Gerd Hoffmann 2020-02-14 94 virtio_gpu_notify(vgdev); dc5698e80cf724 Dave Airlie 2013-09-09 95 } dc5698e80cf724 Dave Airlie 2013-09-09 96 0b20a0f8c3cb6f Laurent Pinchart 2017-06-30 97 static void virtio_gpu_crtc_atomic_enable(struct drm_crtc *crtc, 351f950db4ab28 Maxime Ripard 2020-10-08 98 struct drm_atomic_state *state) dc5698e80cf724 Dave Airlie 2013-09-09 99 { dc5698e80cf724 Dave Airlie 2013-09-09 100 } dc5698e80cf724 Dave Airlie 2013-09-09 101 64581714b58bc3 Laurent Pinchart 2017-06-30 102 static void virtio_gpu_crtc_atomic_disable(struct drm_crtc *crtc, 351f950db4ab28 Maxime Ripard 2020-10-08 103 struct drm_atomic_state *state) dc5698e80cf724 Dave Airlie 2013-09-09 104 { dc5698e80cf724 Dave Airlie 2013-09-09 105 struct drm_device *dev = crtc->dev; dc5698e80cf724 Dave Airlie 2013-09-09 106 struct virtio_gpu_device *vgdev = dev->dev_private; dc5698e80cf724 Dave Airlie 2013-09-09 107 struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); dc5698e80cf724 Dave Airlie 2013-09-09 108 dc5698e80cf724 Dave Airlie 2013-09-09 109 virtio_gpu_cmd_set_scanout(vgdev, output->index, 0, 0, 0, 0, 0); 790bcd79142885 Gerd Hoffmann 2020-02-14 110 virtio_gpu_notify(vgdev); dc5698e80cf724 Dave Airlie 2013-09-09 111 } dc5698e80cf724 Dave Airlie 2013-09-09 112 dc5698e80cf724 Dave Airlie 2013-09-09 113 static int virtio_gpu_crtc_atomic_check(struct drm_crtc *crtc, 29b77ad7b9ca8c Maxime Ripard 2020-10-28 114 struct drm_atomic_state *state) dc5698e80cf724 Dave Airlie 2013-09-09 115 { dc5698e80cf724 Dave Airlie 2013-09-09 116 return 0; dc5698e80cf724 Dave Airlie 2013-09-09 117 } dc5698e80cf724 Dave Airlie 2013-09-09 118 9a11d2e7e66b6b Gustavo Padovan 2016-04-14 119 static void virtio_gpu_crtc_atomic_flush(struct drm_crtc *crtc, f6ebe9f9c9233a Maxime Ripard 2020-10-28 120 struct drm_atomic_state *state) 9a11d2e7e66b6b Gustavo Padovan 2016-04-14 121 { 253f28b6237264 Maxime Ripard 2020-11-05 122 struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, 253f28b6237264 Maxime Ripard 2020-11-05 123 crtc); 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 124 struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 125 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 126 /* 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 127 * virtio-gpu can't do modeset and plane update operations 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 128 * independent from each other. So the actual modeset happens 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 129 * in the plane update callback, and here we just check 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 130 * whenever we must force the modeset. 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 131 */ 253f28b6237264 Maxime Ripard 2020-11-05 132 if (drm_atomic_crtc_needs_modeset(crtc_state)) { 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 133 output->needs_modeset = true; 1bc371cd0ec907 Gerd Hoffmann 2020-08-18 134 } 9a11d2e7e66b6b Gustavo Padovan 2016-04-14 135 } 9a11d2e7e66b6b Gustavo Padovan 2016-04-14 136 dc5698e80cf724 Dave Airlie 2013-09-09 137 static const struct drm_crtc_helper_funcs virtio_gpu_crtc_helper_funcs = { dc5698e80cf724 Dave Airlie 2013-09-09 138 .mode_set_nofb = virtio_gpu_crtc_mode_set_nofb, dc5698e80cf724 Dave Airlie 2013-09-09 139 .atomic_check = virtio_gpu_crtc_atomic_check, 9a11d2e7e66b6b Gustavo Padovan 2016-04-14 140 .atomic_flush = virtio_gpu_crtc_atomic_flush, 0b20a0f8c3cb6f Laurent Pinchart 2017-06-30 141 .atomic_enable = virtio_gpu_crtc_atomic_enable, 64581714b58bc3 Laurent Pinchart 2017-06-30 142 .atomic_disable = virtio_gpu_crtc_atomic_disable, dc5698e80cf724 Dave Airlie 2013-09-09 143 }; dc5698e80cf724 Dave Airlie 2013-09-09 144 dc5698e80cf724 Dave Airlie 2013-09-09 145 static void virtio_gpu_enc_mode_set(struct drm_encoder *encoder, dc5698e80cf724 Dave Airlie 2013-09-09 146 struct drm_display_mode *mode, dc5698e80cf724 Dave Airlie 2013-09-09 147 struct drm_display_mode *adjusted_mode) dc5698e80cf724 Dave Airlie 2013-09-09 148 { dc5698e80cf724 Dave Airlie 2013-09-09 149 } dc5698e80cf724 Dave Airlie 2013-09-09 150 dc5698e80cf724 Dave Airlie 2013-09-09 151 static void virtio_gpu_enc_enable(struct drm_encoder *encoder) dc5698e80cf724 Dave Airlie 2013-09-09 152 { dc5698e80cf724 Dave Airlie 2013-09-09 153 } dc5698e80cf724 Dave Airlie 2013-09-09 154 dc5698e80cf724 Dave Airlie 2013-09-09 155 static void virtio_gpu_enc_disable(struct drm_encoder *encoder) dc5698e80cf724 Dave Airlie 2013-09-09 156 { dc5698e80cf724 Dave Airlie 2013-09-09 157 } dc5698e80cf724 Dave Airlie 2013-09-09 158 dc5698e80cf724 Dave Airlie 2013-09-09 159 static int virtio_gpu_conn_get_modes(struct drm_connector *connector) dc5698e80cf724 Dave Airlie 2013-09-09 160 { dc5698e80cf724 Dave Airlie 2013-09-09 161 struct virtio_gpu_output *output = dc5698e80cf724 Dave Airlie 2013-09-09 162 drm_connector_to_virtio_gpu_output(connector); dc5698e80cf724 Dave Airlie 2013-09-09 163 struct drm_display_mode *mode = NULL; dc5698e80cf724 Dave Airlie 2013-09-09 164 int count, width, height; dc5698e80cf724 Dave Airlie 2013-09-09 165 b4b01b4995fb15 Gerd Hoffmann 2018-10-30 166 if (output->edid) { b4b01b4995fb15 Gerd Hoffmann 2018-10-30 167 count = drm_add_edid_modes(connector, output->edid); b4b01b4995fb15 Gerd Hoffmann 2018-10-30 168 if (count) b4b01b4995fb15 Gerd Hoffmann 2018-10-30 169 return count; b4b01b4995fb15 Gerd Hoffmann 2018-10-30 170 } b4b01b4995fb15 Gerd Hoffmann 2018-10-30 171 dc5698e80cf724 Dave Airlie 2013-09-09 172 width = le32_to_cpu(output->info.r.width); dc5698e80cf724 Dave Airlie 2013-09-09 173 height = le32_to_cpu(output->info.r.height); dc5698e80cf724 Dave Airlie 2013-09-09 174 count = drm_add_modes_noedid(connector, XRES_MAX, YRES_MAX); dc5698e80cf724 Dave Airlie 2013-09-09 175 dc5698e80cf724 Dave Airlie 2013-09-09 176 if (width == 0 || height == 0) { dc5698e80cf724 Dave Airlie 2013-09-09 177 drm_set_preferred_mode(connector, XRES_DEF, YRES_DEF); dc5698e80cf724 Dave Airlie 2013-09-09 178 } else { dc5698e80cf724 Dave Airlie 2013-09-09 @179 DRM_DEBUG("add mode: %dx%d\n", width, height); dc5698e80cf724 Dave Airlie 2013-09-09 180 mode = drm_cvt_mode(connector->dev, width, height, 60, dc5698e80cf724 Dave Airlie 2013-09-09 181 false, false, false); dc5698e80cf724 Dave Airlie 2013-09-09 182 mode->type |= DRM_MODE_TYPE_PREFERRED; dc5698e80cf724 Dave Airlie 2013-09-09 183 drm_mode_probed_add(connector, mode); dc5698e80cf724 Dave Airlie 2013-09-09 184 count++; dc5698e80cf724 Dave Airlie 2013-09-09 185 } dc5698e80cf724 Dave Airlie 2013-09-09 186 dc5698e80cf724 Dave Airlie 2013-09-09 187 return count; dc5698e80cf724 Dave Airlie 2013-09-09 188 } dc5698e80cf724 Dave Airlie 2013-09-09 189 :::::: The code at line 179 was first introduced by commit :::::: dc5698e80cf724770283e10414054662bdf6ccfa Add virtio gpu driver. :::::: TO: Dave Airlie <airlied(a)gmail.com&gt; :::::: CC: Gerd Hoffmann <kraxel(a)redhat.com&gt; --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org