[kbuild-all] [chrome-os:chromeos-4.4 9959/9999] drivers/md/dm-crypt.c:1594:43: warning: signed and unsigned type in conditional expression

tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-4.4 head: ccf40bc6e3f39dc1d6410b6a2c97869bfe4f3ff5 commit: 2e533e1931bd9bc7be1d9b66871418cd0fc966c5 [9959/9999] BACKPORT: dm crypt: add ability to use keys from the kernel key retention service config: xtensa-randconfig-r023-20220208 (https://download.01.org/0day-ci/archive/20220209/202202090841.7KnHh5Ph-lk...) compiler: xtensa-linux-gcc (GCC) 7.5.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git remote add chrome-os https://chromium.googlesource.com/chromiumos/third_party/kernel git fetch --no-tags chrome-os chromeos-4.4 git checkout 2e533e1931bd9bc7be1d9b66871418cd0fc966c5 # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross O=build_dir ARCH=xtensa SHELL=/bin/bash drivers/md/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): ^~~~~~~~~ include/linux/scatterlist.h:140:10: note: in expansion of macro 'virt_addr_valid' BUG_ON(!virt_addr_valid(buf)); ^~~~~~~~~~~~~~~ arch/xtensa/include/asm/page.h:175:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr) ^ include/linux/compiler.h:153:53: note: in definition of macro 'unlikely' # define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0)) ^ include/linux/scatterlist.h:140:2: note: in expansion of macro 'BUG_ON' BUG_ON(!virt_addr_valid(buf)); ^~~~~~ arch/xtensa/include/asm/page.h:183:32: note: in expansion of macro 'pfn_valid' #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT) ^~~~~~~~~ include/linux/scatterlist.h:140:10: note: in expansion of macro 'virt_addr_valid' BUG_ON(!virt_addr_valid(buf)); ^~~~~~~~~~~~~~~ arch/xtensa/include/asm/page.h:175:9: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] ((pfn) >= ARCH_PFN_OFFSET && ((pfn) - ARCH_PFN_OFFSET) < max_mapnr) ^ include/linux/compiler.h:126:47: note: in definition of macro 'likely_notrace' #define likely_notrace(x) __builtin_expect(!!(x), 1) ^ include/linux/compiler.h:153:58: note: in expansion of macro '__branch_check__' # define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0)) ^~~~~~~~~~~~~~~~ include/asm-generic/bug.h:58:36: note: in expansion of macro 'unlikely' #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0) ^~~~~~~~ include/linux/scatterlist.h:140:2: note: in expansion of macro 'BUG_ON' BUG_ON(!virt_addr_valid(buf)); ^~~~~~ arch/xtensa/include/asm/page.h:183:32: note: in expansion of macro 'pfn_valid' #define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT) ^~~~~~~~~ include/linux/scatterlist.h:140:10: note: in expansion of macro 'virt_addr_valid' BUG_ON(!virt_addr_valid(buf)); ^~~~~~~~~~~~~~~ In file included from include/linux/uaccess.h:8:0, from include/linux/highmem.h:8, from include/linux/bio.h:23, from drivers/md/dm-crypt.c:16: arch/xtensa/include/asm/checksum.h: In function 'csum_and_copy_to_user': arch/xtensa/include/asm/uaccess.h:189:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] (((size) <= TASK_SIZE)&&((addr) <= TASK_SIZE-(size))) ^ arch/xtensa/include/asm/uaccess.h:190:49: note: in expansion of macro '__user_ok' #define __access_ok(addr, size) (__kernel_ok || __user_ok((addr), (size))) ^~~~~~~~~ arch/xtensa/include/asm/uaccess.h:191:37: note: in expansion of macro '__access_ok' #define access_ok(type, addr, size) __access_ok((unsigned long)(addr), (size)) ^~~~~~~~~~~ arch/xtensa/include/asm/checksum.h:248:6: note: in expansion of macro 'access_ok' if (access_ok(VERIFY_WRITE, dst, len)) ^~~~~~~~~ include/net/checksum.h: In function 'csum_and_copy_from_user': arch/xtensa/include/asm/uaccess.h:189:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] (((size) <= TASK_SIZE)&&((addr) <= TASK_SIZE-(size))) ^ arch/xtensa/include/asm/uaccess.h:190:49: note: in expansion of macro '__user_ok' #define __access_ok(addr, size) (__kernel_ok || __user_ok((addr), (size))) ^~~~~~~~~ arch/xtensa/include/asm/uaccess.h:191:37: note: in expansion of macro '__access_ok' #define access_ok(type, addr, size) __access_ok((unsigned long)(addr), (size)) ^~~~~~~~~~~ include/net/checksum.h:33:6: note: in expansion of macro 'access_ok' if (access_ok(VERIFY_READ, src, len)) ^~~~~~~~~ In file included from include/crypto/algapi.h:18:0, from drivers/md/dm-crypt.c:31: include/linux/skbuff.h: In function 'skb_add_data': include/linux/skbuff.h:2687:23: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] &csum, from) == copy) { ^~ include/linux/skbuff.h:2691:60: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] } else if (copy_from_iter(skb_put(skb, copy), copy, from) == copy) ^~ include/linux/skbuff.h: In function 'skb_can_coalesce': include/linux/skbuff.h:2705:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] off == frag->page_offset + skb_frag_size(frag); ^~ include/linux/skbuff.h: In function 'memcpy_from_msg': include/linux/skbuff.h:2933:51: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] return copy_from_iter(data, len, &msg->msg_iter) == len ? 0 : -EFAULT; ^~ include/linux/skbuff.h: In function 'memcpy_to_msg': include/linux/skbuff.h:2938:49: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] return copy_to_iter(data, len, &msg->msg_iter) == len ? 0 : -EFAULT; ^~ drivers/md/dm-crypt.c: In function 'crypt_iv_benbi_ctr': drivers/md/dm-crypt.c:430:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (1 << log != bs) { ^~ drivers/md/dm-crypt.c: In function 'crypt_setkey': drivers/md/dm-crypt.c:1482:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i = 0; i < cc->tfms_count; i++) { ^ drivers/md/dm-crypt.c: In function 'get_key_size': return (*key_string[0] == ':') ? -EINVAL : strlen(*key_string) >> 1; ^ drivers/md/dm-crypt.c: In function 'crypt_message': drivers/md/dm-crypt.c:2163:37: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (key_size < 0 || cc->key_size != key_size) { ^~ vim +1594 drivers/md/dm-crypt.c 1591 1592 static int get_key_size(char **key_string) 1593 { 1595 } 1596 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org